Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add safe classes #9

Closed
wants to merge 7 commits into from
Closed

add safe classes #9

wants to merge 7 commits into from

Conversation

MoLow
Copy link
Contributor

@MoLow MoLow commented Jul 6, 2023

No description provided.

MoLow added a commit to MoLow/node-primordials that referenced this pull request Jul 6, 2023
@MoLow
tmp: isaacs#8 + isaacs#9
de190f7
@MoLow MoLow mentioned this pull request Jul 6, 2023
Open
MoLow added a commit to MoLow/node-primordials that referenced this pull request Jul 6, 2023
@MoLow
tmp: isaacs#8 + isaacs#9
9d228c5
@MoLow @isaacs
add safe classes
f469fa4 
PR-URL: isaacs#9
Credit: @MoLow
Close: isaacs#9
Reviewed-by: @isaacs
isaacs
isaacs requested changes Jul 11, 2023
View reviewed changes
Copy link
Owner

@isaacs isaacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly fine, but tests aren't complete yet.

----------|---------|----------|---------|---------|-----------------------------------------------------------------------
File      | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                                                     
----------|---------|----------|---------|---------|-----------------------------------------------------------------------
All files |   99.09 |      100 |    82.5 |   99.09 |                                                                       
 index.ts |   99.09 |      100 |    82.5 |   99.09 | 2381-2394,2439-2440,2470-2471,2486-2487,2495-2496,2503-2504,2512-2518 
----------|---------|----------|---------|---------|-----------------------------------------------------------------------

src/index.ts Outdated Show resolved Hide resolved
MoLow and others added 3 commits July 11, 2023 23:00
@MoLow @isaacs
Update src/index.ts
b8e4a8a 
Co-authored-by: isaacs <i@izs.me>
@MoLow
fixes
91995ea
@MoLow
fix
306a195
@MoLow
Copy link
Contributor Author

MoLow commented Jul 11, 2023

@isaacs can we remove node 14 from CI? it is EOL

@MoLow MoLow requested a review from isaacs July 12, 2023 12:35
isaacs
isaacs reviewed Jul 26, 2023
View reviewed changes
src/index.ts Outdated Show resolved Hide resolved
@MoLow MoLow requested a review from isaacs July 26, 2023 18:56
@isaacs isaacs closed this in f469fa4 Sep 15, 2023
@MoLow MoLow deleted the safe-newables branch September 17, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isaacs isaacs Awaiting requested review from isaacs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MoLow @isaacs