Fix callLimit() not working when /proc is inaccessible #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaacs
pushed a commit
to codedokode/promise-call-limit
that referenced
this pull request
Mar 31, 2023
When /proc is not available and os.cpus() returns an empty list, callLimit() doesn't run any of the functions. Fix this and also update tap which was broken in newer node versions PR-URL: isaacs#11 Credit: @codedokode Close: isaacs#11 Reviewed-by: @isaacs
isaacs
force-pushed
the
fix-invalid-cpu-count
branch
from
609ee3d to
38103a7
Compare
When /proc is not available and os.cpus() returns an empty list, callLimit() doesn't run any of the functions. Fix this and also update tap which was broken in newer node versions PR-URL: isaacs#11 Credit: @codedokode Close: isaacs#11 Reviewed-by: @isaacs EDIT(@isaacs): formatted commit message and comment for line length, added coverage ignore for node version-specific workaround
isaacs
force-pushed
the
fix-invalid-cpu-count
branch
from
38103a7 to
ad9ab47
Compare
|
Thanks! Published in 1.0.2 |
2 tasks
codedokode
added a commit
to codedokode/node
that referenced
this pull request
Apr 1, 2023
Some developers might be not aware that os.cpus() may return an empty list. This [has caused a bug before](isaacs/promise-call-limit#11).
codedokode
added a commit
to codedokode/node
that referenced
this pull request
Apr 1, 2023
It is not obvious that in some cases cpus() returns an empty list and this has caused a bug before: isaacs/promise-call-limit#11
Trott
pushed a commit
to codedokode/node
that referenced
this pull request
Apr 3, 2023
It is not obvious that in some cases cpus() returns an empty list and this has caused a bug before: isaacs/promise-call-limit#11
Trott
pushed a commit
to codedokode/node
that referenced
this pull request
Apr 4, 2023
It is not obvious that in some cases cpus() returns an empty list and this has caused a bug before: isaacs/promise-call-limit#11 PR-URL: nodejs#47363 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Rich Trott <rtrott@gmail.com>
Trott
pushed a commit
to codedokode/node
that referenced
this pull request
Apr 4, 2023
It is not obvious that in some cases cpus() returns an empty list and this has caused a bug before: isaacs/promise-call-limit#11 PR-URL: nodejs#47363 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Rich Trott <rtrott@gmail.com>
RafaelGSS
pushed a commit
to nodejs/node
that referenced
this pull request
Apr 5, 2023
It is not obvious that in some cases cpus() returns an empty list and this has caused a bug before: isaacs/promise-call-limit#11 PR-URL: #47363 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Rich Trott <rtrott@gmail.com>
RafaelGSS
pushed a commit
to nodejs/node
that referenced
this pull request
Apr 5, 2023
It is not obvious that in some cases cpus() returns an empty list and this has caused a bug before: isaacs/promise-call-limit#11 PR-URL: #47363 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Rich Trott <rtrott@gmail.com>
RafaelGSS
pushed a commit
to nodejs/node
that referenced
this pull request
Apr 6, 2023
It is not obvious that in some cases cpus() returns an empty list and this has caused a bug before: isaacs/promise-call-limit#11 PR-URL: #47363 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Rich Trott <rtrott@gmail.com>
RafaelGSS
pushed a commit
to nodejs/node
that referenced
this pull request
Apr 7, 2023
It is not obvious that in some cases cpus() returns an empty list and this has caused a bug before: isaacs/promise-call-limit#11 PR-URL: #47363 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Rich Trott <rtrott@gmail.com>
RafaelGSS
pushed a commit
to nodejs/node
that referenced
this pull request
Apr 8, 2023
It is not obvious that in some cases cpus() returns an empty list and this has caused a bug before: isaacs/promise-call-limit#11 PR-URL: #47363 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Rich Trott <rtrott@gmail.com>
RafaelGSS
pushed a commit
to nodejs/node
that referenced
this pull request
Apr 13, 2023
It is not obvious that in some cases cpus() returns an empty list and this has caused a bug before: isaacs/promise-call-limit#11 PR-URL: #47363 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams
pushed a commit
to nodejs/node
that referenced
this pull request
Jul 6, 2023
It is not obvious that in some cases cpus() returns an empty list and this has caused a bug before: isaacs/promise-call-limit#11 PR-URL: #47363 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Rich Trott <rtrott@gmail.com>
MoLow
pushed a commit
to MoLow/node
that referenced
this pull request
Jul 6, 2023
It is not obvious that in some cases cpus() returns an empty list and this has caused a bug before: isaacs/promise-call-limit#11 PR-URL: nodejs#47363 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When /proc is not accessible, os.cpus() returns an empty list, defLimit is 0 and callLimit() doesn't run any of the functions. Fix this and also update tap which was broken in newer node versions.