fix issue 261: parser.tag is containing tag in non-text nodes #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #261.
According to the documentation, the parser object property "tag" reflects "The current tag being dealt with."
What is the "current tag". I assume this is the containing tag (or element) in case of non-tag nodes such as comments or text.
This PR ensures that
parser.tagalways is the current node.For some node types (e.g., comments) no tag has been available before. For other node types (text and processing instructions), in some cases the following node has been set. This is fixed now.
The PR contains a test file which (dynamically) generates 60 scenarios ensuring that the current tag is actually available.