New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: doctype with entities handling #272

Closed

SethFalco wants to merge 1 commit into isaacs:main from SethFalco:fix/doctype-entities

Contributor

SethFalco commented May 27, 2024 •

edited

Loading

While fixing comments in DTDs I introduced an issue by mistake where the ondoctype event would no longer fire for DOCTYPEs anymore.

While the state is DOCTYPE_DTD, append the current character if we're not changing state.
While the state is SGML_DECL, if we've established it's not a comment, and we know we're in a DOCTYPE declaration, change the state back to DOCTYPE_DTD and add the characters encountered so far.

This retains the ability to handle comments, but brings back the handling/event for DOCTYPEs declaration like entities.

I've added more tests for DOCTYPE declarations to make sure this isn't missed in future.

Related

Fixed issue introduced in fix: don't throw on comment in dtd #267


          fix: doctype with entities handling

968b53c

PR-URL: #272
Credit: @SethFalco
Close: #272
Reviewed-by: @isaacs

isaacs closed this in

968b53c

SethFalco deleted the fix/doctype-entities branch

May 27, 2024 23:47

SethFalco mentioned this pull request

chore: migrate to upstream sax svg/svgo#2017

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet