fix: do not preload default text track if preloadTextTracks is false

When preloadTextTracks option is set to false, it still preloads the default text track. This leads to duplicate tracks once the mode changes to showing and the track is loaded a second time. This includes the default text track in the behavior defined by the preloadTextTracks option.

Fixes videojs#7019

src/js/tracks/text-track.js

@@ -341,7 +341,7 @@ class TextTrack extends Track {
  // Act like we're loaded for other purposes.
  this.loaded_ = true;
  }
- if (this.preload_ || default_ || (settings.kind !== 'subtitles' && settings.kind !== 'captions')) {
+ if (this.preload_ || (settings.kind !== 'subtitles' && settings.kind !== 'captions')) {
  loadTrack(this.src, this);
  }
  } else {

test/unit/tracks/text-track.test.js

@@ -419,6 +419,52 @@ QUnit.test('enabled and disabled cuechange handler when changing mode to showing
  player.dispose();
 });
 
+QUnit.test('if preloadTextTracks is false, default tracks are not parsed until mode is showing', function(assert) {
+ this.tech.preloadTextTracks = false;
+ const clock = sinon.useFakeTimers();
+ const oldVTT = window.WebVTT;
+ let parserCreated = false;
+ const reqs = [];
+
+ this.xhr.onCreate = function(req) {
+ reqs.push(req);
+ };
+
+ window.WebVTT = () => {};
+ window.WebVTT.StringDecoder = () => {};
+ window.WebVTT.Parser = () => {
+ parserCreated = true;
+ return {
+ oncue() {},
+ onparsingerror() {},
+ onflush() {},
+ parse() {},
+ flush() {}
+ };
+ };
+
+ const tt = new TextTrack({
+ tech: this.tech,
+ src: 'http://example.com',
+ default: true
+ });
+
+ assert.notOk(reqs.length, 'Default track is not requested');
+ assert.notOk(parserCreated, 'Parser is not created');
+
+ tt.mode = 'showing';
+
+ const req = reqs.pop();
+
+ req.respond(200, null, 'WEBVTT\n');
+
+ assert.ok(parserCreated, 'Parser is created after track is showing');
+
+ clock.restore();
+ tt.off();
+ window.WebVTT = oldVTT;
+});
+
 QUnit.test('tracks are parsed if vttjs is loaded', function(assert) {
  const clock = sinon.useFakeTimers();
  const oldVTT = window.WebVTT;