Histogram range facet #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyunssong
commented
Feb 3, 2023
| @@ -34,7 +34,7 @@ class ResultList extends React.Component { | |||
| // prevent unnecessary rerendering | |||
| shouldComponentUpdate(nextProps) { | |||
| this.switchView(store.getState()['query']['view']['facet']); | |||
| if (nextProps != this.props) { | |||
| if (nextProps !== this.props) { | |||
There was a problem hiding this comment.
I am not confident if this is the right way to fix the circular dependency issue of JSON.stringify, probably will need to debug this issue and see if there is a better way than this.
hyunssong
force-pushed
the
histogram-range-facet
branch
from
87138b7
to
9dfbcc2
Compare
datadavev
approved these changes
Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create histogram support for the collection date for #114