Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Breaking Changes
NO
Description
Makes the
clearAdapters
part of the public API.When configuring integration tests one usually does the following:
However, only the test that runs first succeeds since when the second test aims to
registerAdapter
aHiveError
is thrown since the adapter already exists.There are workarounds to solve the above, like for example making use of the
override
flag inregisterAdapter
or checking if the adapter has been already registered before registering one. I dislike these approaches since they force to write logic in the codebase that is only used for and during testing purposes.Ideally, I would prefer if one could
tearDown
andclearAdapters
. And with the changes in this PR, one cantearDown
andclearAdapters
.I'm open to other suggestions or existing solutions that only modify the test file.
Type of Change