allow az_step/rg_step arguments to `as_isce3_radargrid` #102

scottstanie · 2023-02-19T21:19:55Z

This allows a more coarse radar grid, as needed by some lookup tables such as the SET correction.

(this is mostly to help with cross-repo code duplication https://github.com/opera-adt/COMPASS/pull/91/files#diff-69dd9219c200228243e2fc9517100d1c8c2887874819ba403614548352b14b29R277-R292 )

This allows a more coarse radar grid, as needed by some lookup tables such as the SET correction

vbrancat

LGTM, thanks

src/s1reader/s1_burst_slc.py

Co-authored-by: Heresh Fattahi <hersh.fattahi@gmail.com>

hfattahi · 2023-02-21T16:55:31Z

src/s1reader/s1_burst_slc.py

+            az_step = self.azimuth_time_interval
+            length = self.shape[0]
+        else:
+            length_in_seconds = length / self.azimuth_time_interval


Suggested change

length_in_seconds = length / self.azimuth_time_interval

length_in_seconds = length * self.azimuth_time_interval

hfattahi · 2023-02-21T16:56:16Z

src/s1reader/s1_burst_slc.py

+            length_in_seconds = length / self.azimuth_time_interval
+            if az_step < 0:
+                raise ValueError("az_step cannot be negative")
+            if 1 / az_step > length_in_seconds:


Suggested change

if 1 / az_step > length_in_seconds:

if az_step > length_in_seconds:

hfattahi · 2023-02-21T16:57:25Z

src/s1reader/s1_burst_slc.py

+                raise ValueError("az_step cannot be negative")
+            if 1 / az_step > length_in_seconds:
+                raise ValueError("az_step cannot be larger than radar grid")
+            length = (length / self.azimuth_time_interval) // az_step


Suggested change

length = (length / self.azimuth_time_interval) // az_step

length = (length * self.azimuth_time_interval) // az_step

hfattahi · 2023-02-21T16:58:25Z

src/s1reader/s1_burst_slc.py

+            width_in_meters = width * self.range_pixel_spacing
+            if rg_step < 0:
+                raise ValueError("rg_step cannot be negative")
+            if rg_step > width * width_in_meters:


Suggested change

if rg_step > width * width_in_meters:

if rg_step > width_in_meters:

hfattahi · 2023-02-21T17:00:50Z

Also would you please add a test here: https://github.com/opera-adt/s1-reader/blob/main/tests/test_bursts.py

fixed the division to make the tests pass

LiangJYu

LGTM

hfattahi · 2023-02-21T18:29:06Z

Thank you @scottstanie for addressing the different comments and adding the test.

Before approving this PR I would like to clarify one thing.
Our ISCE3 convention is that in radar coordinates the "sensing start" and "starting range" refer to the center of the first radar pixel. That's why if we multi-look, we have to account for the shift where the new center is. But if we decimate, that is slightly different and depending on the decimation convention we may keep the sensing start and starting range same as the original grid. In my opinion the changes in this PR is "decimation with zero offset" as defined here

FYI, the radarGridParameters in isce3 already has a multi-looking method. I think we could just add a general decimation method there as well and these downstream changes wouldn't be needed.

In the meantime if you all want to go ahead with this PR, I think I can approve but I suggest that we clarify in the doc string that:
the input azimuth step size does not change the sensing start of the grid. and similarly for range

scottstanie · 2023-02-21T19:08:51Z

Oh I didn't realize there was already the multilooking method! I wouldn't be against changing this to take (az_looks, rg_looks) instead, and just calling the isce3 method instead.

vbrancat · 2023-02-21T19:12:15Z

Oh I didn't realize there was already the multilooking method! I wouldn't be against changing this to take (az_looks, rg_looks) instead, and just calling the isce3 method instead.

I kind of find handy to directly assign the spacing of the radar grid :s

hfattahi · 2023-02-21T19:14:11Z

Oh I didn't realize there was already the multilooking method! I wouldn't be against changing this to take (az_looks, rg_looks) instead, and just calling the isce3 method instead.

But that's where exactly I wanted to clarify. What this PR meant to be? multi-looking or decimation? Do we want to change the sensing start, starting range or not?

This PR as is, is not same as multilooking method of the radar grid parameter.

vbrancat · 2023-02-21T20:12:39Z

Oh I didn't realize there was already the multilooking method! I wouldn't be against changing this to take (az_looks, rg_looks) instead, and just calling the isce3 method instead.

But that's where exactly I wanted to clarify. What this PR meant to be? multi-looking or decimation? Do we want to change the sensing start, starting range or not?

This PR as is, is not same as multilooking method of the radar grid parameter.

@scottstanie was trying to simplify some code in my SET PR. We want to perform a pure decimation of the radar grid and keep the starting range and sensing start to be the same as the original radar grid. However, we do want a coarser grid for some of the corrections.

hfattahi · 2023-02-21T20:50:03Z

Oh I didn't realize there was already the multilooking method! I wouldn't be against changing this to take (az_looks, rg_looks) instead, and just calling the isce3 method instead.

But that's where exactly I wanted to clarify. What this PR meant to be? multi-looking or decimation? Do we want to change the sensing start, starting range or not?
This PR as is, is not same as multilooking method of the radar grid parameter.

@scottstanie was trying to simplify some code in my SET PR. We want to perform a pure decimation of the radar grid and keep the starting range and sensing start to be the same as the original radar grid. However, we do want a coarser grid for some of the corrections.

Thanks @vbrancat for the clarification. I chatted with @scottstanie offline. Let's move forward with this PR. But let's make the docstring as clear as it can be regarding the starting range and azimuth time.

hfattahi

LGTM. Please clarify the docstring before merging as we discussed.

commit 0e0c7816a9b22b057a769519d302cd62e0a4e346 Author: Seongsu Jeong <sjeong.kr@gmail.com> Date: Fri Mar 3 15:39:13 2023 -0800 Two layered az fm mismatch rate (#101) * Replacing the loaders in Burst* class into class methods, with further implementation for thermal and EAP correction * fix on determining beta_naught; addressing PEP8 issues * Bug fix and feature addition to BurstEAP; restructuring LUT exportation * Readibility improvement; removing unnecessary imports * Format change on `burst_id`; keeping the absolute orbit number inside `Sentinel1BurstSlc` * updates on test_bursts.py * keeping the basename of the CADS and NADS for populating RTC metadata * Update src/s1reader/s1_annotation.py Readability improvement on equation Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_annotation.py Removing commented out code Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_annotation.py Reverting the docstring to be split into two lines for PEP8 compliance Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_annotation.py Improving docstring of the code copied from isce2 Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_burst_slc.py Removing the commented out codes Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_burst_slc.py improvement on code brevity Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_burst_slc.py renaming variable for better clarity Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_burst_slc.py renaming variable name for clarity Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_burst_slc.py variable name revised for clarity Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_burst_slc.py variable renamed for clarity Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_burst_slc.py improvement on docstring Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_burst_slc.py Readability improvement of equation Co-authored-by: Liang Yu <liangjyu@gmail.com> * addressing comments bt @LiangJYu * docstring fix; variables renamed for clarity * implemented s1_annotation.AucCal.load_from_zip_file() * readability improvement * s1_annotation.py - code cleanup; excention handling for AUX_CAL; PEP8 compliance * docstring for `s1_burst_slc.eap_compensation_lut()` * class import scheme changed * PEP8 compliance * initial structure of modification * less mod compared to the branch fork * extended coeffs for FM rate and Doppler centroid to be used for azimuth FM mismatch rate mitigation * Working version of azimuth FM rate mismatch mitigation * Update src/s1reader/s1_orbit.py Co-authored-by: Gustavo H. X. Shiroma <52007211+gshiroma@users.noreply.github.com> * Update src/s1reader/s1_orbit.py Co-authored-by: Gustavo H. X. Shiroma <52007211+gshiroma@users.noreply.github.com> * Update src/s1reader/s1_orbit.py Co-authored-by: Gustavo H. X. Shiroma <52007211+gshiroma@users.noreply.github.com> * Update src/s1reader/s1_orbit.py Co-authored-by: Gustavo H. X. Shiroma <52007211+gshiroma@users.noreply.github.com> * Update src/s1reader/s1_orbit.py Co-authored-by: Gustavo H. X. Shiroma <52007211+gshiroma@users.noreply.github.com> * Update src/s1reader/s1_orbit.py Co-authored-by: Gustavo H. X. Shiroma <52007211+gshiroma@users.noreply.github.com> * addressing comments from @gshiroma * trailing white spaces are removed * docstring updated * Code cleanup and docstrings * code cleanup * trailing white space removed * docsrting added; variable renaming for less verbosity; * code cleanup and simplification * variable name simplification * clde cleanup * Output as isce3.core.LUT2d * threshold and num_iter for rdr2geo * Addressing codacy issue * Trailing whitespace removed * codacy issue * docstring clarification on `BurstExtendedCoeffs` * whitespace removed * Update src/s1reader/s1_orbit.py Co-authored-by: vbrancat <virginia.brancato@jpl.nasa.gov> * Update src/s1reader/s1_orbit.py Co-authored-by: vbrancat <virginia.brancato@jpl.nasa.gov> * Update src/s1reader/s1_annotation.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * comment added for clarity * Update src/s1reader/s1_annotation.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_annotation.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_annotation.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * mod on the suggested commit to reuse the topo output filenames * fix on variable * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_annotation.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_burst_slc.py Co-authored-by: vbrancat <virginia.brancato@jpl.nasa.gov> * Update src/s1reader/s1_burst_slc.py Co-authored-by: vbrancat <virginia.brancato@jpl.nasa.gov> * typo fix * Update src/s1reader/s1_burst_slc.py Co-authored-by: vbrancat <virginia.brancato@jpl.nasa.gov> * Re-using the parsed polynomials; mitigation results as ISCE3 LUT2d * revision on import format * TODO removed * Option to turn on / off the functionalities for az fm rate mismatch mitigation * removing alias for `Rdr2Geo` * whitespace removed after resolving conflict * addressing codacy issue * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_annotation.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_annotation.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_reader.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * variable name changed * bug fixed; variable name updated * addressing codacy issues * codacy issue * variable name changed * pulling out functions that does not need to be methods * whitespace removed * updates after linting * Docstring for `_burst_from_safe_dir` revised * Docstring for `_burst_from_zip` revised * Docstring for `load_bursts` revised * Docstring for `burst_from_xml` revised * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * Docstring for `az_fm_rate_mismatch_mitigation` revised * Use temporary directory when `path_scratch` was not provided; take in az/rg steps as options to define radargrid * codacy issue * docstring updated; variable name changed * unnecessary members removed; docstring revised * temporary filename format changed * Update src/s1reader/s1_annotation.py Co-authored-by: Scott Staniewicz <scott.stanie@gmail.com> * Update src/s1reader/s1_annotation.py Co-authored-by: Scott Staniewicz <scott.stanie@gmail.com> * Update src/s1reader/s1_annotation.py Co-authored-by: Scott Staniewicz <scott.stanie@gmail.com> * Update src/s1reader/s1_annotation.py Co-authored-by: Scott Staniewicz <scott.stanie@gmail.com> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Scott Staniewicz <scott.stanie@gmail.com> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Scott Staniewicz <scott.stanie@gmail.com> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Scott Staniewicz <scott.stanie@gmail.com> * unit_degree -> in_degree * Update src/s1reader/s1_burst_slc.py Co-authored-by: Scott Staniewicz <scott.stanie@gmail.com> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Scott Staniewicz <scott.stanie@gmail.com> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Scott Staniewicz <scott.stanie@gmail.com> * Apply suggestions from code review Co-authored-by: Scott Staniewicz <scott.stanie@gmail.com> * variable name format revised * `mitigate_az_fmrate_mismatch` removed * PEP8 issues * add s1-etad prep module for testing S1-ETAD products (#73) + add s1_etad.py as a wrapper around the `s1etad` module from ESA to read / prepare ETA correction, given a `s1reader` burst object Co-authored-by: Seongsu Jeong <sjeong.kr@gmail.com> * bugfix in Sentinel1BurstSlc.swath_name() (#89) * s1_reader: fix safe_path for directories (#91) * s1_reader: fix safe_path for directories _burst_from_safe_dir used os.listdir, which does not have "measurement" in the returned names like the zip file list does this fixes #90 * return a string instead of list * Handle the case that the burst's sensing period exceeds the range of `polynomial_list` * azimith to azimuth spelling fix(#93) * Beta release compass (#94) * Replacing the loaders in Burst* class into class methods, with further implementation for thermal and EAP correction * fix on determining beta_naught; addressing PEP8 issues * Bug fix and feature addition to BurstEAP; restructuring LUT exportation * Readibility improvement; removing unnecessary imports * Format change on `burst_id`; keeping the absolute orbit number inside `Sentinel1BurstSlc` * updates on test_bursts.py * keeping the basename of the CADS and NADS for populating RTC metadata * Update src/s1reader/s1_annotation.py Readability improvement on equation Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_annotation.py Removing commented out code Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_annotation.py Reverting the docstring to be split into two lines for PEP8 compliance Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_annotation.py Improving docstring of the code copied from isce2 Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_burst_slc.py Removing the commented out codes Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_burst_slc.py improvement on code brevity Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_burst_slc.py renaming variable for better clarity Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_burst_slc.py renaming variable name for clarity Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_burst_slc.py variable name revised for clarity Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_burst_slc.py variable renamed for clarity Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_burst_slc.py improvement on docstring Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_burst_slc.py Readability improvement of equation Co-authored-by: Liang Yu <liangjyu@gmail.com> * addressing comments bt @LiangJYu * docstring fix; variables renamed for clarity * implemented s1_annotation.AucCal.load_from_zip_file() * readability improvement * s1_annotation.py - code cleanup; excention handling for AUX_CAL; PEP8 compliance * docstring for `s1_burst_slc.eap_compensation_lut()` * class import scheme changed * PEP8 compliance * initial structure of modification * less mod compared to the branch fork * extended coeffs for FM rate and Doppler centroid to be used for azimuth FM mismatch rate mitigation * Working version of azimuth FM rate mismatch mitigation * Update src/s1reader/s1_orbit.py Co-authored-by: Gustavo H. X. Shiroma <52007211+gshiroma@users.noreply.github.com> * Update src/s1reader/s1_orbit.py Co-authored-by: Gustavo H. X. Shiroma <52007211+gshiroma@users.noreply.github.com> * Update src/s1reader/s1_orbit.py Co-authored-by: Gustavo H. X. Shiroma <52007211+gshiroma@users.noreply.github.com> * Update src/s1reader/s1_orbit.py Co-authored-by: Gustavo H. X. Shiroma <52007211+gshiroma@users.noreply.github.com> * Update src/s1reader/s1_orbit.py Co-authored-by: Gustavo H. X. Shiroma <52007211+gshiroma@users.noreply.github.com> * Update src/s1reader/s1_orbit.py Co-authored-by: Gustavo H. X. Shiroma <52007211+gshiroma@users.noreply.github.com> * addressing comments from @gshiroma * trailing white spaces are removed * docstring updated * Code cleanup and docstrings * code cleanup * trailing white space removed * docsrting added; variable renaming for less verbosity; * code cleanup and simplification * variable name simplification * clde cleanup * Output as isce3.core.LUT2d * threshold and num_iter for rdr2geo * Addressing codacy issue * Trailing whitespace removed * codacy issue * docstring clarification on `BurstExtendedCoeffs` * whitespace removed * Update src/s1reader/s1_orbit.py Co-authored-by: vbrancat <virginia.brancato@jpl.nasa.gov> * Update src/s1reader/s1_orbit.py Co-authored-by: vbrancat <virginia.brancato@jpl.nasa.gov> * Update src/s1reader/s1_annotation.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * comment added for clarity * Update src/s1reader/s1_annotation.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_annotation.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_annotation.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * mod on the suggested commit to reuse the topo output filenames * fix on variable * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_annotation.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_burst_slc.py Co-authored-by: vbrancat <virginia.brancato@jpl.nasa.gov> * Update src/s1reader/s1_burst_slc.py Co-authored-by: vbrancat <virginia.brancato@jpl.nasa.gov> * typo fix * Update src/s1reader/s1_burst_slc.py Co-authored-by: vbrancat <virginia.brancato@jpl.nasa.gov> * Re-using the parsed polynomials; mitigation results as ISCE3 LUT2d * revision on import format * TODO removed * Option to turn on / off the functionalities for az fm rate mismatch mitigation * removing alias for `Rdr2Geo` * whitespace removed after resolving conflict * addressing codacy issue * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_annotation.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_annotation.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_reader.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * variable name changed * bug fixed; variable name updated * addressing codacy issues * codacy issue * variable name changed * pulling out functions that does not need to be methods * whitespace removed * updates after linting * Docstring for `_burst_from_safe_dir` revised * Docstring for `_burst_from_zip` revised * Docstring for `load_bursts` revised * Docstring for `burst_from_xml` revised * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * Docstring for `az_fm_rate_mismatch_mitigation` revised * Use temporary directory when `path_scratch` was not provided; take in az/rg steps as options to define radargrid * codacy issue * docstring updated; variable name changed * unnecessary members removed; docstring revised * temporary filename format changed * Update src/s1reader/s1_annotation.py Co-authored-by: Scott Staniewicz <scott.stanie@gmail.com> * Update src/s1reader/s1_annotation.py Co-authored-by: Scott Staniewicz <scott.stanie@gmail.com> * Update src/s1reader/s1_annotation.py Co-authored-by: Scott Staniewicz <scott.stanie@gmail.com> * Update src/s1reader/s1_annotation.py Co-authored-by: Scott Staniewicz <scott.stanie@gmail.com> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Scott Staniewicz <scott.stanie@gmail.com> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Scott Staniewicz <scott.stanie@gmail.com> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Scott Staniewicz <scott.stanie@gmail.com> * unit_degree -> in_degree * Update src/s1reader/s1_burst_slc.py Co-authored-by: Scott Staniewicz <scott.stanie@gmail.com> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Scott Staniewicz <scott.stanie@gmail.com> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Scott Staniewicz <scott.stanie@gmail.com> * Apply suggestions from code review Co-authored-by: Scott Staniewicz <scott.stanie@gmail.com> * variable name format revised * `mitigate_az_fmrate_mismatch` removed * PEP8 issues * Handle the case that the burst's sensing period exceeds the range of `polynomial_list` * version.py updated Co-authored-by: Seongsu Jeong <seongsu.jeong@jpl.nasa.gov> Co-authored-by: Liang Yu <liangjyu@gmail.com> Co-authored-by: Gustavo H. X. Shiroma <52007211+gshiroma@users.noreply.github.com> Co-authored-by: vbrancat <virginia.brancato@jpl.nasa.gov> Co-authored-by: Scott Staniewicz <scott.stanie@gmail.com> * add a --bbox option to s1_info for frame bounds (#88) * add a --bbox option to s1_info for frame bounds * add method to get bounds from the preview, if available * get preview kml bounds working * update usage for bbox and correct entry point * add __init__.py to utils subpackage * try loading any polarization for the bounds, accounting for hh/hv * reorder kml parsing logic * separate options in frame-bbox and burst-bbox * remove unused imports * two-layered calculation of az fm rate mismatch computation * removed trailing whtespaces * whitwspace removed * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * dicstring revised * fix on error string * whitespace removed * docstring revised --------- Co-authored-by: Seongsu Jeong <seongsu.jeong@jpl.nasa.gov> Co-authored-by: Liang Yu <liangjyu@gmail.com> Co-authored-by: Gustavo H. X. Shiroma <52007211+gshiroma@users.noreply.github.com> Co-authored-by: vbrancat <virginia.brancato@jpl.nasa.gov> Co-authored-by: Scott Staniewicz <scott.stanie@gmail.com> Co-authored-by: Zhang Yunjun <yunjunzgeo@gmail.com> commit 53f0c4373fac371e55d7baa09f95bcc0ea186fbd Author: Scott Staniewicz <scott.stanie@gmail.com> Date: Tue Feb 21 16:46:28 2023 -0500 allow az_step/rg_step arguments to `as_isce3_radargrid` (#102) * allow az_step/rg_step arguments to `as_isce3_radargrid` This allows a more coarse radar grid, as needed by some lookup tables such as the SET correction * Apply PRF suggestions from code review Co-authored-by: Heresh Fattahi <hersh.fattahi@gmail.com> * adjust length/width based on az_step/rg_step * fix the logic for width/length calculation with rg/az_step * reversed order of length/width * add two tests for as_isce3_radar_grid fixed the division to make the tests pass * add clarification to docstring about sensing start --------- Co-authored-by: Heresh Fattahi <hersh.fattahi@gmail.com> commit 2b43f2fb593658175e6e5a4bf8d3ee548c4770e9 Author: Scott Staniewicz <scott.stanie@gmail.com> Date: Mon Feb 13 14:56:58 2023 -0500 s1_orbit.py: if autodownloading, create the directory (#100) * s1_orbit.py: if autodownloading, create the directory There shouldnt be a need to have the user `mkdir -p orbits/` if they have already specified they do not have the orbits and want to download them. * add print to log directory creation commit 428328de5011968da91174cdf14db6eb3e8264c7 Author: Scott Staniewicz <scott.stanie@gmail.com> Date: Thu Dec 22 15:10:07 2022 -0500 add a --bbox option to s1_info for frame bounds (#88) * add a --bbox option to s1_info for frame bounds * add method to get bounds from the preview, if available * get preview kml bounds working * update usage for bbox and correct entry point * add __init__.py to utils subpackage * try loading any polarization for the bounds, accounting for hh/hv * reorder kml parsing logic * separate options in frame-bbox and burst-bbox * remove unused imports commit a29a422b60bc02341d85a1a78b42657d5bea5576 Author: Seongsu Jeong <sjeong.kr@gmail.com> Date: Wed Dec 21 14:14:04 2022 -0800 Beta release compass (#94) * Replacing the loaders in Burst* class into class methods, with further implementation for thermal and EAP correction * fix on determining beta_naught; addressing PEP8 issues * Bug fix and feature addition to BurstEAP; restructuring LUT exportation * Readibility improvement; removing unnecessary imports * Format change on `burst_id`; keeping the absolute orbit number inside `Sentinel1BurstSlc` * updates on test_bursts.py * keeping the basename of the CADS and NADS for populating RTC metadata * Update src/s1reader/s1_annotation.py Readability improvement on equation Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_annotation.py Removing commented out code Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_annotation.py Reverting the docstring to be split into two lines for PEP8 compliance Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_annotation.py Improving docstring of the code copied from isce2 Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_burst_slc.py Removing the commented out codes Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_burst_slc.py improvement on code brevity Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_burst_slc.py renaming variable for better clarity Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_burst_slc.py renaming variable name for clarity Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_burst_slc.py variable name revised for clarity Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_burst_slc.py variable renamed for clarity Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_burst_slc.py improvement on docstring Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_burst_slc.py Readability improvement of equation Co-authored-by: Liang Yu <liangjyu@gmail.com> * addressing comments bt @LiangJYu * docstring fix; variables renamed for clarity * implemented s1_annotation.AucCal.load_from_zip_file() * readability improvement * s1_annotation.py - code cleanup; excention handling for AUX_CAL; PEP8 compliance * docstring for `s1_burst_slc.eap_compensation_lut()` * class import scheme changed * PEP8 compliance * initial structure of modification * less mod compared to the branch fork * extended coeffs for FM rate and Doppler centroid to be used for azimuth FM mismatch rate mitigation * Working version of azimuth FM rate mismatch mitigation * Update src/s1reader/s1_orbit.py Co-authored-by: Gustavo H. X. Shiroma <52007211+gshiroma@users.noreply.github.com> * Update src/s1reader/s1_orbit.py Co-authored-by: Gustavo H. X. Shiroma <52007211+gshiroma@users.noreply.github.com> * Update src/s1reader/s1_orbit.py Co-authored-by: Gustavo H. X. Shiroma <52007211+gshiroma@users.noreply.github.com> * Update src/s1reader/s1_orbit.py Co-authored-by: Gustavo H. X. Shiroma <52007211+gshiroma@users.noreply.github.com> * Update src/s1reader/s1_orbit.py Co-authored-by: Gustavo H. X. Shiroma <52007211+gshiroma@users.noreply.github.com> * Update src/s1reader/s1_orbit.py Co-authored-by: Gustavo H. X. Shiroma <52007211+gshiroma@users.noreply.github.com> * addressing comments from @gshiroma * trailing white spaces are removed * docstring updated * Code cleanup and docstrings * code cleanup * trailing white space removed * docsrting added; variable renaming for less verbosity; * code cleanup and simplification * variable name simplification * clde cleanup * Output as isce3.core.LUT2d * threshold and num_iter for rdr2geo * Addressing codacy issue * Trailing whitespace removed * codacy issue * docstring clarification on `BurstExtendedCoeffs` * whitespace removed * Update src/s1reader/s1_orbit.py Co-authored-by: vbrancat <virginia.brancato@jpl.nasa.gov> * Update src/s1reader/s1_orbit.py Co-authored-by: vbrancat <virginia.brancato@jpl.nasa.gov> * Update src/s1reader/s1_annotation.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * comment added for clarity * Update src/s1reader/s1_annotation.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_annotation.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_annotation.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * mod on the suggested commit to reuse the topo output filenames * fix on variable * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_annotation.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_burst_slc.py Co-authored-by: vbrancat <virginia.brancato@jpl.nasa.gov> * Update src/s1reader/s1_burst_slc.py Co-authored-by: vbrancat <virginia.brancato@jpl.nasa.gov> * typo fix * Update src/s1reader/s1_burst_slc.py Co-authored-by: vbrancat <virginia.brancato@jpl.nasa.gov> * Re-using the parsed polynomials; mitigation results as ISCE3 LUT2d * revision on import format * TODO removed * Option to turn on / off the functionalities for az fm rate mismatch mitigation * removing alias for `Rdr2Geo` * whitespace removed after resolving conflict * addressing codacy issue * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_annotation.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_annotation.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_reader.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * variable name changed * bug fixed; variable name updated * addressing codacy issues * codacy issue * variable name changed * pulling out functions that does not need to be methods * whitespace removed * updates after linting * Docstring for `_burst_from_safe_dir` revised * Docstring for `_burst_from_zip` revised * Docstring for `load_bursts` revised * Docstring for `burst_from_xml` revised * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * Docstring for `az_fm_rate_mismatch_mitigation` revised * Use temporary directory when `path_scratch` was not provided; take in az/rg steps as options to define radargrid * codacy issue * docstring updated; variable name changed * unnecessary members removed; docstring revised * temporary filename format changed * Update src/s1reader/s1_annotation.py Co-authored-by: Scott Staniewicz <scott.stanie@gmail.com> * Update src/s1reader/s1_annotation.py Co-authored-by: Scott Staniewicz <scott.stanie@gmail.com> * Update src/s1reader/s1_annotation.py Co-authored-by: Scott Staniewicz <scott.stanie@gmail.com> * Update src/s1reader/s1_annotation.py Co-authored-by: Scott Staniewicz <scott.stanie@gmail.com> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Scott Staniewicz <scott.stanie@gmail.com> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Scott Staniewicz <scott.stanie@gmail.com> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Scott Staniewicz <scott.stanie@gmail.com> * unit_degree -> in_degree * Update src/s1reader/s1_burst_slc.py Co-authored-by: Scott Staniewicz <scott.stanie@gmail.com> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Scott Staniewicz <scott.stanie@gmail.com> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Scott Staniewicz <scott.stanie@gmail.com> * Apply suggestions from code review Co-authored-by: Scott Staniewicz <scott.stanie@gmail.com> * variable name format revised * `mitigate_az_fmrate_mismatch` removed * PEP8 issues * Handle the case that the burst's sensing period exceeds the range of `polynomial_list` * version.py updated Co-authored-by: Seongsu Jeong <seongsu.jeong@jpl.nasa.gov> Co-authored-by: Liang Yu <liangjyu@gmail.com> Co-authored-by: Gustavo H. X. Shiroma <52007211+gshiroma@users.noreply.github.com> Co-authored-by: vbrancat <virginia.brancato@jpl.nasa.gov> Co-authored-by: Scott Staniewicz <scott.stanie@gmail.com> commit 10fe381efec12fe4660da7edcc0bf14fbfd3982a Author: Liang Yu <liangjyu@gmail.com> Date: Tue Dec 20 16:31:55 2022 -0800 azimith to azimuth spelling fix(#93) commit eb5e53e8a530dd1e2bc4b9acc82f5a3932ec92cf Author: Seongsu Jeong <sjeong.kr@gmail.com> Date: Thu Dec 15 15:23:05 2022 -0800 FM rate mismatch - follow-up bug fix (#92) * Replacing the loaders in Burst* class into class methods, with further implementation for thermal and EAP correction * fix on determining beta_naught; addressing PEP8 issues * Bug fix and feature addition to BurstEAP; restructuring LUT exportation * Readibility improvement; removing unnecessary imports * Format change on `burst_id`; keeping the absolute orbit number inside `Sentinel1BurstSlc` * updates on test_bursts.py * keeping the basename of the CADS and NADS for populating RTC metadata * Update src/s1reader/s1_annotation.py Readability improvement on equation Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_annotation.py Removing commented out code Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_annotation.py Reverting the docstring to be split into two lines for PEP8 compliance Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_annotation.py Improving docstring of the code copied from isce2 Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_burst_slc.py Removing the commented out codes Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_burst_slc.py improvement on code brevity Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_burst_slc.py renaming variable for better clarity Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_burst_slc.py renaming variable name for clarity Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_burst_slc.py variable name revised for clarity Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_burst_slc.py variable renamed for clarity Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_burst_slc.py improvement on docstring Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_burst_slc.py Readability improvement of equation Co-authored-by: Liang Yu <liangjyu@gmail.com> * addressing comments bt @LiangJYu * docstring fix; variables renamed for clarity * implemented s1_annotation.AucCal.load_from_zip_file() * readability improvement * s1_annotation.py - code cleanup; excention handling for AUX_CAL; PEP8 compliance * docstring for `s1_burst_slc.eap_compensation_lut()` * class import scheme changed * PEP8 compliance * initial structure of modification * less mod compared to the branch fork * extended coeffs for FM rate and Doppler centroid to be used for azimuth FM mismatch rate mitigation * Working version of azimuth FM rate mismatch mitigation * Update src/s1reader/s1_orbit.py Co-authored-by: Gustavo H. X. Shiroma <52007211+gshiroma@users.noreply.github.com> * Update src/s1reader/s1_orbit.py Co-authored-by: Gustavo H. X. Shiroma <52007211+gshiroma@users.noreply.github.com> * Update src/s1reader/s1_orbit.py Co-authored-by: Gustavo H. X. Shiroma <52007211+gshiroma@users.noreply.github.com> * Update src/s1reader/s1_orbit.py Co-authored-by: Gustavo H. X. Shiroma <52007211+gshiroma@users.noreply.github.com> * Update src/s1reader/s1_orbit.py Co-authored-by: Gustavo H. X. Shiroma <52007211+gshiroma@users.noreply.github.com> * Update src/s1reader/s1_orbit.py Co-authored-by: Gustavo H. X. Shiroma <52007211+gshiroma@users.noreply.github.com> * addressing comments from @gshiroma * trailing white spaces are removed * docstring updated * Code cleanup and docstrings * code cleanup * trailing white space removed * docsrting added; variable renaming for less verbosity; * code cleanup and simplification * variable name simplification * clde cleanup * Output as isce3.core.LUT2d * threshold and num_iter for rdr2geo * Addressing codacy issue * Trailing whitespace removed * codacy issue * docstring clarification on `BurstExtendedCoeffs` * whitespace removed * Update src/s1reader/s1_orbit.py Co-authored-by: vbrancat <virginia.brancato@jpl.nasa.gov> * Update src/s1reader/s1_orbit.py Co-authored-by: vbrancat <virginia.brancato@jpl.nasa.gov> * Update src/s1reader/s1_annotation.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * comment added for clarity * Update src/s1reader/s1_annotation.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_annotation.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_annotation.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * mod on the suggested commit to reuse the topo output filenames * fix on variable * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_annotation.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_burst_slc.py Co-authored-by: vbrancat <virginia.brancato@jpl.nasa.gov> * Update src/s1reader/s1_burst_slc.py Co-authored-by: vbrancat <virginia.brancato@jpl.nasa.gov> * typo fix * Update src/s1reader/s1_burst_slc.py Co-authored-by: vbrancat <virginia.brancato@jpl.nasa.gov> * Re-using the parsed polynomials; mitigation results as ISCE3 LUT2d * revision on import format * TODO removed * Option to turn on / off the functionalities for az fm rate mismatch mitigation * removing alias for `Rdr2Geo` * whitespace removed after resolving conflict * addressing codacy issue * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_annotation.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_annotation.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_reader.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * variable name changed * bug fixed; variable name updated * addressing codacy issues * codacy issue * variable name changed * pulling out functions that does not need to be methods * whitespace removed * updates after linting * Docstring for `_burst_from_safe_dir` revised * Docstring for `_burst_from_zip` revised * Docstring for `load_bursts` revised * Docstring for `burst_from_xml` revised * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * Docstring for `az_fm_rate_mismatch_mitigation` revised * Use temporary directory when `path_scratch` was not provided; take in az/rg steps as options to define radargrid * codacy issue * docstring updated; variable name changed * unnecessary members removed; docstring revised * temporary filename format changed * Update src/s1reader/s1_annotation.py Co-authored-by: Scott Staniewicz <scott.stanie@gmail.com> * Update src/s1reader/s1_annotation.py Co-authored-by: Scott Staniewicz <scott.stanie@gmail.com> * Update src/s1reader/s1_annotation.py Co-authored-by: Scott Staniewicz <scott.stanie@gmail.com> * Update src/s1reader/s1_annotation.py Co-authored-by: Scott Staniewicz <scott.stanie@gmail.com> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Scott Staniewicz <scott.stanie@gmail.com> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Scott Staniewicz <scott.stanie@gmail.com> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Scott Staniewicz <scott.stanie@gmail.com> * unit_degree -> in_degree * Update src/s1reader/s1_burst_slc.py Co-authored-by: Scott Staniewicz <scott.stanie@gmail.com> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Scott Staniewicz <scott.stanie@gmail.com> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Scott Staniewicz <scott.stanie@gmail.com> * Apply suggestions from code review Co-authored-by: Scott Staniewicz <scott.stanie@gmail.com> * variable name format revised * `mitigate_az_fmrate_mismatch` removed * PEP8 issues * Handle the case that the burst's sensing period exceeds the range of `polynomial_list` Co-authored-by: Seongsu Jeong <seongsu.jeong@jpl.nasa.gov> Co-authored-by: Liang Yu <liangjyu@gmail.com> Co-authored-by: Gustavo H. X. Shiroma <52007211+gshiroma@users.noreply.github.com> Co-authored-by: vbrancat <virginia.brancato@jpl.nasa.gov> Co-authored-by: Scott Staniewicz <scott.stanie@gmail.com> commit e1cbc573c89df647f8c5831fcfa3c70b55c087cf Author: Seongsu Jeong <sjeong.kr@gmail.com> Date: Tue Dec 13 13:13:29 2022 -0800 Azimuth FM rate mismatch mitigation (#80) * Replacing the loaders in Burst* class into class methods, with further implementation for thermal and EAP correction * fix on determining beta_naught; addressing PEP8 issues * Bug fix and feature addition to BurstEAP; restructuring LUT exportation * Readibility improvement; removing unnecessary imports * Format change on `burst_id`; keeping the absolute orbit number inside `Sentinel1BurstSlc` * updates on test_bursts.py * keeping the basename of the CADS and NADS for populating RTC metadata * Update src/s1reader/s1_annotation.py Readability improvement on equation Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_annotation.py Removing commented out code Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_annotation.py Reverting the docstring to be split into two lines for PEP8 compliance Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_annotation.py Improving docstring of the code copied from isce2 Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_burst_slc.py Removing the commented out codes Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_burst_slc.py improvement on code brevity Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_burst_slc.py renaming variable for better clarity Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_burst_slc.py renaming variable name for clarity Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_burst_slc.py variable name revised for clarity Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_burst_slc.py variable renamed for clarity Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_burst_slc.py improvement on docstring Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_burst_slc.py Readability improvement of equation Co-authored-by: Liang Yu <liangjyu@gmail.com> * addressing comments bt @LiangJYu * docstring fix; variables renamed for clarity * implemented s1_annotation.AucCal.load_from_zip_file() * readability improvement * s1_annotation.py - code cleanup; excention handling for AUX_CAL; PEP8 compliance * docstring for `s1_burst_slc.eap_compensation_lut()` * class import scheme changed * PEP8 compliance * initial structure of modification * less mod compared to the branch fork * extended coeffs for FM rate and Doppler centroid to be used for azimuth FM mismatch rate mitigation * Working version of azimuth FM rate mismatch mitigation * Update src/s1reader/s1_orbit.py Co-authored-by: Gustavo H. X. Shiroma <52007211+gshiroma@users.noreply.github.com> * Update src/s1reader/s1_orbit.py Co-authored-by: Gustavo H. X. Shiroma <52007211+gshiroma@users.noreply.github.com> * Update src/s1reader/s1_orbit.py Co-authored-by: Gustavo H. X. Shiroma <52007211+gshiroma@users.noreply.github.com> * Update src/s1reader/s1_orbit.py Co-authored-by: Gustavo H. X. Shiroma <52007211+gshiroma@users.noreply.github.com> * Update src/s1reader/s1_orbit.py Co-authored-by: Gustavo H. X. Shiroma <52007211+gshiroma@users.noreply.github.com> * Update src/s1reader/s1_orbit.py Co-authored-by: Gustavo H. X. Shiroma <52007211+gshiroma@users.noreply.github.com> * addressing comments from @gshiroma * trailing white spaces are removed * docstring updated * Code cleanup and docstrings * code cleanup * trailing white space removed * docsrting added; variable renaming for less verbosity; * code cleanup and simplification * variable name simplification * clde cleanup * Output as isce3.core.LUT2d * threshold and num_iter for rdr2geo * Addressing codacy issue * Trailing whitespace removed * codacy issue * docstring clarification on `BurstExtendedCoeffs` * whitespace removed * Update src/s1reader/s1_orbit.py Co-authored-by: vbrancat <virginia.brancato@jpl.nasa.gov> * Update src/s1reader/s1_orbit.py Co-authored-by: vbrancat <virginia.brancato@jpl.nasa.gov> * Update src/s1reader/s1_annotation.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * comment added for clarity * Update src/s1reader/s1_annotation.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_annotation.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_annotation.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * mod on the suggested commit to reuse the topo output filenames * fix on variable * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_annotation.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_burst_slc.py Co-authored-by: vbrancat <virginia.brancato@jpl.nasa.gov> * Update src/s1reader/s1_burst_slc.py Co-authored-by: vbrancat <virginia.brancato@jpl.nasa.gov> * typo fix * Update src/s1reader/s1_burst_slc.py Co-authored-by: vbrancat <virginia.brancato@jpl.nasa.gov> * Re-using the parsed polynomials; mitigation results as ISCE3 LUT2d * revision on import format * TODO removed * Option to turn on / off the functionalities for az fm rate mismatch mitigation * removing alias for `Rdr2Geo` * whitespace removed after resolving conflict * addressing codacy issue * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_annotation.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_annotation.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_reader.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * variable name changed * bug fixed; variable name updated * addressing codacy issues * codacy issue * variable name changed * pulling out functions that does not need to be methods * whitespace removed * updates after linting * Docstring for `_burst_from_safe_dir` revised * Docstring for `_burst_from_zip` revised * Docstring for `load_bursts` revised * Docstring for `burst_from_xml` revised * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * Docstring for `az_fm_rate_mismatch_mitigation` revised * Use temporary directory when `path_scratch` was not provided; take in az/rg steps as options to define radargrid * codacy issue * docstring updated; variable name changed * unnecessary members removed; docstring revised * temporary filename format changed * Update src/s1reader/s1_annotation.py Co-authored-by: Scott Staniewicz <scott.stanie@gmail.com> * Update src/s1reader/s1_annotation.py Co-authored-by: Scott Staniewicz <scott.stanie@gmail.com> * Update src/s1reader/s1_annotation.py Co-authored-by: Scott Staniewicz <scott.stanie@gmail.com> * Update src/s1reader/s1_annotation.py Co-authored-by: Scott Staniewicz <scott.stanie@gmail.com> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Scott Staniewicz <scott.stanie@gmail.com> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Scott Staniewicz <scott.stanie@gmail.com> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Scott Staniewicz <scott.stanie@gmail.com> * unit_degree -> in_degree * Update src/s1reader/s1_burst_slc.py Co-authored-by: Scott Staniewicz <scott.stanie@gmail.com> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Scott Staniewicz <scott.stanie@gmail.com> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Scott Staniewicz <scott.stanie@gmail.com> * Apply suggestions from code review Co-authored-by: Scott Staniewicz <scott.stanie@gmail.com> * variable name format revised * `mitigate_az_fmrate_mismatch` removed * PEP8 issues Co-authored-by: Seongsu Jeong <seongsu.jeong@jpl.nasa.gov> Co-authored-by: Liang Yu <liangjyu@gmail.com> Co-authored-by: Gustavo H. X. Shiroma <52007211+gshiroma@users.noreply.github.com> Co-authored-by: vbrancat <virginia.brancato@jpl.nasa.gov> Co-authored-by: Scott Staniewicz <scott.stanie@gmail.com> commit ae88a1d56df19b8e1cd5f8be9bc73e195e256c31 Author: Scott Staniewicz <scott.stanie@gmail.com> Date: Wed Dec 7 11:35:15 2022 -0500 s1_reader: fix safe_path for directories (#91) * s1_reader: fix safe_path for directories _burst_from_safe_dir used os.listdir, which does not have "measurement" in the returned names like the zip file list does this fixes #90 * return a string instead of list commit a9c20a42f038e2f8b65ea7c1cf2f4719a1ce49c7 Author: Zhang Yunjun <yunjunzgeo@gmail.com> Date: Thu Dec 1 20:45:08 2022 -0800 bugfix in Sentinel1BurstSlc.swath_name() (#89) commit dfc028a2d6848c693c74aca95351c798cd4e6686 Author: Zhang Yunjun <yunjunzgeo@gmail.com> Date: Thu Dec 1 17:00:13 2022 -0800 add s1-etad prep module for testing S1-ETAD products (#73) + add s1_etad.py as a wrapper around the `s1etad` module from ESA to read / prepare ETA correction, given a `s1reader` burst object Co-authored-by: Seongsu Jeong <sjeong.kr@gmail.com>

allow az_step/rg_step arguments to as_isce3_radargrid

c495e1f

This allows a more coarse radar grid, as needed by some lookup tables such as the SET correction

scottstanie requested review from LiangJYu, seongsujeong and vbrancat February 19, 2023 21:19

scottstanie mentioned this pull request Feb 19, 2023

Solid Earth Tides correction opera-adt/COMPASS#91

Merged

vbrancat approved these changes Feb 21, 2023

View reviewed changes

hfattahi reviewed Feb 21, 2023

View reviewed changes

src/s1reader/s1_burst_slc.py Outdated Show resolved Hide resolved

LiangJYu reviewed Feb 21, 2023

View reviewed changes

src/s1reader/s1_burst_slc.py Show resolved Hide resolved

src/s1reader/s1_burst_slc.py Show resolved Hide resolved

scottstanie and others added 2 commits February 21, 2023 11:47

Apply PRF suggestions from code review

859bd48

Co-authored-by: Heresh Fattahi <hersh.fattahi@gmail.com>

adjust length/width based on az_step/rg_step

1fdc555

hfattahi reviewed Feb 21, 2023

View reviewed changes

scottstanie added 3 commits February 21, 2023 12:04

fix the logic for width/length calculation with rg/az_step

34f12c2

reversed order of length/width

bd33129

add two tests for as_isce3_radar_grid

5b366aa

fixed the division to make the tests pass

LiangJYu approved these changes Feb 21, 2023

View reviewed changes

hfattahi approved these changes Feb 21, 2023

View reviewed changes

add clarification to docstring about sensing start

269ade8

scottstanie merged commit 53f0c43 into isce-framework:main Feb 21, 2023

scottstanie deleted the rdr-grid-options branch February 21, 2023 21:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

allow az_step/rg_step arguments to `as_isce3_radargrid` #102

allow az_step/rg_step arguments to `as_isce3_radargrid` #102

scottstanie commented Feb 19, 2023

vbrancat left a comment

hfattahi Feb 21, 2023

hfattahi Feb 21, 2023

hfattahi Feb 21, 2023

hfattahi Feb 21, 2023

hfattahi commented Feb 21, 2023

LiangJYu left a comment

hfattahi commented Feb 21, 2023

scottstanie commented Feb 21, 2023

vbrancat commented Feb 21, 2023

hfattahi commented Feb 21, 2023 •

edited

Loading

vbrancat commented Feb 21, 2023

hfattahi commented Feb 21, 2023

hfattahi left a comment

	length_in_seconds = length / self.azimuth_time_interval
	length_in_seconds = length * self.azimuth_time_interval

	if 1 / az_step > length_in_seconds:
	if az_step > length_in_seconds:

	length = (length / self.azimuth_time_interval) // az_step
	length = (length * self.azimuth_time_interval) // az_step

	if rg_step > width * width_in_meters:
	if rg_step > width_in_meters:

allow az_step/rg_step arguments to as_isce3_radargrid #102

allow az_step/rg_step arguments to as_isce3_radargrid #102

Conversation

scottstanie commented Feb 19, 2023

vbrancat left a comment

Choose a reason for hiding this comment

hfattahi Feb 21, 2023

Choose a reason for hiding this comment

hfattahi Feb 21, 2023

Choose a reason for hiding this comment

hfattahi Feb 21, 2023

Choose a reason for hiding this comment

hfattahi Feb 21, 2023

Choose a reason for hiding this comment

hfattahi commented Feb 21, 2023

LiangJYu left a comment

Choose a reason for hiding this comment

hfattahi commented Feb 21, 2023

scottstanie commented Feb 21, 2023

vbrancat commented Feb 21, 2023

hfattahi commented Feb 21, 2023 • edited Loading

vbrancat commented Feb 21, 2023

hfattahi commented Feb 21, 2023

hfattahi left a comment

Choose a reason for hiding this comment

allow az_step/rg_step arguments to `as_isce3_radargrid` #102

allow az_step/rg_step arguments to `as_isce3_radargrid` #102

hfattahi commented Feb 21, 2023 •

edited

Loading