Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove cgi from _download_orbit_file #139

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

scottstanie
Copy link
Contributor

closes #135

The filename was already formed but not used, so we dont need the headers

New servies does not provide same header.

closes isce-framework#135

The filename was already formed but not used, so we dont need the headers

New servies does not provide same header.
Copy link
Contributor

@gshiroma gshiroma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you, @scottstanie !

Copy link
Contributor

@LiangJYu LiangJYu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scottstanie scottstanie merged commit 30c42c6 into isce-framework:main Jan 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DeprecationWarning: cgi is deprecated and slated for removal in Python 3.13
3 participants