Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

version: add version 0.1.2 Tag #63

Merged
merged 1 commit into from
Aug 16, 2022
Merged

version: add version 0.1.2 Tag #63

merged 1 commit into from
Aug 16, 2022

Conversation

yunjunz
Copy link
Member

@yunjunz yunjunz commented Aug 11, 2022 •
edited
Loading

  • version.py: add version 0.1.2 tag, to sync setup.py with the GitHub release.

LiangJYu
LiangJYu approved these changes Aug 12, 2022
View reviewed changes
Copy link
Contributor

@LiangJYu LiangJYu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

seongsujeong
seongsujeong approved these changes Aug 15, 2022
View reviewed changes
Copy link
Contributor

@seongsujeong seongsujeong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Maybe we should remove the tag v0.1.2 currently in place, and re-tag this version to the new v0.1.2?

@yunjunz
Copy link
Member Author

yunjunz commented Aug 16, 2022

Looks good to me. Maybe we should remove the tag v0.1.2 currently in place, and re-tag this version to the new v0.1.2?

This is just for info used in the setup.py with pip install. I think it's fine to not re-tag. The two (version.py and GitHub release) will be synced next time when we cut for our next release.

@yunjunz yunjunz merged commit a3f6aa2 into isce-framework:main Aug 16, 2022
@yunjunz yunjunz deleted the ver branch August 16, 2022 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seongsujeong seongsujeong seongsujeong approved these changes

@LiangJYu LiangJYu LiangJYu approved these changes

@vbrancat vbrancat Awaiting requested review from vbrancat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yunjunz @LiangJYu @seongsujeong