-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Burst id and absolute orbit number #64
Burst id and absolute orbit number #64
Conversation
Updating the main branch of this fork to update after `s1_annotation.py`
… `Sentinel1BurstSlc`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before approving, may I ask what are the use cases for these changes? |
Yes. The new format of burst_id will make the lengths of the string to be the same. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@seongsujeong Thank you for the expanded explanation.
The unit tests need to be fixed to account for these changes by:
@LiangJYu Thanks for pointing me to the unit test. I've updated
Hope this failure is not related to this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I don't think it's related. @rtburns-jpl to my untrained eye and shallow investigation, it looks like our CircleCI specfile needs to be updated to account for changes here? What do you think? Whatever the case, I'll open a new issue to continue discussion there. |
This PR updates the two things:
t051_
,t123_
Sentinel1BurstSlc
will keep the absolute orbit number as one of its attributes.