s1_orbit.get_orbit_file_from_dir(): add auto_download arg
#71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ automatically download the orbit file if not found + remove the unused get_orbit_file_from_list() + utils.plot_bursts.py: switch to get_orbit_file_from_dir()
scottstanie
approved these changes
Sep 27, 2022
| @@ -245,50 +267,23 @@ def get_orbit_file_from_list(zip_path: str, orbit_file_list: list[str]) -> str: | |||
| t_orbit_start = datetime.datetime.strptime(t_orbit_start[1:], FMT) | |||
|
|
|||
| # string '.EOF' from end of end time string | |||
| t_orbit_end = datetime.datetime.strptime(t_orbit_end[:-4], FMT) | |||
| t_orbit_stop = datetime.datetime.strptime(t_orbit_end[:-4], FMT) | |||
There was a problem hiding this comment.
Just checking- this name change was to make line 275 more logical (since the comment above there has "stop" instead of "end")?
I'm noticing now that this file alone has 26 instances of end_* and 11 instances of stop_*, and most other files have a combo of "stop" and "end". Not sure if we want to pick one and change the rest to match, but perhaps that can be another pull request after this.
There was a problem hiding this comment.
I prefer stop rather than end, because 1) "stopTime" is used in the S1 XML file, and 2) isce2 variable names, and 3) burst member variable here.
Replacing "end" with "stop" throughout s1reader sounds good to me. And yes, I think it's better to do that in another dedicated PR.
scottstanie
reviewed
Sep 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
s1_orbit.get_orbit_file_from_dir(): addauto_downloadarg to automatically download the orbit file if not found. The default is False.remove the unused get_orbit_file_from_list()
utils.plot_bursts.py: switch to get_orbit_file_from_dir()