Get orbit file #79
Merged
Get orbit file #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating the main branch of this fork to update after `s1_annotation.py`
…r implementation for thermal and EAP correction
… `Sentinel1BurstSlc`
Readability improvement on equation Co-authored-by: Liang Yu <liangjyu@gmail.com>
Removing commented out code Co-authored-by: Liang Yu <liangjyu@gmail.com>
Reverting the docstring to be split into two lines for PEP8 compliance Co-authored-by: Liang Yu <liangjyu@gmail.com>
Improving docstring of the code copied from isce2 Co-authored-by: Liang Yu <liangjyu@gmail.com>
Removing the commented out codes Co-authored-by: Liang Yu <liangjyu@gmail.com>
improvement on code brevity Co-authored-by: Liang Yu <liangjyu@gmail.com>
renaming variable for better clarity Co-authored-by: Liang Yu <liangjyu@gmail.com>
renaming variable name for clarity Co-authored-by: Liang Yu <liangjyu@gmail.com>
Bump isce3 to 0.8 and refresh CI specfile (isce-framework#66)
variable name revised for clarity Co-authored-by: Liang Yu <liangjyu@gmail.com>
variable renamed for clarity Co-authored-by: Liang Yu <liangjyu@gmail.com>
improvement on docstring Co-authored-by: Liang Yu <liangjyu@gmail.com>
Readability improvement of equation Co-authored-by: Liang Yu <liangjyu@gmail.com>
…s1-reader into correction_and_calibration
gshiroma
reviewed
Nov 11, 2022
Co-authored-by: Gustavo H. X. Shiroma <52007211+gshiroma@users.noreply.github.com>
Co-authored-by: Gustavo H. X. Shiroma <52007211+gshiroma@users.noreply.github.com>
Co-authored-by: Gustavo H. X. Shiroma <52007211+gshiroma@users.noreply.github.com>
Co-authored-by: Gustavo H. X. Shiroma <52007211+gshiroma@users.noreply.github.com>
Co-authored-by: Gustavo H. X. Shiroma <52007211+gshiroma@users.noreply.github.com>
Co-authored-by: Gustavo H. X. Shiroma <52007211+gshiroma@users.noreply.github.com>
yunjunz
approved these changes
Nov 14, 2022
There was a problem hiding this comment.
Thank you @seongsujeong. LGTM pending on the style issue flagged by Codacy.
gshiroma
approved these changes
Nov 15, 2022
There was a problem hiding this comment.
LGTM! Thank you, @seongsujeong , for working on this and for addressing all my comments!
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In context of the discussion in here, this PR will make the reader to take different formats of arguments for orbit.
Below are the highlights of the changes:
get_orbit_file_from_list()is revived. Most of the lines are originated from the originalget_orbit_file_from_dir()get_orbit_file_from_dir()is modified to get the list of orbit files in the directory provided. Internally, the list will be passed onget_orbit_file_from_list()to pick the orbit file that corresponds to SAFE file.get_orbit_file_from_dir()