RFI reader and miscellaneous metadata reader for CARD-NRB compliance #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating the main branch of this fork to update after `s1_annotation.py`
…r implementation for thermal and EAP correction
… `Sentinel1BurstSlc`
Readability improvement on equation Co-authored-by: Liang Yu <liangjyu@gmail.com>
Removing commented out code Co-authored-by: Liang Yu <liangjyu@gmail.com>
Reverting the docstring to be split into two lines for PEP8 compliance Co-authored-by: Liang Yu <liangjyu@gmail.com>
Improving docstring of the code copied from isce2 Co-authored-by: Liang Yu <liangjyu@gmail.com>
Removing the commented out codes Co-authored-by: Liang Yu <liangjyu@gmail.com>
improvement on code brevity Co-authored-by: Liang Yu <liangjyu@gmail.com>
renaming variable for better clarity Co-authored-by: Liang Yu <liangjyu@gmail.com>
renaming variable name for clarity Co-authored-by: Liang Yu <liangjyu@gmail.com>
Bump isce3 to 0.8 and refresh CI specfile (isce-framework#66)
variable name revised for clarity Co-authored-by: Liang Yu <liangjyu@gmail.com>
variable renamed for clarity Co-authored-by: Liang Yu <liangjyu@gmail.com>
improvement on docstring Co-authored-by: Liang Yu <liangjyu@gmail.com>
Readability improvement of equation Co-authored-by: Liang Yu <liangjyu@gmail.com>
…s1-reader into correction_and_calibration
seongsujeong
changed the title
seongsujeong
changed the title
gshiroma
reviewed
Mar 31, 2023
There was a problem hiding this comment.
Thank you so much for this updates, @seongsujeong . We talked offline, but I'll leave some of the comments we talked about here for reference.
vbrancat
reviewed
Apr 2, 2023
There was a problem hiding this comment.
Thank you @seongsujeong I only have minor comments on the code. Hopefully I can find some time to test the code.
| "numSubBlocks": int, | ||
| "subBlockSize": int, | ||
| "maxPercentageAffectedBW": float, | ||
| "percentageBlocksPersistentRfi": float, |
There was a problem hiding this comment.
Suggested change
| "percentageBlocksPersistentRfi": float, | |
| "percentageBlocksPersistentRFI": float, |
For consistency with Gustavo's comment.
There was a problem hiding this comment.
The keys in dict_datatype_rfi have to be in exact match with the field names in RFI annotation .xml files because the following function element_to_dict() make use of the dictionary to parse the XML.
|
@seongsujeong, any progress on this PR? |
Co-authored-by: Gustavo H. X. Shiroma <52007211+gshiroma@users.noreply.github.com>
gshiroma
reviewed
Apr 25, 2023
There was a problem hiding this comment.
Looks great, @seongsujeong . I have just a few minor comments below. I think we are close to merge it. Thanks!
gshiroma
reviewed
May 2, 2023
Co-authored-by: Gustavo H. X. Shiroma <52007211+gshiroma@users.noreply.github.com>
gshiroma
reviewed
May 2, 2023
gshiroma
approved these changes
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
s1-readeran ability to load Radio Frequency Interferences (RFI) information, which is available starting from IPF version 3.40.edit: 03/31/2023
This PR also includes the feature add to load miscellaneous metadata to populate the metadata of RTC-S1 to comply with CEOS Analysis Ready Data - Normalized Radar Backscatter (CARD-NRB)