Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preparation for merging tiles #13

Merged
merged 50 commits into from
Jun 17, 2024
Merged

Conversation

piyushrpt
Copy link
Member

@piyushrpt piyushrpt commented May 8, 2024

@piyushrpt piyushrpt marked this pull request as ready for review May 10, 2024 00:14
Copy link
Member

@gmgunter gmgunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. Looking good overall.

Detailed comments below. The main things are:

  1. There are a few places where the documentation could use some improvement
  2. The ability to avoid re-processing intermediate files that were previously generated is handy, but IMO it should be an option that users must opt into rather than being always enabled.

We could address the comments in a subsequent PR(s) if you want. Feel free to merge this one whenever you're ready since there's another open PR that depends on it.

src/spurt/links/_interface.py Show resolved Hide resolved
src/spurt/workflows/emcf/_cli.py Show resolved Hide resolved
src/spurt/workflows/emcf/_settings.py Show resolved Hide resolved
src/spurt/workflows/emcf/_settings.py Show resolved Hide resolved
src/spurt/workflows/emcf/_settings.py Show resolved Hide resolved
src/spurt/utils/merge.py Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
src/spurt/workflows/emcf/_output.py Show resolved Hide resolved
src/spurt/workflows/emcf/_output.py Show resolved Hide resolved
src/spurt/workflows/emcf/_output.py Show resolved Hide resolved
@piyushrpt piyushrpt merged commit d2e30d6 into isce-framework:main Jun 17, 2024
1 check passed
@piyushrpt piyushrpt deleted the feat/merge branch June 17, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants