-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preparation for merging tiles #13
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
piyushrpt
commented
May 8, 2024
•
edited
Loading
edited
- Consistency checks that pixels in overlapping tiles are only offset by integer cycles
- Bulk pairwise offset estimation similar to snaphu tiler
- Number of typing related fixes
- Dependent on Adding EMCF solver #10 and Add regular and density-based tilers + Link model grid search #11
- More to come
scottstanie
reviewed
May 21, 2024
gmgunter
approved these changes
Jun 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay. Looking good overall.
Detailed comments below. The main things are:
- There are a few places where the documentation could use some improvement
- The ability to avoid re-processing intermediate files that were previously generated is handy, but IMO it should be an option that users must opt into rather than being always enabled.
We could address the comments in a subsequent PR(s) if you want. Feel free to merge this one whenever you're ready since there's another open PR that depends on it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.