Fix out of order uw data from as_completed shuffling
#28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`as_completed` returns data out of order (possibly). This leads to random row shuffling of `uw_data`
gmgunter
reviewed
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had been still getting the
AssertionError: Arrays differ by non-integer cyclesproblem when trying to tile. I tracked this when I wrote out each spatial unwrapping result to a numpy array within the future, it perfectly matched the spurt CLI. But then the HDF5 saved data was different.The cause:
as_completedreturns data out of order (possibly). This leads to random row shuffling ofuw_data.Still not quite sure how doing the single worker didn't fix this when we checked earlier.
(Also: I missed adding separate options to the CLI in the last PR)