Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export emcf workflow interface #29

Merged
merged 3 commits into from
Jul 19, 2024
Merged

Export emcf workflow interface #29

merged 3 commits into from
Jul 19, 2024

Conversation

scottstanie
Copy link
Contributor

Allows dolphin to use the functions without calling private methods

@scottstanie @gmgunter
Update src/spurt/workflows/emcf/__init__.py
91e349c 
Co-authored-by: Geoffrey Gunter <12984092+gmgunter@users.noreply.github.com>
piyushrpt
piyushrpt approved these changes Jul 19, 2024
View reviewed changes
Copy link
Member

@piyushrpt piyushrpt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Looks like all changes are just in visibility of modules.

gmgunter
gmgunter approved these changes Jul 19, 2024
View reviewed changes
Copy link
Member

@gmgunter gmgunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scottstanie scottstanie merged commit 21720e6 into isce-framework:main Jul 19, 2024
1 check passed
@scottstanie scottstanie deleted the export-emcf-interface branch July 19, 2024 16:04
@scottstanie scottstanie mentioned this pull request Jul 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piyushrpt piyushrpt piyushrpt approved these changes

@gmgunter gmgunter gmgunter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scottstanie @piyushrpt @gmgunter