Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Starting to add documentation #36

Merged
merged 11 commits into from
Sep 9, 2024
Merged

Conversation

piyushrpt
Copy link
Member

  • Tutorials
  • References
  • Description of methodology

Copy link
Contributor

@scottstanie scottstanie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I pushed up the changes that I had to stumble into with dolphin to make the bibliography stuff work, while making it still PyPI compatible
  • The getting-started change i couldn't suggest since it was an old broken link i added

docs/tutorials/planar-graph.md Outdated Show resolved Hide resolved
piyushrpt and others added 3 commits August 21, 2024 11:30
@piyushrpt piyushrpt marked this pull request as ready for review August 23, 2024 17:49
@piyushrpt piyushrpt requested a review from scottstanie August 23, 2024 17:49
Copy link
Contributor

@scottstanie scottstanie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the example code snippets I tried worked, this looks like a nice start 👍

I also might make another PR with this notebook that I started to make to visualize the result from one temporal unwrapping step.

@piyushrpt piyushrpt merged commit dbb4217 into isce-framework:main Sep 9, 2024
1 check passed
@piyushrpt piyushrpt deleted the feat/docs branch September 9, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants