Skip to content

enhancement(create_metrics_refactor) #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 21, 2024
Merged

enhancement(create_metrics_refactor) #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e6249a6
common metrics function
ishaanagw Sep 21, 2024
25b600b
refactoring create metrics
ishaanagw Sep 21, 2024
67696ca
refactoring create_metrics
ishaanagw Sep 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 3 additions & 18 deletions ...entelemetry-instrumentation-anthropic/opentelemetry/instrumentation/anthropic/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
LLMRequestTypeValues,
SpanAttributes,
Meters,
MetricUtils,
)
from opentelemetry.trace import SpanKind, Tracer, get_tracer
from opentelemetry.trace.status import Status, StatusCode
Expand Down Expand Up @@ -372,24 +373,8 @@ def wrapper(wrapped, instance, args, kwargs):


def _create_metrics(meter: Meter):
token_histogram = meter.create_histogram(
name=Meters.LLM_TOKEN_USAGE,
unit="token",
description="Measures number of input and output tokens used",
)

choice_counter = meter.create_counter(
name=Meters.LLM_GENERATION_CHOICES,
unit="choice",
description="Number of choices returned by chat completions call",
)

duration_histogram = meter.create_histogram(
name=Meters.LLM_OPERATION_DURATION,
unit="s",
description="GenAI operation duration",
)

token_histogram, choice_counter, duration_histogram = MetricUtils.basic_metrics(meter)

exception_counter = meter.create_counter(
name=Meters.LLM_ANTHROPIC_COMPLETION_EXCEPTIONS,
unit="time",
Expand Down
20 changes: 2 additions & 18 deletions packages/opentelemetry-instrumentation-groq/opentelemetry/instrumentation/groq/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
LLMRequestTypeValues,
SpanAttributes,
Meters,
MetricUtils,
)
from opentelemetry.trace import SpanKind, Tracer, get_tracer
from opentelemetry.trace.status import Status, StatusCode
Expand Down Expand Up @@ -245,24 +246,7 @@ def wrapper(wrapped, instance, args, kwargs):


def _create_metrics(meter: Meter):
token_histogram = meter.create_histogram(
name=Meters.LLM_TOKEN_USAGE,
unit="token",
description="Measures number of input and output tokens used",
)

choice_counter = meter.create_counter(
name=Meters.LLM_GENERATION_CHOICES,
unit="choice",
description="Number of choices returned by chat completions call",
)

duration_histogram = meter.create_histogram(
name=Meters.LLM_OPERATION_DURATION,
unit="s",
description="GenAI operation duration",
)

token_histogram, choice_counter, duration_histogram = MetricUtils.basic_metrics(meter)
return token_histogram, choice_counter, duration_histogram


Expand Down
23 changes: 23 additions & 0 deletions packages/opentelemetry-semantic-conventions-ai/opentelemetry/semconv_ai/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,3 +236,26 @@ class TraceloopSpanKindValues(Enum):
AGENT = "agent"
TOOL = "tool"
UNKNOWN = "unknown"

class MetricUtils:

def basic_metrics(meter):
token_histogram = meter.create_histogram(
name=Meters.LLM_TOKEN_USAGE,
unit="token",
description="Measures number of input and output tokens used",
)

choice_counter = meter.create_counter(
name=Meters.LLM_GENERATION_CHOICES,
unit="choice",
description="Number of choices returned by chat completions call",
)

duration_histogram = meter.create_histogram(
name=Meters.LLM_OPERATION_DURATION,
unit="s",
description="GenAI operation duration",
)

return token_histogram, choice_counter, duration_histogram