Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor SCTPAddr.String #13

Closed
wants to merge 1 commit into from
Closed

refactor SCTPAddr.String #13

wants to merge 1 commit into from

Conversation

ishidawataru
Copy link
Owner

Signed-off-by: Akihiro Suda suda.akihiro@lab.ntt.co.jp

Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
@AkihiroSuda
Copy link
Contributor

Flaky test:

--- FAIL: TestSCTPCloseRecv (1.00s)
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
	panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x20 pc=0x479ddc]
goroutine 284 [running]:
panic(0x54c140, 0xc420016170)
	/home/travis/.gimme/versions/go1.7.linux.amd64/src/runtime/panic.go:500 +0x1a1
testing.tRunner.func1(0xc420534240)
	/home/travis/.gimme/versions/go1.7.linux.amd64/src/testing/testing.go:579 +0x25d
panic(0x54c140, 0xc420016170)
	/home/travis/.gimme/versions/go1.7.linux.amd64/src/runtime/panic.go:458 +0x243
github.com/ishidawataru/sctp.TestSCTPCloseRecv(0xc420534240)
	/home/travis/gopath/src/github.com/ishidawataru/sctp/sctp_test.go:153 +0x27c
testing.tRunner(0xc420534240, 0x588830)
	/home/travis/.gimme/versions/go1.7.linux.amd64/src/testing/testing.go:610 +0x81
created by testing.(*T).Run
	/home/travis/.gimme/versions/go1.7.linux.amd64/src/testing/testing.go:646 +0x2ec
FAIL	github.com/ishidawataru/sctp	1.594s
?   	github.com/ishidawataru/sctp/example	[no test files]

@ishidawataru How does it differ from #10 ?

@AkihiroSuda
Copy link
Contributor

addressed race in #14

@ishidawataru ishidawataru deleted the refactor-string branch February 13, 2018 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants