Skip to content

remove test#2

Closed
herczyn wants to merge 11 commits intoishymko:mainfrom
herczyn:main
Closed

remove test#2
herczyn wants to merge 11 commits intoishymko:mainfrom
herczyn:main

Conversation

@herczyn
Copy link

@herczyn herczyn commented Dec 17, 2025

Description

Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Follow the CONTRIBUTING Guide.
  • Make your Pull Request title in the https://www.conventionalcommits.org/ specification.
    • Important Prefixes for release-please:
      • fix: which represents bug fixes, and correlates to a SemVer patch.
      • feat: represents a new feature, and correlates to a SemVer minor.
      • feat!:, or fix!:, refactor!:, etc., which represent a breaking change (indicated by the !) and will result in a SemVer major.
  • Ensure the tests and linter pass
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@github-actions
Copy link

github-actions bot commented Dec 17, 2025

🧪 Code Coverage

⬇️ Download Full Report

Metric Main PR Delta
lines 81.57% 78.04% 🔴 -3.53%
statements 81.33% 77.85% 🔴 -3.48%
functions 87.18% 85.05% 🔴 -2.13%
branches 69.98% 67.32% 🔴 -2.66%

Generated by unit-tests.yml

ishymko added a commit to a2aproject/a2a-js that referenced this pull request Dec 17, 2025
# Description

Original approach from #262 isn't going to work for PRs from forks, as
such actions can't have write access to the upstream repo by default and
granting this access is not secure.

Following the approach with a dedicated
[`workflow_run`](https://docs.github.com/en/actions/reference/workflows-and-actions/events-that-trigger-workflows#workflow_run)
triggered workflow which is executed in a secure context.

Reference:
https://securitylab.github.com/resources/github-actions-preventing-pwn-requests/.

Tested in a fork: ishymko#2.

Re #192
@github-actions
Copy link

github-actions bot commented Dec 19, 2025

🧪 Code Coverage

⬇️ Download Full Report

Main PR Delta
src/client/transports/json_rpc_transport.ts 60.79% 48.29% 🔴 -12.50%
src/client/transports/rest_transport.ts 84.52% 70.23% 🔴 -14.29%
src/server/transports/jsonrpc/jsonrpc_transport_handler.ts 76.68% 65.64% 🔴 -11.04%
Total 82.31% 79.43% 🔴 -2.88%

Generated by coverage-comment.yml

@herczyn herczyn closed this by deleting the head repository Feb 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants