Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tutorial code snippets “out of sync” with example Python code #6077

Closed
3 tasks done
cwreynolds opened this issue Apr 12, 2023 · 3 comments · Fixed by #6128
Closed
3 tasks done

tutorial code snippets “out of sync” with example Python code #6077

cwreynolds opened this issue Apr 12, 2023 · 3 comments · Fixed by #6128
Labels
bug Not a build issue, this is likely a bug.

Comments

@cwreynolds
Copy link

Checklist

Describe the issue

There appears to be an “out of sync”(?) problem with code examples in the Customized visualization tutorial which may exist in other parts of the doc. The problem is in both the released and latest versions of the tutorial. The code box under Mimic draw_geometries() with Visualizer class shows:

37
38
39    def custom_draw_geometry_with_rotation(pcd):
40
41        def rotate_view(vis):
42            ctr = vis.get_view_control()
43            ctr.rotate(10.0, 0.0)
44            return False

Which appears to show a window (lines 37-44) into: customized_visualization.py in the master/latest source code. But in that Python file, this function (custom_draw_geometry_with_rotation()) actually spans lines 39-47. So a key bit of the function:

          o3d.visualization.draw_geometries_with_animation_callback([pcd],
                                                                    rotate_view)

is not shown in the tutorial.

Steps to reproduce the bug

doc

Error message

none

Expected behavior

No response

Open3D, Python and System information

- Operating system: macOS 12.6.4
- Python version: Python 3.10.10 (main, Mar 21 2023, 13:41:05) [Clang 14.0.6 ]
- Open3D version: Open3D 0.17.0
- System architecture: apple-silicon
- Is this a remote workstation?: no
- How did you install Open3D?: pip over a conda env
- Compiler version

Additional information

No response

@cwreynolds cwreynolds added the bug Not a build issue, this is likely a bug. label Apr 12, 2023
@dancergraham
Copy link
Contributor

Hello, I am working on this on my fork

dancergraham added a commit to dancergraham/Open3D that referenced this issue May 2, 2023
Fixes the start and end point of code snippets in the identified documentation
@cwreynolds
Copy link
Author

Thanks @dancergraham! I appreciate you looking into this.

I hope eventually to know enough about Open3D to submit my own pull requests. Right now I'm too much of a noob.

@dancergraham
Copy link
Contributor

Well you're definitely on the right track - your detailed issue notes made it fantastically easy for me to submit my first PR here on the repo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Not a build issue, this is likely a bug.
Projects
None yet
2 participants