-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deterministic registration #3737
Conversation
Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 8 of 8 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @gsakkis, @ssheorey, and @yxlao)
cpp/open3d/pipelines/registration/FastGlobalRegistration.h, line 73 at r1 (raw file):
double tuple_scale = 0.95, int maximum_tuple_count = 1000, unsigned int seed = std::random_device{}())
Also use utility::nullopt here for consistency?
cpp/tests/core/Tensor.cpp, line 1702 at r1 (raw file):
int64_t max_size = *std::max_element(sizes.begin(), sizes.end()); std::vector<int> vals(max_size); utility::UniformRandInt dist_gen(0, 3);
Potentially add a test in registration to verify that the results are deterministic?
10c0819
to
7d419fd
Compare
…istration behavior
…r allowing deterministic behavior
7d419fd
to
258d0d2
Compare
Addressed all comments, thanks for the review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 6 files at r2, 6 of 6 files at r3.
Reviewable status: all files reviewed, 6 unresolved discussions (waiting on @gsakkis and @ssheorey)
Hello, it seems that the seed is not exposed in python. Would it be possible to do so?
Thanks! |
This PR addresses #1263 for allowing deterministic registration:
seed
optional parameter toRegistrationRANSACBasedOnCorrespondence
andRegistrationRANSACBasedOnFeatureMatching
seed
member toFastGlobalRegistrationOption
UniformRandInt
function with a callable class that accepts an optional seed.This change is