Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build fixes MSVC and gcc #6039

Merged
merged 4 commits into from
Sep 7, 2023
Merged

Build fixes MSVC and gcc #6039

merged 4 commits into from
Sep 7, 2023

Conversation

ssheorey
Copy link
Member

@ssheorey ssheorey commented Mar 30, 2023 •
edited by germanros1987
Loading

Windows MSVC revert to fmt 6: Resolves #6006
gcc-12 maybe-uninitialized warning. Resolves: #6003
Set VTK minimum version Resolves #6037
[Incomplete] documentation for draw

This change is Reviewable

@update-docs
Copy link

update-docs bot commented Mar 30, 2023

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

@ssheorey ssheorey requested a review from errissa March 30, 2023 00:41
@ssheorey
Build fixes
127e48e 
Windows MSVC revert to fmt 6
gcc-12 maybe-uninitialized warning
set VTK compatible version
documentation for draw
errissa
errissa reviewed Mar 30, 2023
View reviewed changes
Copy link
Collaborator

@errissa errissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 10 of 10 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ssheorey)

@errissa
Copy link
Collaborator

errissa commented Mar 30, 2023

Yesterday we talked about disabling -Werror for Poisson reconstruction. Did that turn out not to be necessary? It looks like you updated the package instead.

@ssheorey
Copy link
Member Author

Yesterday we talked about disabling -Werror for Poisson reconstruction. Did that turn out not to be necessary? It looks like you updated the package instead.

We actually use a fork of the original Poisson reconstruction code and looks like we have updated the fork in the past to take care of compiler issues before. Here is the update to our fork:
isl-org/Open3D-PoissonRecon@90f3f06

@ssheorey ssheorey marked this pull request as ready for review March 31, 2023 02:01
@sitic sitic mentioned this pull request May 20, 2023
Open
3 tasks
saurabheights
saurabheights reviewed Sep 7, 2023
View reviewed changes
docs/tutorial/visualization/non_blocking_visualization.rst
:lineno-start: 59
:lines: 59-72
:lineno-start: 37
:lines: 37-49
Copy link
Contributor

@saurabheights saurabheights Sep 7, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ssheorey These changes in non_blocking_visualization.rst are taken care of here - https://github.com/isl-org/Open3D/pull/6321/files#diff-4d3bb3b76c894acd5303dbc1d2a0d919882866be425e1ce6279c4e59c0e951c0R28 (reminding just in case).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for checking! No worries, they will be updated when we merge #6321.

@ssheorey ssheorey merged commit 5b6ef4b into master Sep 7, 2023
39 checks passed
@ssheorey ssheorey deleted the ss/build-fixes branch September 7, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saurabheights saurabheights saurabheights left review comments

@errissa errissa errissa left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@ssheorey @errissa @saurabheights