-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the pybind reference bug of get_view_control() #6116
Conversation
Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes. |
this is a pretty nasty bug, is this repo dead? |
Any progress on this pull request? |
Thanks @eamonn-zh for this bug fix and to @Kemo-Huang @identxxy and others for investigating this. |
@ssheorey can this be released to pypi? |
Hi, this PR breaks the const correctness on the C++ side. Have you tried to explicit the lambda return type before removing the const overload? Something like: .def(
"get_view_control",
[](Visualizer &vis) -> &GetViewControl { return vis.GetViewControl(); },
"Function to retrieve the associated ``ViewControl``",
py::return_value_policy::reference_internal) |
The bug refixed of version 1.7.0 hasn't been released to pypi. I also countered this problem |
Type
Motivation and Context
Resolves the issue reported in #6009 that
Visualizer.get_view_control()
is expected to return a reference but it actually returns a copy, this problem does not exist in older versions of Open3D.Checklist:
python util/check_style.py --apply
to apply Open3D code styleto my code.
updated accordingly.
results (e.g. screenshots or numbers) here.
Description
Updated the pybind code and fixed the reference issue.
This change is