Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rendering of Python versions table in docs #6162

Merged
merged 1 commit into from
Aug 29, 2023
Merged

Fix rendering of Python versions table in docs #6162

merged 1 commit into from
Aug 29, 2023

Conversation

johnthagen
Copy link
Contributor

@johnthagen johnthagen commented May 21, 2023

Type

  • Bug fix (non-breaking change which fixes an issue): Fixes #
  • New feature (non-breaking change which adds functionality). Resolves #
  • Breaking change (fix or feature that would cause existing functionality to not work as expected) Resolves #

Motivation and Context

The Getting Started page currently has a list (supported Python versions) that is not rendered properly.

Screenshot 2023-05-21 125525

Checklist:

  • I have run python util/check_style.py --apply to apply Open3D code style
    to my code.
  • This PR changes Open3D behavior or adds new functionality.
    • Both C++ (Doxygen) and Python (Sphinx / Google style) documentation is
      updated accordingly.
    • I have added or updated C++ and / or Python unit tests OR included test
      results
      (e.g. screenshots or numbers) here.
  • I will follow up and update the code if CI fails.
  • For fork PRs, I have selected Allow edits from maintainers.

Description


This change is Reviewable

@update-docs
Copy link

update-docs bot commented May 21, 2023

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

@johnthagen johnthagen changed the title Fix rendering of Python versions table Fix rendering of Python versions table in docs May 21, 2023
@johnthagen
Copy link
Contributor Author

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

I presume this change does not need a changelog entry, but if it does, please let me know.

Copy link
Collaborator

@reyanshsolis reyanshsolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Don't worry about CHANGELOGS.

@reyanshsolis
Copy link
Collaborator

@ssheorey I am not able to re-trigger test. Can you please try from your end ?

@ssheorey
Copy link
Member

@ssheorey I am not able to re-trigger test. Can you please try from your end ?

You can re-trigger test by either of:

  • adding a new commit (e.g. merging master locally and pushing the update).
  • closing and re-opening the PR.

@johnthagen johnthagen closed this Aug 28, 2023
@johnthagen johnthagen reopened this Aug 28, 2023
@ssheorey ssheorey merged commit 0f12276 into isl-org:master Aug 29, 2023
@johnthagen johnthagen deleted the patch-1 branch August 29, 2023 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants