Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed was-open check for ComboBox to fix freeze on macOS #6178

Merged
merged 2 commits into from
Oct 6, 2023

Conversation

cansik
Copy link
Contributor

@cansik cansik commented May 26, 2023

As already described in #6024, on macOS the combobox was freezing when it was opened.

Motivation and Context

At the moment it is not possible to select an item from a Combobox on macOS. This does not work in the Open3D App and also any other app using the Open3D GUI library.

227155722-ac4fb21b-a27c-4a2d-9bc7-db5d102be7ad

Checklist:

  • I have run python util/check_style.py --apply to apply Open3D code style
    to my code.
  • This PR changes Open3D behavior or adds new functionality.
    • Both C++ (Doxygen) and Python (Sphinx / Google style) documentation is
      updated accordingly.
    • I have added or updated C++ and / or Python unit tests OR included test
      results
      (e.g. screenshots or numbers) here.
  • I will follow up and update the code if CI fails.
  • For fork PRs, I have selected Allow edits from maintainers.

Description

It seems that the problem is the following: On macOS the ImGUI method ImGui::IsPopupOpen always returns false and so does leads to a return of of Widget::DrawResult::REDRAW which causes the GUI to redraw itself, which will go on for ever.

To be honest, I am not quite sure why this check is done, maybe to change to combobox content if it has been changed while the user has the dropdown open (@errissa)?

Since it worked in version 0.15.0 I first thought it is an ImGUI problem, but the ImGUI version did not change from 0.15.0 to 0.16.0. And even with a more recent version (v1.88) it does not work. Because this bug has a big impact to any GUI (you can not even fully use the open3d app on macOS), I decided to fix it directly in Open3d. Maybe it makes sense to open an issue at ImGUI so that it will be fixed in a future release.

To fix the issue in Open3D, I have removed this check and simplified to redrawing to just redraw, when the selection has changed.


This change is Reviewable

@update-docs
Copy link

update-docs bot commented May 26, 2023

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

@cansik cansik changed the title Removed was-open check for combobox to support macOS Removed was-open check for ComboBox to fix freeze on macOS May 26, 2023
@ssheorey ssheorey requested a review from errissa June 1, 2023 17:39
@cansik cansik mentioned this pull request Aug 7, 2023
4 tasks
Copy link
Collaborator

@errissa errissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @cansik)

@ssheorey
Copy link
Member

ssheorey commented Oct 6, 2023

Thanks @cansik !

@ssheorey ssheorey merged commit 6cd52c8 into isl-org:master Oct 6, 2023
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Combobox widget freezes when changing selections under MacOS
3 participants