Fixes #6291 and #6236 #6305
Fixes #6291 and #6236 #6305
Conversation
|
Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes. |
| @@ -64,23 +64,24 @@ class RANSACResult { | |||
| }; | |||
|
|
|||
| // Calculates the number of inliers given a list of points and a plane model, | |||
| // and the total distance between the inliers and the plane. These numbers are | |||
| // then used to evaluate how well the plane model fits the given points. | |||
| // and the total squared point-to-plane distance. | |||
There was a problem hiding this comment.
Shouldn't the total squared point-to-plane distance be root mean squared point-to-plane distance? Not a major issue though.
There was a problem hiding this comment.
LOL, 1 minute late :D .
There was a problem hiding this comment.
Let me know and I can push this change when making other documentation PRs. This anyways is not getting rendered to C++ docs, so probably needs more work to make it doxygen compatible - http://www.open3d.org/docs/release/cpp_api/namespaceopen3d_1_1geometry.html#a5013df32089b6fb7222d04535759b7d4
There was a problem hiding this comment.
PS: The comments in .cpp files are for code authors (how does it work?) and comments in header files (Doxygen compatible) are for API users (what does it do, inputs and output).
Type
Motivation and Context
Checklist:
python util/check_style.py --applyto apply Open3D code styleto my code.
updated accordingly.
results (e.g. screenshots or numbers) here.
Description
Fixes #6291 and #6236
This change is