Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix in RGBD based reconstruction system example #6660

Merged
merged 3 commits into from
Mar 18, 2024

Conversation

bell-one
Copy link
Contributor

@bell-one bell-one commented Feb 19, 2024

Type Bug fix in RGBD based reconstruction system example

  • Bug fix (non-breaking change which fixes an issue): Fixes #
  • New feature (non-breaking change which adds functionality). Resolves #
  • Breaking change (fix or feature that would cause existing functionality to not work as expected) Resolves #

Motivation and Context

There is currently a malfunction in 'run_system.py' and 'color_map_optimization_for_reconstruction_system.py' for RGBD-based reconstruction.

Changes to the open3d.io.write_point_cloud input variable were not aplied in make_fragments.py used in run_system.py.

And, in 'color_map_optimization_for_reconstruction_system.py', initialize_config is not referenced.

Checklist:

  • I have run python util/check_style.py --apply to apply Open3D code style
    to my code.
  • This PR changes Open3D behavior or adds new functionality.
    • Both C++ (Doxygen) and Python (Sphinx / Google style) documentation is
      updated accordingly.
    • I have added or updated C++ and / or Python unit tests OR included test
      results
      (e.g. screenshots or numbers) here.
  • I will follow up and update the code if CI fails.
  • For fork PRs, I have selected Allow edits from maintainers.

Description

update 'write_point_cloud' variables
link 'initialize_config' function in color_map_optimization
Copy link

update-docs bot commented Feb 19, 2024

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

Copy link
Member

@ssheorey ssheorey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bell-one

@ssheorey ssheorey merged commit fa91f2e into isl-org:main Mar 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants