feat(dss): Logging to json for compact single-line logs #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsanchezb
reviewed
Jan 11, 2024
pom.xml
Outdated
| @@ -47,6 +47,8 @@ | |||
|
|
|||
| <slf4j.version>2.0.7</slf4j.version> | |||
| <logback-classic.version>1.3.7</logback-classic.version> <!-- Version 1.4+ supports only Java 11+ --> | |||
| <groupId>net.logstash.logback</groupId> | |||
There was a problem hiding this comment.
No need to define <groupId> in here
bsanchezb
reviewed
Jan 11, 2024
| <encoder class="net.logstash.logback.encoder.LogstashEncoder"> | ||
| <prefix class="ch.qos.logback.core.encoder.LayoutWrappingEncoder"> | ||
| <layout class="ch.qos.logback.classic.PatternLayout"> | ||
| <pattern>${DD_API_KEY} %mdc{keyThatDoesNotExist}</pattern> |
There was a problem hiding this comment.
I'm confused about the pattern here. Why to print keys?
bsanchezb
added a commit
to bsanchezb/digital-signature-service
that referenced
this pull request
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.