fix: coderabbit suggestions

island-is · Nov 12, 2024 · 1c0d8af · 1c0d8af
1 parent 2cb7f41
commit 1c0d8af
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 9 deletions.
diff --git a/libs/api/domains/vehicles/src/lib/services/bulkMileage.service.ts b/libs/api/domains/vehicles/src/lib/services/bulkMileage.service.ts
@@ -159,9 +159,9 @@ export class BulkMileageService {
               return {
                 code: e.errorCode ?? undefined,
                 message: e.errorText ?? undefined,
-                warningSerialCode: e.warningSerial ?? 0,
+                warningSerialCode: e.warningSerial,
                 warningText: warningSerial
-                  ? formatMessage(errorCodeMessageMap[warningSerial ?? 0])
+                  ? formatMessage(errorCodeMessageMap[warningSerial])
                   : undefined,
               }
             }),

diff --git a/libs/api/domains/vehicles/src/lib/services/vehicles.service.ts b/libs/api/domains/vehicles/src/lib/services/vehicles.service.ts
@@ -469,7 +469,7 @@ export class VehiclesService {
       putMileageReadingModel: input,
     })
 
-    return dtos[0]
+    return dtos.length > 0 ? dtos[0] : null
   }
 
   async postMileageReadingV2(
@@ -537,7 +537,7 @@ export class VehiclesService {
       const dtos = await this.getMileageWithAuth(auth).rootPut({
         putMileageReadingModel: input,
       })
-      return dtos[0]
+      return dtos.length > 0 ? dtos[0] : null
     } catch (e) {
       if (e instanceof FetchError && (e.status === 400 || e.status === 429)) {
         const errorBody = e.body as UpdateResponseError

diff --git a/libs/service-portal/assets/src/screens/VehicleBulkMileage/VehicleBulkMileage.tsx b/libs/service-portal/assets/src/screens/VehicleBulkMileage/VehicleBulkMileage.tsx
@@ -3,7 +3,6 @@ import { useLocale, useNamespaces } from '@island.is/localization'
 import {
   m,
   SAMGONGUSTOFA_SLUG,
-  IntroHeader,
   LinkButton,
   IntroWrapper,
 } from '@island.is/service-portal/core'

diff --git a/libs/service-portal/assets/src/screens/VehicleBulkMileageUpload/VehicleBulkMileageUpload.tsx b/libs/service-portal/assets/src/screens/VehicleBulkMileageUpload/VehicleBulkMileageUpload.tsx
@@ -73,10 +73,6 @@ const VehicleBulkMileageUpload = () => {
       setUploadErrorMessage(formatMessage(vehicleMessage.noDataInUploadedFile))
       return
     }
-    if (typeof records === 'string') {
-      setUploadErrorMessage(records)
-      return
-    }
     vehicleBulkMileagePostMutation({
       variables: {
         input: {