fix(application-estate): Show error if missing heir in undivided esta…

…te (#16560) * Show error if missing heir in undivided estate * thanks rabbit * minor refactor * moar refactor * the rabbit hole --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
island-is · Oct 25, 2024 · 4f5bc17 · 4f5bc17
1 parent 97b8a92
commit 4f5bc17
Show file tree

Hide file tree

Showing 3 changed files with 35 additions and 2 deletions.
diff --git a/libs/application/templates/estate/src/fields/EstateMembersRepeater/index.tsx b/libs/application/templates/estate/src/fields/EstateMembersRepeater/index.tsx
@@ -27,6 +27,7 @@ import {
   NO,
   YES,
   heirAgeValidation,
+  missingHeirUndividedEstateValidation,
   relationWithApplicant,
 } from '../../lib/constants'
 import intervalToDuration from 'date-fns/intervalToDuration'
@@ -74,6 +75,12 @@ export const EstateMembersRepeater: FC<
     },
   )
 
+  const missingHeirsForUndividedEstate =
+    selectedEstate === EstateTypes.permitForUndividedEstate &&
+    !values.estate?.estateMembers?.some(
+      (member: EstateMember) => member.enabled,
+    )
+
   setBeforeSubmitCallback &&
     setBeforeSubmitCallback(async () => {
       if (
@@ -96,6 +103,13 @@ export const EstateMembersRepeater: FC<
         return [false, 'invalid member age']
       }
 
+      if (missingHeirsForUndividedEstate) {
+        setError(missingHeirUndividedEstateValidation, {
+          type: 'custom',
+        })
+        return [false, 'missing heir for undivided estate']
+      }
+
       return [true, null]
     })
 
@@ -136,11 +150,15 @@ export const EstateMembersRepeater: FC<
     if (!hasEstateMemberUnder18withoutRep) {
       clearErrors(heirAgeValidation)
     }
+    if (!missingHeirsForUndividedEstate) {
+      clearErrors(missingHeirUndividedEstateValidation)
+    }
   }, [
     fields,
     hasEstateMemberUnder18withoutRep,
     hasEstateMemberUnder18,
     clearErrors,
+    missingHeirsForUndividedEstate,
   ])
 
   useEffect(() => {
@@ -418,7 +436,7 @@ export const EstateMembersRepeater: FC<
           {formatMessage(m.inheritanceAddMember)}
         </Button>
       </Box>
-      {errors && errors[heirAgeValidation] ? (
+      {!!errors?.[heirAgeValidation] && (
         <Box marginTop={4}>
           <InputError
             errorMessage={
@@ -428,7 +446,14 @@ export const EstateMembersRepeater: FC<
             }
           />
         </Box>
-      ) : null}
+      )}
+      {!!errors?.[missingHeirUndividedEstateValidation] && (
+        <Box marginTop={4}>
+          <InputError
+            errorMessage={formatMessage(m.missingHeirUndividedEstateValidation)}
+          />
+        </Box>
+      )}
     </Box>
   )
 }

diff --git a/libs/application/templates/estate/src/lib/constants.ts b/libs/application/templates/estate/src/lib/constants.ts
@@ -49,3 +49,5 @@ export const relationWithApplicant = [
 ]
 
 export const heirAgeValidation = 'heirAgeValidation'
+export const missingHeirUndividedEstateValidation =
+  'missingHeirUndividedEstateValidation'
diff --git a/libs/application/templates/estate/src/lib/messages.ts b/libs/application/templates/estate/src/lib/messages.ts
@@ -1140,6 +1140,12 @@ export const m = defineMessages({
       'Ekki er hægt að halda áfram með umsókn þar sem aðili undir 18 er skráður án málssvara yfir lögaldri',
     description: '',
   },
+  missingHeirUndividedEstateValidation: {
+    id: 'es.application:missingHeirUndividedEstateValidation',
+    defaultMessage:
+      'Ekki er hægt að halda áfram með umsókn þar sem engin erfingi er skráður',
+    description: '',
+  },
 
   // Properties
   realEstatesDescription: {