fix(j-s): Prison admin indictment notifications (#17097)

* fix(j-s): Prison admin indictment notifications

Notifications weren't getting sent due to a bug in the defendant model that returned an undefined value for defendant.caseId

* Update defendant.service.ts

---------

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

apps/judicial-system/backend/src/app/modules/defendant/defendant.service.ts

@@ -76,6 +76,7 @@ export class DefendantService {
 
   private getMessagesForIndictmentToPrisonAdminChanges(
     defendant: Defendant,
+    caseId: string,
   ): Message {
     const messageType =
       defendant.isSentToPrisonAdmin === true
@@ -84,7 +85,7 @@ export class DefendantService {
 
     const message = {
       type: MessageType.DEFENDANT_NOTIFICATION,
-      caseId: defendant.caseId,
+      caseId,
       elementId: defendant.id,
       body: {
         type: messageType,
@@ -196,7 +197,10 @@ export class DefendantService {
       updatedDefendant.isSentToPrisonAdmin !== oldDefendant.isSentToPrisonAdmin
     ) {
       messages.push(
-        this.getMessagesForIndictmentToPrisonAdminChanges(updatedDefendant),
+        this.getMessagesForIndictmentToPrisonAdminChanges(
+          updatedDefendant,
+          theCase.id,
+        ),
       )
     }
 

apps/judicial-system/backend/src/app/modules/defendant/models/defendant.model.ts

@@ -81,7 +81,7 @@ export class Defendant extends Model {
   @ApiProperty({ type: String })
   caseId!: string
 
-  @BelongsTo(() => Case, 'case_id')
+  @BelongsTo(() => Case, 'caseId')
   @ApiPropertyOptional({ type: () => Case })
   case?: Case