Fixes after self review

island-is · Nov 14, 2024 · ce95573 · ce95573
1 parent bc3c8c1
commit ce95573
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 10 deletions.
diff --git a/apps/services/bff/src/app/modules/auth/auth.service.ts b/apps/services/bff/src/app/modules/auth/auth.service.ts
@@ -9,7 +9,7 @@ import {
   UnauthorizedException,
 } from '@nestjs/common'
 import { ConfigType } from '@nestjs/config'
-import { Request, Response } from 'express'
+import type { Request, Response } from 'express'
 import jwksClient from 'jwks-rsa'
 import { jwtDecode } from 'jwt-decode'
 

diff --git a/apps/services/bff/src/app/modules/user/user.service.ts b/apps/services/bff/src/app/modules/user/user.service.ts
@@ -3,7 +3,6 @@ import type { Request, Response } from 'express'
 
 import { BffUser } from '@island.is/shared/types'
 import { SESSION_COOKIE_NAME } from '../../constants/cookies'
-import { CryptoService } from '../../services/crypto.service'
 
 import { ErrorService } from '../../services/error.service'
 import { hasTimestampExpiredInMS } from '../../utils/has-timestamp-expired-in-ms'
@@ -29,13 +28,6 @@ export class UserService {
     }
   }
 
-  /**
-   * Creates a key for storing token response data in cache
-   */
-  private createTokenResponseKey(sid: string): string {
-    return this.cacheService.createSessionKeyType('current', sid)
-  }
-
   /**
    * Gets the current user data, refreshing the token if needed
    */
@@ -54,7 +46,10 @@ export class UserService {
       throw new UnauthorizedException()
     }
 
-    const tokenResponseKey = this.createTokenResponseKey(sid)
+    const tokenResponseKey = this.cacheService.createSessionKeyType(
+      'current',
+      sid,
+    )
     const cachedTokenResponse =
       await this.cacheService.get<CachedTokenResponse>(
         tokenResponseKey,