Skip to content

Commit

Permalink
fix(services-bff): Disable PAR until ids resolves error (#17176)
Browse files Browse the repository at this point in the history
* fix(services-bff): Disable PAR until ids resolves error

* fix tests

* chore: charts update dirty files

---------

Co-authored-by: andes-it <builders@andes.is>
  • Loading branch information
snaerth and andes-it authored Dec 9, 2024
1 parent f6eea1c commit e87eb22
Show file tree
Hide file tree
Showing 12 changed files with 15 additions and 15 deletions.
4 changes: 2 additions & 2 deletions charts/islandis/values.dev.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2313,7 +2313,7 @@ services-bff-portals-admin:
BFF_LOGIN_ATTEMPT_TTL_MS: '604800000'
BFF_LOGOUT_REDIRECT_URI: 'https://beta.dev01.devland.is'
BFF_NAME: 'stjornbord'
BFF_PAR_SUPPORT_ENABLED: 'true'
BFF_PAR_SUPPORT_ENABLED: 'false'
BFF_PROXY_API_ENDPOINT: 'http://web-api.islandis.svc.cluster.local/api/graphql'
CODE_OWNER: 'core'
IDENTITY_SERVER_CLIENT_ID: '@admin.island.is/bff-stjornbord'
Expand Down Expand Up @@ -2400,7 +2400,7 @@ services-bff-portals-my-pages:
BFF_LOGIN_ATTEMPT_TTL_MS: '604800000'
BFF_LOGOUT_REDIRECT_URI: 'https://beta.dev01.devland.is'
BFF_NAME: 'minarsidur'
BFF_PAR_SUPPORT_ENABLED: 'true'
BFF_PAR_SUPPORT_ENABLED: 'false'
BFF_PROXY_API_ENDPOINT: 'http://web-api.islandis.svc.cluster.local/api/graphql'
IDENTITY_SERVER_CLIENT_ID: '@island.is/web'
IDENTITY_SERVER_CLIENT_SCOPES: '["api_resource.scope","@island.is/applications:read","@island.is/applications:write","@island.is/user-profile:read","@island.is/user-profile:write","@island.is/auth/actor-delegations","@island.is/auth/delegations:write","@island.is/auth/consents","@skra.is/individuals","@island.is/documents","@island.is/endorsements","@admin.island.is/petitions","@island.is/assets/ip","@island.is/assets","@island.is/education","@island.is/education-license","@island.is/finance:overview","@island.is/finance/salary","@island.is/finance/schedule:read","@island.is/finance/loans","@island.is/internal","@island.is/internal:procuring","@island.is/me:details","@island.is/law-and-order","@island.is/licenses","@island.is/licenses:verify","@island.is/company","@island.is/vehicles","@island.is/work-machines","@island.is/health/payments","@island.is/health/medicines","@island.is/health/assistive-devices-and-nutrition","@island.is/health/therapies","@island.is/health/healthcare","@island.is/health/rights-status","@island.is/health/dentists","@island.is/health/organ-donation","@island.is/health/vaccinations","@island.is/signature-collection","@island.is/applications/urvinnslusjodur","@island.is/applications/orkusjodur","@island.is/fishing-license","@island.is/applications/samgongustofa-vehicles","@island.is/applications/ver","@samband.is/financial-aid/applicant","@samband.is/financial-aid:read","@samband.is/financial-aid:write"]'
Expand Down
4 changes: 2 additions & 2 deletions charts/islandis/values.prod.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2182,7 +2182,7 @@ services-bff-portals-admin:
BFF_LOGIN_ATTEMPT_TTL_MS: '604800000'
BFF_LOGOUT_REDIRECT_URI: 'https://island.is'
BFF_NAME: 'stjornbord'
BFF_PAR_SUPPORT_ENABLED: 'true'
BFF_PAR_SUPPORT_ENABLED: 'false'
BFF_PROXY_API_ENDPOINT: 'http://web-api.islandis.svc.cluster.local/api/graphql'
CODE_OWNER: 'core'
IDENTITY_SERVER_CLIENT_ID: '@admin.island.is/bff-stjornbord'
Expand Down Expand Up @@ -2271,7 +2271,7 @@ services-bff-portals-my-pages:
BFF_LOGIN_ATTEMPT_TTL_MS: '604800000'
BFF_LOGOUT_REDIRECT_URI: 'https://island.is'
BFF_NAME: 'minarsidur'
BFF_PAR_SUPPORT_ENABLED: 'true'
BFF_PAR_SUPPORT_ENABLED: 'false'
BFF_PROXY_API_ENDPOINT: 'http://web-api.islandis.svc.cluster.local/api/graphql'
IDENTITY_SERVER_CLIENT_ID: '@island.is/web'
IDENTITY_SERVER_CLIENT_SCOPES: '["api_resource.scope","@island.is/applications:read","@island.is/applications:write","@island.is/user-profile:read","@island.is/user-profile:write","@island.is/auth/actor-delegations","@island.is/auth/delegations:write","@island.is/auth/consents","@skra.is/individuals","@island.is/documents","@island.is/endorsements","@admin.island.is/petitions","@island.is/assets/ip","@island.is/assets","@island.is/education","@island.is/education-license","@island.is/finance:overview","@island.is/finance/salary","@island.is/finance/schedule:read","@island.is/finance/loans","@island.is/internal","@island.is/internal:procuring","@island.is/me:details","@island.is/law-and-order","@island.is/licenses","@island.is/licenses:verify","@island.is/company","@island.is/vehicles","@island.is/work-machines","@island.is/health/payments","@island.is/health/medicines","@island.is/health/assistive-devices-and-nutrition","@island.is/health/therapies","@island.is/health/healthcare","@island.is/health/rights-status","@island.is/health/dentists","@island.is/health/organ-donation","@island.is/health/vaccinations","@island.is/signature-collection","@island.is/applications/urvinnslusjodur","@island.is/applications/orkusjodur","@island.is/fishing-license","@island.is/applications/samgongustofa-vehicles","@island.is/applications/ver","@samband.is/financial-aid/applicant","@samband.is/financial-aid:read","@samband.is/financial-aid:write"]'
Expand Down
4 changes: 2 additions & 2 deletions charts/islandis/values.staging.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2051,7 +2051,7 @@ services-bff-portals-admin:
BFF_LOGIN_ATTEMPT_TTL_MS: '604800000'
BFF_LOGOUT_REDIRECT_URI: 'https://beta.staging01.devland.is'
BFF_NAME: 'stjornbord'
BFF_PAR_SUPPORT_ENABLED: 'true'
BFF_PAR_SUPPORT_ENABLED: 'false'
BFF_PROXY_API_ENDPOINT: 'http://web-api.islandis.svc.cluster.local/api/graphql'
CODE_OWNER: 'core'
IDENTITY_SERVER_CLIENT_ID: '@admin.island.is/bff-stjornbord'
Expand Down Expand Up @@ -2138,7 +2138,7 @@ services-bff-portals-my-pages:
BFF_LOGIN_ATTEMPT_TTL_MS: '604800000'
BFF_LOGOUT_REDIRECT_URI: 'https://beta.staging01.devland.is'
BFF_NAME: 'minarsidur'
BFF_PAR_SUPPORT_ENABLED: 'true'
BFF_PAR_SUPPORT_ENABLED: 'false'
BFF_PROXY_API_ENDPOINT: 'http://web-api.islandis.svc.cluster.local/api/graphql'
IDENTITY_SERVER_CLIENT_ID: '@island.is/web'
IDENTITY_SERVER_CLIENT_SCOPES: '["api_resource.scope","@island.is/applications:read","@island.is/applications:write","@island.is/user-profile:read","@island.is/user-profile:write","@island.is/auth/actor-delegations","@island.is/auth/delegations:write","@island.is/auth/consents","@skra.is/individuals","@island.is/documents","@island.is/endorsements","@admin.island.is/petitions","@island.is/assets/ip","@island.is/assets","@island.is/education","@island.is/education-license","@island.is/finance:overview","@island.is/finance/salary","@island.is/finance/schedule:read","@island.is/finance/loans","@island.is/internal","@island.is/internal:procuring","@island.is/me:details","@island.is/law-and-order","@island.is/licenses","@island.is/licenses:verify","@island.is/company","@island.is/vehicles","@island.is/work-machines","@island.is/health/payments","@island.is/health/medicines","@island.is/health/assistive-devices-and-nutrition","@island.is/health/therapies","@island.is/health/healthcare","@island.is/health/rights-status","@island.is/health/dentists","@island.is/health/organ-donation","@island.is/health/vaccinations","@island.is/signature-collection","@island.is/applications/urvinnslusjodur","@island.is/applications/orkusjodur","@island.is/fishing-license","@island.is/applications/samgongustofa-vehicles","@island.is/applications/ver","@samband.is/financial-aid/applicant","@samband.is/financial-aid:read","@samband.is/financial-aid:write"]'
Expand Down
2 changes: 1 addition & 1 deletion charts/services/services-bff-portals-admin/values.dev.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ env:
BFF_LOGIN_ATTEMPT_TTL_MS: '604800000'
BFF_LOGOUT_REDIRECT_URI: 'https://beta.dev01.devland.is'
BFF_NAME: 'stjornbord'
BFF_PAR_SUPPORT_ENABLED: 'true'
BFF_PAR_SUPPORT_ENABLED: 'false'
BFF_PROXY_API_ENDPOINT: 'http://web-api.islandis.svc.cluster.local/api/graphql'
CODE_OWNER: 'core'
IDENTITY_SERVER_CLIENT_ID: '@admin.island.is/bff-stjornbord'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ env:
BFF_LOGIN_ATTEMPT_TTL_MS: '604800000'
BFF_LOGOUT_REDIRECT_URI: 'https://island.is'
BFF_NAME: 'stjornbord'
BFF_PAR_SUPPORT_ENABLED: 'true'
BFF_PAR_SUPPORT_ENABLED: 'false'
BFF_PROXY_API_ENDPOINT: 'http://web-api.islandis.svc.cluster.local/api/graphql'
CODE_OWNER: 'core'
IDENTITY_SERVER_CLIENT_ID: '@admin.island.is/bff-stjornbord'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ env:
BFF_LOGIN_ATTEMPT_TTL_MS: '604800000'
BFF_LOGOUT_REDIRECT_URI: 'https://beta.staging01.devland.is'
BFF_NAME: 'stjornbord'
BFF_PAR_SUPPORT_ENABLED: 'true'
BFF_PAR_SUPPORT_ENABLED: 'false'
BFF_PROXY_API_ENDPOINT: 'http://web-api.islandis.svc.cluster.local/api/graphql'
CODE_OWNER: 'core'
IDENTITY_SERVER_CLIENT_ID: '@admin.island.is/bff-stjornbord'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ env:
BFF_LOGIN_ATTEMPT_TTL_MS: '604800000'
BFF_LOGOUT_REDIRECT_URI: 'https://beta.dev01.devland.is'
BFF_NAME: 'minarsidur'
BFF_PAR_SUPPORT_ENABLED: 'true'
BFF_PAR_SUPPORT_ENABLED: 'false'
BFF_PROXY_API_ENDPOINT: 'http://web-api.islandis.svc.cluster.local/api/graphql'
IDENTITY_SERVER_CLIENT_ID: '@island.is/web'
IDENTITY_SERVER_CLIENT_SCOPES: '["api_resource.scope","@island.is/applications:read","@island.is/applications:write","@island.is/user-profile:read","@island.is/user-profile:write","@island.is/auth/actor-delegations","@island.is/auth/delegations:write","@island.is/auth/consents","@skra.is/individuals","@island.is/documents","@island.is/endorsements","@admin.island.is/petitions","@island.is/assets/ip","@island.is/assets","@island.is/education","@island.is/education-license","@island.is/finance:overview","@island.is/finance/salary","@island.is/finance/schedule:read","@island.is/finance/loans","@island.is/internal","@island.is/internal:procuring","@island.is/me:details","@island.is/law-and-order","@island.is/licenses","@island.is/licenses:verify","@island.is/company","@island.is/vehicles","@island.is/work-machines","@island.is/health/payments","@island.is/health/medicines","@island.is/health/assistive-devices-and-nutrition","@island.is/health/therapies","@island.is/health/healthcare","@island.is/health/rights-status","@island.is/health/dentists","@island.is/health/organ-donation","@island.is/health/vaccinations","@island.is/signature-collection","@island.is/applications/urvinnslusjodur","@island.is/applications/orkusjodur","@island.is/fishing-license","@island.is/applications/samgongustofa-vehicles","@island.is/applications/ver","@samband.is/financial-aid/applicant","@samband.is/financial-aid:read","@samband.is/financial-aid:write"]'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ env:
BFF_LOGIN_ATTEMPT_TTL_MS: '604800000'
BFF_LOGOUT_REDIRECT_URI: 'https://island.is'
BFF_NAME: 'minarsidur'
BFF_PAR_SUPPORT_ENABLED: 'true'
BFF_PAR_SUPPORT_ENABLED: 'false'
BFF_PROXY_API_ENDPOINT: 'http://web-api.islandis.svc.cluster.local/api/graphql'
IDENTITY_SERVER_CLIENT_ID: '@island.is/web'
IDENTITY_SERVER_CLIENT_SCOPES: '["api_resource.scope","@island.is/applications:read","@island.is/applications:write","@island.is/user-profile:read","@island.is/user-profile:write","@island.is/auth/actor-delegations","@island.is/auth/delegations:write","@island.is/auth/consents","@skra.is/individuals","@island.is/documents","@island.is/endorsements","@admin.island.is/petitions","@island.is/assets/ip","@island.is/assets","@island.is/education","@island.is/education-license","@island.is/finance:overview","@island.is/finance/salary","@island.is/finance/schedule:read","@island.is/finance/loans","@island.is/internal","@island.is/internal:procuring","@island.is/me:details","@island.is/law-and-order","@island.is/licenses","@island.is/licenses:verify","@island.is/company","@island.is/vehicles","@island.is/work-machines","@island.is/health/payments","@island.is/health/medicines","@island.is/health/assistive-devices-and-nutrition","@island.is/health/therapies","@island.is/health/healthcare","@island.is/health/rights-status","@island.is/health/dentists","@island.is/health/organ-donation","@island.is/health/vaccinations","@island.is/signature-collection","@island.is/applications/urvinnslusjodur","@island.is/applications/orkusjodur","@island.is/fishing-license","@island.is/applications/samgongustofa-vehicles","@island.is/applications/ver","@samband.is/financial-aid/applicant","@samband.is/financial-aid:read","@samband.is/financial-aid:write"]'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ env:
BFF_LOGIN_ATTEMPT_TTL_MS: '604800000'
BFF_LOGOUT_REDIRECT_URI: 'https://beta.staging01.devland.is'
BFF_NAME: 'minarsidur'
BFF_PAR_SUPPORT_ENABLED: 'true'
BFF_PAR_SUPPORT_ENABLED: 'false'
BFF_PROXY_API_ENDPOINT: 'http://web-api.islandis.svc.cluster.local/api/graphql'
IDENTITY_SERVER_CLIENT_ID: '@island.is/web'
IDENTITY_SERVER_CLIENT_SCOPES: '["api_resource.scope","@island.is/applications:read","@island.is/applications:write","@island.is/user-profile:read","@island.is/user-profile:write","@island.is/auth/actor-delegations","@island.is/auth/delegations:write","@island.is/auth/consents","@skra.is/individuals","@island.is/documents","@island.is/endorsements","@admin.island.is/petitions","@island.is/assets/ip","@island.is/assets","@island.is/education","@island.is/education-license","@island.is/finance:overview","@island.is/finance/salary","@island.is/finance/schedule:read","@island.is/finance/loans","@island.is/internal","@island.is/internal:procuring","@island.is/me:details","@island.is/law-and-order","@island.is/licenses","@island.is/licenses:verify","@island.is/company","@island.is/vehicles","@island.is/work-machines","@island.is/health/payments","@island.is/health/medicines","@island.is/health/assistive-devices-and-nutrition","@island.is/health/therapies","@island.is/health/healthcare","@island.is/health/rights-status","@island.is/health/dentists","@island.is/health/organ-donation","@island.is/health/vaccinations","@island.is/signature-collection","@island.is/applications/urvinnslusjodur","@island.is/applications/orkusjodur","@island.is/fishing-license","@island.is/applications/samgongustofa-vehicles","@island.is/applications/ver","@samband.is/financial-aid/applicant","@samband.is/financial-aid:read","@samband.is/financial-aid:write"]'
Expand Down
2 changes: 1 addition & 1 deletion infra/src/dsl/bff.ts
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ export const bffConfig = ({
},
BFF_GLOBAL_PREFIX: globalPrefix,
BFF_CLIENT_BASE_PATH: `/${key}`,
BFF_PAR_SUPPORT_ENABLED: 'true',
BFF_PAR_SUPPORT_ENABLED: 'false',
BFF_CLIENT_BASE_URL: {
local: 'http://localhost:4200',
dev: ref((ctx) => ctx.svc(getBaseUrl(ctx))),
Expand Down
2 changes: 1 addition & 1 deletion infra/src/dsl/feature-values.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ describe('Feature-deployment support', () => {
BFF_NAME: 'stjornbord',
BFF_CLIENT_BASE_PATH: '/stjornbord',
BFF_GLOBAL_PREFIX: `/stjornbord/bff`,
BFF_PAR_SUPPORT_ENABLED: 'true',
BFF_PAR_SUPPORT_ENABLED: 'false',
BFF_ALLOWED_REDIRECT_URIS: json([
'https://feature-A-beta.dev01.devland.is/stjornbord',
]),
Expand Down
2 changes: 1 addition & 1 deletion infra/src/dsl/portal-env.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ describe('BFF PortalEnv serialization', () => {
// BFF
BFF_NAME: 'stjornbord',
BFF_GLOBAL_PREFIX: `/${key}/bff`,
BFF_PAR_SUPPORT_ENABLED: 'true',
BFF_PAR_SUPPORT_ENABLED: 'false',
BFF_ALLOWED_REDIRECT_URIS: json([`https://beta.dev01.devland.is/${key}`]),
BFF_CLIENT_BASE_PATH: `/${key}`,
BFF_CLIENT_BASE_URL: 'https://beta.dev01.devland.is',
Expand Down

0 comments on commit e87eb22

Please sign in to comment.