Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade sequelize #14745

Merged
merged 3 commits into from
May 8, 2024
Merged

chore: upgrade sequelize #14745

merged 3 commits into from
May 8, 2024

Conversation

lodmfjord
Copy link
Member

@lodmfjord lodmfjord commented May 8, 2024

...

Attach a link to issue if relevant

What

Specify what you're trying to achieve

Why

Specify why you need to achieve this

Screenshots / Gifs

Attach Screenshots / Gifs to help reviewers understand the scope of the pull request

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Formatting passes locally with my changes
  • I have rebased against main before asking for a review

Summary by CodeRabbit

  • Chores
    • Updated package versions for sequelize, oidc-client-ts, and added resolution for dottie in package.json.

@lodmfjord lodmfjord requested a review from a team as a code owner May 8, 2024 14:18
Copy link
Contributor

coderabbitai bot commented May 8, 2024

Walkthrough

The update involves several changes in the package.json file:

  • The sequelize package version was bumped from 6.19.0 to 6.29.0.
  • The oidc-client-ts version was updated from "2.0.3" to "2.4.0.
  • A new resolution for dottie with version "2.0.4" was added.

Changes

File Change Summary
package.json Updated sequelize to 6.29.0, oidc-client-ts to 2.4.0, added resolution for dottie 2.0.4

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits Files that changed from the base of the PR and between d83303b and 90a3763.
Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/*.lock
Files selected for processing (1)
  • package.json (1 hunks)
Files skipped from review due to trivial changes (1)
  • package.json

@datadog-island-is
Copy link

datadog-island-is bot commented May 8, 2024

Datadog Report

All test runs 313a9c0 🔗

3 Total Test Services: 0 Failed, 2 Passed
⬆️ Test Sessions change in coverage: 1 increased (+0.02%), 3 no change

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Total Time Code Coverage Change Test Service View
api 0 0 0 4 0 3.14s 1 no change Link
api-domains-license-service 0 0 0 0 0 965ms 1 no change Link
license-api 0 0 0 80 0 26.42s 1 increased (+0.02%) Link

@lodmfjord lodmfjord added test everything 💀 test & build everything 💀 automerge Merge this PR as soon as all checks pass labels May 8, 2024
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits Files that changed from the base of the PR and between 90a3763 and 151a585.
Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/*.lock
Files selected for processing (1)
  • package.json (3 hunks)
Additional comments not posted (3)
package.json (3)

273-273: Updated sequelize to 6.29.0. Ensure application compatibility with this new version.


225-225: Updated oidc-client-ts to 2.4.0. Verify OIDC client functionality post-update.


462-462: Added resolution for dottie at 2.0.4. Verify that this resolution does not affect other dependencies.

Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.02%. Comparing base (6ff59cf) to head (151a585).
Report is 1 commits behind head on main.

❗ Current head 151a585 differs from pull request most recent head 128d194. Consider uploading reports for the commit 128d194 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #14745      +/-   ##
==========================================
+ Coverage   37.00%   37.02%   +0.01%     
==========================================
  Files        6297     6298       +1     
  Lines      127719   127743      +24     
  Branches    36527    36532       +5     
==========================================
+ Hits        47261    47291      +30     
+ Misses      80458    80452       -6     
Flag Coverage Δ
air-discount-scheme-backend 54.06% <ø> (ø)
air-discount-scheme-web 0.00% <ø> (ø)
api 3.44% <ø> (ø)
api-catalogue-services 77.85% <ø> (ø)
api-domains-air-discount-scheme 36.15% <ø> (ø)
api-domains-assets 26.71% <ø> (ø)
api-domains-auth-admin 57.99% <ø> (ø)
api-domains-communications 40.35% <ø> (ø)
api-domains-criminal-record 43.83% <ø> (ø)
api-domains-driving-license 44.76% <ø> (ø)
api-domains-education 33.81% <ø> (ø)
api-domains-health-insurance 27.35% <ø> (ø)
api-domains-mortgage-certificate 35.03% <ø> (ø)
api-domains-payment-schedule 40.50% <ø> (ø)
application-api-files 56.49% <ø> (ø)
application-core 71.76% <ø> (ø)
application-template-api-modules 24.67% <ø> (+0.03%) ⬆️
application-templates-accident-notification 19.59% <ø> (ø)
application-templates-car-recycling 4.23% <ø> (ø)
application-templates-criminal-record 21.57% <ø> (ø)
application-templates-driving-license 16.71% <ø> (ø)
application-templates-estate 11.73% <ø> (ø)
application-templates-example-payment 20.39% <ø> (ø)
application-templates-financial-aid 12.23% <ø> (ø)
application-templates-general-petition 19.03% <ø> (ø)
application-templates-health-insurance 23.03% <ø> (ø)
application-templates-inheritance-report 3.89% <ø> (ø)
application-types 7.43% <ø> (ø)
application-ui-components 1.44% <ø> (ø)
application-ui-shell 21.71% <ø> (ø)
auth-admin-web 2.43% <ø> (ø)
auth-api-lib 9.95% <ø> (ø)
auth-nest-tools 29.14% <ø> (ø)
auth-react 22.95% <ø> (ø)
auth-shared 75.00% <ø> (ø)
clients-charge-fjs-v2 22.58% <ø> (ø)
clients-driving-license 40.42% <ø> (ø)
clients-financial-statements-inao 48.71% <ø> (ø)
clients-license-client 1.84% <ø> (ø)
clients-middlewares 73.52% <ø> (ø)
clients-regulations 42.26% <ø> (ø)
clients-rsk-company-registry 29.24% <ø> (ø)
clients-rsk-personal-tax-return 38.00% <ø> (ø)
clients-smartsolutions 12.77% <ø> (ø)
clients-syslumenn 49.88% <ø> (ø)
clients-zendesk 55.26% <ø> (ø)
cms 0.44% <ø> (ø)
cms-translations 39.43% <ø> (+<0.01%) ⬆️
content-search-index-manager 95.65% <ø> (ø)
content-search-toolkit 8.57% <ø> (ø)
contentful-apps 6.60% <ø> (ø)
dokobit-signing 60.82% <ø> (ø)
download-service 44.30% <ø> (-0.01%) ⬇️
email-service 61.42% <ø> (ø)
feature-flags 90.08% <ø> (ø)
file-storage 52.05% <ø> (ø)
financial-aid-backend 56.22% <ø> (ø)
financial-aid-shared 17.51% <ø> (ø)
icelandic-names-registry-backend 54.10% <ø> (ø)
infra-nest-server 48.33% <ø> (ø)
infra-tracing 43.24% <ø> (ø)
island-ui-core 28.66% <ø> (-0.03%) ⬇️
judicial-system-api 17.60% <ø> (ø)
judicial-system-audit-trail 67.31% <ø> (ø)
judicial-system-backend 55.73% <ø> (ø)
judicial-system-formatters 82.46% <ø> (ø)
judicial-system-message 65.85% <ø> (ø)
judicial-system-message-handler 64.45% <ø> (ø)
license-api 43.23% <ø> (ø)
localization 10.15% <ø> (ø)
logging 48.43% <ø> (ø)
message-queue 68.39% <ø> (ø)
nest-audit 68.20% <ø> (ø)
nest-config 77.54% <ø> (ø)
nest-feature-flags 51.39% <ø> (ø)
nest-problem 46.08% <ø> (ø)
nest-sequelize 94.44% <ø> (ø)
nest-swagger 52.06% <ø> (ø)
nova-sms 63.41% <ø> (ø)
portals-admin-regulations-admin 2.13% <ø> (ø)
portals-core 16.14% <ø> (ø)
reference-backend 50.31% <ø> (ø)
regulations 16.90% <ø> (ø)
services-auth-admin-api 50.61% <ø> (-0.05%) ⬇️
services-auth-delegation-api 62.47% <ø> (-0.03%) ⬇️
services-auth-ids-api 54.70% <ø> (-0.05%) ⬇️
services-auth-personal-representative 49.88% <ø> (-0.05%) ⬇️
services-auth-personal-representative-public 45.47% <ø> (+0.14%) ⬆️
services-auth-public-api 50.30% <ø> (-0.02%) ⬇️
services-documents 60.91% <ø> (ø)
services-endorsements-api 55.45% <ø> (-0.05%) ⬇️
services-sessions 65.65% <ø> (ø)
services-university-gateway 48.47% <ø> (+0.05%) ⬆️
services-user-notification 47.66% <ø> (-0.01%) ⬇️
services-user-profile 62.85% <ø> (+0.32%) ⬆️
shared-components 27.79% <ø> (-0.04%) ⬇️
shared-form-fields 31.87% <ø> (-0.05%) ⬇️
shared-mocking 64.62% <ø> (ø)
shared-pii 92.85% <ø> (ø)
shared-problem 87.50% <ø> (ø)
shared-utils 26.14% <ø> (-1.53%) ⬇️
skilavottord-ws 23.81% <ø> (ø)
web 1.91% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4ef634...128d194. Read the comment docs.

Copy link
Member

@saevarma saevarma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving without checking release notes, as we have 2 weeks on dev to fix any regression that could occur 🤞

@kodiakhq kodiakhq bot merged commit 414bcb2 into main May 8, 2024
28 checks passed
@kodiakhq kodiakhq bot deleted the update-seq branch May 8, 2024 15:50
Ballioli pushed a commit that referenced this pull request May 17, 2024
* chore: upgrade sequelize

* fix: update versions

---------

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge this PR as soon as all checks pass test everything 💀 test & build everything 💀
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants