fix(api): Missing xroad from infra #14755
Conversation
WalkthroughThe recent updates involve the addition of new entities related to district commissioners in two separate services. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (2)
- apps/api/infra/api.ts (2 hunks)
- apps/download-service/infra/download-service.ts (2 hunks)
Files skipped from review due to trivial changes (1)
- apps/api/infra/api.ts
Additional Context Used
Path-based Instructions (1)
apps/download-service/infra/download-service.ts (1)
Pattern
apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
Additional comments not posted (2)
apps/download-service/infra/download-service.ts (2)
13-13: The addition ofDistrictCommissionersPCardto the imports is correctly implemented.
58-58: The addition ofDistrictCommissionersPCardandDistrictCommissionersLicensesto the xroad configuration is correctly implemented.
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (3)
- charts/islandis/values.dev.yaml (2 hunks)
- charts/islandis/values.prod.yaml (2 hunks)
- charts/islandis/values.staging.yaml (2 hunks)
Files skipped from review due to trivial changes (1)
- charts/islandis/values.staging.yaml
Additional comments not posted (4)
charts/islandis/values.prod.yaml (2)
332-332: Ensure the new XROAD path for district commissioners licenses is correctly formatted and matches the expected pattern.Verification successful
The verification script has successfully matched the XROAD path
IS/GOV/5512201410/Syslumenn-Protected/RettindiIslandisagainst the expected pattern'^IS/GOV/[0-9]+/[A-Za-z-]+/[A-Za-z]+$'. This confirms that the format of the new XROAD path for district commissioners licenses in thecharts/islandis/values.prod.yamlfile is correctly formatted and adheres to the expected structure.
- The path correctly starts with
IS/GOV/.- It includes a numeric identifier
5512201410.- Followed by valid segments that match the pattern, including hyphenated and non-hyphenated alphabetic strings.
Therefore, the review comment concern about the format of the new XROAD path has been verified as correct.
Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the format of the new XROAD path for district commissioners licenses. # Test: Check if the path matches the expected pattern. echo 'IS/GOV/5512201410/Syslumenn-Protected/RettindiIslandis' | grep -E '^IS/GOV/[0-9]+/[A-Za-z-]+/[A-Za-z]+$'Length of output: 165
1173-1173: Ensure the new XROAD path for district commissioners P-card is correctly formatted and matches the expected pattern.Verification successful
The output from the shell script confirms that the XROAD path
IS/GOV/5512201410/Syslumenn-Protected/IslandMinarSidurmatches the expected pattern as defined by the regex'^IS/GOV/[0-9]+/[A-Za-z-]+/[A-Za-z]+$'. This indicates that the format of the new XROAD path for district commissioners P-card is correctly formatted according to the specified pattern.
XROAD Path Format Verification Complete
The new XROAD path for district commissioners P-card has been verified and is correctly formatted as per the expected pattern.
- Path Verified:
IS/GOV/5512201410/Syslumenn-Protected/IslandMinarSidurScripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the format of the new XROAD path for district commissioners P-card. # Test: Check if the path matches the expected pattern. echo 'IS/GOV/5512201410/Syslumenn-Protected/IslandMinarSidur' | grep -E '^IS/GOV/[0-9]+/[A-Za-z-]+/[A-Za-z]+$'Length of output: 165
charts/islandis/values.dev.yaml (2)
342-342: Ensure the newly added XROAD path for district commissioners licenses is correct and follows the expected format.Verification successful
The verification script has successfully confirmed that the XROAD path for district commissioners licenses follows the expected format. The output from the script matches the expected pattern, indicating that the path is correctly formatted according to the specifications provided in the review comment.
Final Response
The XROAD path for district commissioners licenses is correctly formatted as per the expected standards.
Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the format of the XROAD path for district commissioners licenses. # Test: Check if the path follows the expected format 'IS-DEV/GOV/10016/Syslumenn-Protected/RettindiIslandis'. echo 'IS-DEV/GOV/10016/Syslumenn-Protected/RettindiIslandis' | grep -E '^IS-DEV/GOV/[0-9]+/[A-Za-z-]+/[A-Za-z]+$'Length of output: 167
1178-1178: Ensure the newly added XROAD path for district commissioners P-cards is correct and follows the expected format.Verification successful
The XROAD path for district commissioners P-cards is correctly formatted as per the expected pattern. No further action is required.
- Path:
IS-DEV/GOV/10016/Syslumenn-Protected/IslandMinarSidurScripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the format of the XROAD path for district commissioners P-cards. # Test: Check if the path follows the expected format 'IS-DEV/GOV/10016/Syslumenn-Protected/IslandMinarSidur'. echo 'IS-DEV/GOV/10016/Syslumenn-Protected/IslandMinarSidur' | grep -E '^IS-DEV/GOV/[0-9]+/[A-Za-z-]+/[A-Za-z]+$'Length of output: 167
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 2 Passed Test Services
🔻 Code Coverage Decreases vs Default Branch (1)
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14755 +/- ##
=======================================
Coverage 37.01% 37.01%
=======================================
Files 6298 6298
Lines 127751 127751
Branches 36537 36537
=======================================
Hits 47292 47292
Misses 80459 80459
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
|
* fix:init * chore:charts --------- Co-authored-by: Þorkell Máni Þorkelsson <mani@hugsmidjan.is> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
What
Add xroad defs for district commissioners licenses to infra
Why
Missing and crashing
Checklist:
Summary by CodeRabbit