fix(j-s): Filtering of public prosecution cases #14802
Conversation
WalkthroughThe recent changes streamline the filtering logic for prosecution user cases by removing redundant conditions. Specifically, the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (3)
- apps/judicial-system/backend/src/app/modules/case/filters/cases.filter.ts (1 hunks)
- apps/judicial-system/backend/src/app/modules/case/filters/test/cases.filter.spec.ts (2 hunks)
- apps/judicial-system/web/src/routes/Shared/Cases/Cases.tsx (1 hunks)
Files not reviewed due to errors (1)
- apps/judicial-system/web/src/routes/Shared/Cases/Cases.tsx (no review received)
Additional Context Used
Path-based Instructions (3)
apps/judicial-system/backend/src/app/modules/case/filters/cases.filter.ts (1)
Pattern
apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/judicial-system/web/src/routes/Shared/Cases/Cases.tsx (1)
Pattern
apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/judicial-system/backend/src/app/modules/case/filters/test/cases.filter.spec.ts (1)
Pattern
apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
Additional comments not posted (4)
apps/judicial-system/backend/src/app/modules/case/filters/cases.filter.ts (2)
48-48: Ensure the removal of theindictment_review_decisioncondition aligns with the intended logic. Verify that cases with non-nullindictment_review_decisionshould still be included in the results.
Line range hint
154-154: Ensure the new filtering condition correctly identifies cases awaiting review by the indictment reviewer. Verify that the logic aligns with the intended behavior of including cases with non-nullindictmentReviewDecision.apps/judicial-system/backend/src/app/modules/case/filters/test/cases.filter.spec.ts (2)
63-63: Ensure the updated test case correctly reflects the new filter condition forindictment_reviewer_id. Verify that the removal of theindictment_review_decisioncondition is consistent with the updated function logic.
121-121: Ensure the updated test case correctly reflects the new filter condition forindictment_reviewer_id. Verify that the removal of theindictment_review_decisioncondition is consistent with the updated function logic.
Datadog ReportAll test runs ✅ 3 Total Test Services: 0 Failed, 3 Passed Test Services
|
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- apps/judicial-system/backend/src/app/modules/case/filters/cases.filter.ts (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- apps/judicial-system/backend/src/app/modules/case/filters/cases.filter.ts
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14802 +/- ##
==========================================
- Coverage 36.97% 36.95% -0.02%
==========================================
Files 6327 6319 -8
Lines 129016 128486 -530
Branches 36831 36670 -161
==========================================
- Hits 47698 47483 -215
+ Misses 81318 81003 -315
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 68 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Þín yfirlesin mál sem saksóknari RSAK birtast í Afgreidd mál
What
Changed the filter so that public prosecutors can still see cases they were assigned to review even after they've finished reviewing them
Checklist:
Summary by CodeRabbit