fix(regulations-admin): Only display modal on amending regs #14823
Conversation
WalkthroughThe recent update modifies the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- libs/portals/admin/regulations-admin/src/components/EditBasics.tsx (1 hunks)
Additional Context Used
Path-based Instructions (1)
libs/portals/admin/regulations-admin/src/components/EditBasics.tsx (1)
Pattern
libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
Additional comments not posted (1)
libs/portals/admin/regulations-admin/src/components/EditBasics.tsx (1)
230-233: LGTM! The modal visibility condition now correctly checks if the draft type isamendingandisModalVisibleis true.
Datadog ReportAll test runs ✅ 34 Total Test Services: 0 Failed, 33 Passed Test ServicesThis report shows up to 10 services
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #14823 +/- ##
==========================================
- Coverage 36.91% 36.91% -0.01%
==========================================
Files 6322 6322
Lines 128754 128755 +1
Branches 36736 36738 +2
==========================================
Hits 47535 47535
- Misses 81219 81220 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
What
Only display modal if regulation is amending
Why
Base regulations need no modal for text update, there is no text to diff from 🤷
Checklist:
Summary by CodeRabbit