fix: increase resource #14902

lodmfjord · 2024-05-23T08:43:26Z

...

Attach a link to issue if relevant

What

Specify what you're trying to achieve

Why

Specify why you need to achieve this

Screenshots / Gifs

Attach Screenshots / Gifs to help reviewers understand the scope of the pull request

Checklist:

I have performed a self-review of my own code
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
Formatting passes locally with my changes
I have rebased against main before asking for a review

Summary by CodeRabbit

Chores
- Increased CPU resource limits for the API service from '600m' to '1200m' across all environments to enhance performance and stability.

coderabbitai · 2024-05-23T08:43:55Z

Walkthrough

The recent updates aim to optimize performance by increasing the CPU resource limits for a service setup across multiple configuration files. The CPU limit has been uniformly adjusted from '600m' to '1200m in various environments.

Changes

File Path	Change Summary
`apps/api/infra/api.ts`	Increased CPU limit from '600m' to '1200m' for service setup.
`charts/islandis/values.dev.yaml`	Adjusted CPU resource limit from '600m' to '1200m'.
`charts/islandis/values.prod.yaml`	Adjusted CPU resource limit from '600m' to '1200m'.
`charts/islandis/values.staging.yaml`	Adjusted CPU resource limit from '600m' to '1200m' and CPU requests from '250m' to '350m'.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

Review Details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 57a22bc and ede37b7.

Files selected for processing (4)

apps/api/infra/api.ts (1 hunks)
charts/islandis/values.dev.yaml (1 hunks)
charts/islandis/values.prod.yaml (1 hunks)
charts/islandis/values.staging.yaml (1 hunks)

Files skipped from review due to trivial changes (3)

charts/islandis/values.dev.yaml
charts/islandis/values.prod.yaml
charts/islandis/values.staging.yaml

Additional Context Used

Path-based Instructions (1)

apps/api/infra/api.ts (1)

Pattern apps/**/*: "Confirm that the code adheres to the following:

NextJS best practices, including file structure, API routes, and static generation methods.

Efficient state management and server-side rendering techniques.

Optimal use of TypeScript for component and utility type safety."

Additional comments not posted (1)

apps/api/infra/api.ts (1)
443-443: Increase in CPU limits approved; ensure memory settings are appropriate.
#!/bin/bash
# Description: Verify memory settings are appropriate with the new CPU limits.

# Test: Check if memory settings are consistent across environments.
rg --type yaml 'memory: "2048Mi"' ../charts/islandis/values*.yaml

datadog-island-is · 2024-05-23T08:55:19Z

Datadog Report

All test runs 4417fdc 🔗

✅ 9 Total Test Services: 0 Failed, 8 Passed
⬆️ Test Sessions change in coverage: 2 increased, 23 no change

Test Services

Service Name	Passed	Skipped	Total Time	Code Coverage Change	Test Service View
`api`	4	0	4.61s	1 no change	Link
`api-domains-communications`	5	0	40.1s	1 no change	Link
`api-domains-license-service`	0	0	1.23s	1 no change	Link
`application-system-api`	111	2	3m 12.54s	1 no change	Link
`application-template-api-modules`	109	0	1m 54.68s	1 increased (+0.01%)	Link
`cms-translations`	3	0	47.71s	1 no change	Link
`judicial-system-api`	54	0	6.03s	1 no change	Link
`judicial-system-backend`	19541	0	16m 32.85s	1 no change	Link
`services-user-notification`	48	0	1m 27.16s	1 increased (+0.02%)	Link

codecov · 2024-05-23T08:57:59Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@31cd2cf). Learn more about missing BASE report.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #14902   +/-   ##
=======================================
  Coverage        ?   37.07%           
=======================================
  Files           ?     6331           
  Lines           ?   129256           
  Branches        ?    36921           
=======================================
  Hits            ?    47928           
  Misses          ?    81328           
  Partials        ?        0

Flag	Coverage Δ
api	`3.48% <ø> (?)`
api-domains-communications	`40.61% <ø> (?)`
application-system-api	`41.95% <ø> (?)`
application-template-api-modules	`24.40% <ø> (?)`
cms	`0.44% <ø> (?)`
cms-translations	`39.72% <ø> (?)`
judicial-system-api	`17.61% <ø> (?)`
services-user-notification	`47.64% <ø> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31cd2cf...dcc3d26. Read the comment docs.

brynjarorng

LGTM

coderabbitai

Actionable comments posted: 0

Review Details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between ede37b7 and 6e480a0.

Files selected for processing (1)

apps/api/infra/api.ts (1 hunks)

Files skipped from review as they are similar to previous changes (1)

apps/api/infra/api.ts

coderabbitai

Actionable comments posted: 0

Review Details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 6e480a0 and dcc3d26.

Files selected for processing (3)

charts/islandis/values.dev.yaml (1 hunks)
charts/islandis/values.prod.yaml (1 hunks)
charts/islandis/values.staging.yaml (1 hunks)

Files skipped from review as they are similar to previous changes (3)

charts/islandis/values.dev.yaml
charts/islandis/values.prod.yaml
charts/islandis/values.staging.yaml

fix: increase resource

795508a

lodmfjord requested a review from a team as a code owner May 23, 2024 08:43

chore: charts update dirty files

ede37b7

coderabbitai bot reviewed May 23, 2024

View reviewed changes

coderabbitai bot approved these changes May 23, 2024

View reviewed changes

lodmfjord added the automerge Merge this PR as soon as all checks pass label May 23, 2024

brynjarorng approved these changes May 23, 2024

View reviewed changes

lodmfjord removed the automerge Merge this PR as soon as all checks pass label May 23, 2024

fix: resources

6e480a0

lodmfjord added the automerge Merge this PR as soon as all checks pass label May 23, 2024

coderabbitai bot reviewed May 23, 2024

View reviewed changes

andes-it and others added 2 commits May 23, 2024 09:18

chore: charts update dirty files

6eb072f

Merge branch 'main' into increase-resource-api

dcc3d26

coderabbitai bot reviewed May 23, 2024

View reviewed changes

kodiakhq bot merged commit 969e5e8 into main May 23, 2024
59 checks passed

kodiakhq bot deleted the increase-resource-api branch May 23, 2024 10:03

coderabbitai bot mentioned this pull request Oct 22, 2024

chore: Tweak CPU limits for skilavottord #16508

Open

6 tasks

coderabbitai bot mentioned this pull request Oct 29, 2024

chore(skilavottord): Expand cpu and ram size #16630

Merged

5 tasks

coderabbitai bot mentioned this pull request Nov 11, 2024

chore(application-system): Increase cpu and mem limit and request to avoid crashloops #16792

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: increase resource #14902

fix: increase resource #14902

lodmfjord commented May 23, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented May 23, 2024 •

edited

Loading

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

coderabbitai bot left a comment

datadog-island-is bot commented May 23, 2024 •

edited

Loading

codecov bot commented May 23, 2024 •

edited

Loading

brynjarorng left a comment

coderabbitai bot left a comment

coderabbitai bot left a comment

fix: increase resource #14902

fix: increase resource #14902

Conversation

lodmfjord commented May 23, 2024 • edited by coderabbitai bot Loading

...

What

Why

Screenshots / Gifs

Checklist:

Summary by CodeRabbit

coderabbitai bot commented May 23, 2024 • edited Loading

Walkthrough

Changes

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

coderabbitai bot left a comment

Choose a reason for hiding this comment

datadog-island-is bot commented May 23, 2024 • edited Loading

Datadog Report

codecov bot commented May 23, 2024 • edited Loading

Codecov Report

brynjarorng left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

lodmfjord commented May 23, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented May 23, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)

datadog-island-is bot commented May 23, 2024 •

edited

Loading

codecov bot commented May 23, 2024 •

edited

Loading