chore: upgrade node version

.github/actions/change-detection.ts

@@ -113,80 +113,93 @@ export async function findBestGoodRefPR(
 ): Promise<LastGoodBuild> {
   const log = app.extend('findBestGoodRefPR')
   log(`Starting with head branch ${headBranch} and base branch ${baseBranch}`)
-  const lastCommitSha = await git.lastCommit()
-  const prCommits = await getCommits(git, headBranch, baseBranch, 'HEAD')
+  return new Promise(async (resolve) => {
+    const lastCommitSha = await git.lastCommit()
+    const prCommits = await getCommits(git, headBranch, baseBranch, 'HEAD')
 
-  const prRun = await githubApi.getLastGoodPRRun(
-    headBranch,
-    workflowId,
-    prCommits,
-  )
-  const prBuilds: {
-    distance: number
-    hash: string
-    run_nr: number
-    branch: string
-    ref: string
-  }[] = []
-  if (prRun) {
-    log(`Found a PR run candidate: ${JSON.stringify(prRun)}`)
-    try {
-      const tempBranch = `${headBranch}-${Math.round(Math.random() * 1000000)}`
-      await git.checkoutBranch(tempBranch, prRun.base_commit)
-      log(`Branch checked out`)
-      const mergeCommitSha = await git.merge(prRun.head_commit)
-      log(`Simulated previous PR merge commit`)
-      const distance = await githubApi.getChangedComponents(
+    const prRun = await githubApi.getLastGoodPRRun(
+      headBranch,
+      workflowId,
+      prCommits,
+    )
+    const prBuilds: {
+      distance: number
+      hash: string
+      run_nr: number
+      branch: string
+      ref: string
+    }[] = []
+    if (prRun) {
+      log(`Found a PR run candidate: ${JSON.stringify(prRun)}`)
+      try {
+        const tempBranch = `${headBranch}-${Math.round(
+          Math.random() * 1000000,
+        )}`
+        await git.checkoutBranch(tempBranch, prRun.base_commit)
+        log(`Branch checked out`)
+        const mergeCommitSha = await git.merge(prRun.head_commit)
+        log(`Simulated previous PR merge commit`)
+        const distance = await githubApi.getChangedComponents(
+          git,
+          lastCommitSha,
+          mergeCommitSha,
+        )
+        log(`Affected components since candidate PR run are ${distance}`)
+        prBuilds.push({
+          distance: diffWeight(distance),
+          hash: prRun.head_commit,
+          run_nr: prRun.run_nr,
+          branch: headBranch,
+          ref: mergeCommitSha,
+        })
+      } catch (e) {
+        log(
+          `Error processing PR candidate(${prRun.run_nr}) but continuing: %O`,
+          e,
+        )
+      } finally {
+        await git.checkout(prBranch)
+      }
+    }
+
+    const baseCommits = await getCommits(git, prBranch, baseBranch, 'HEAD~1')
+    log(`Base commits ${baseCommits.join(' ')}`)
+    const baseGoodBuilds = await githubApi.getLastGoodBranchBuildRun(
+      baseBranch,
+      'push',
+      baseCommits,
+    )
+    if (baseGoodBuilds) {
+      log(`Found Base good builds ${JSON.stringify(baseGoodBuilds)}`)
+      let affectedComponents = await githubApi.getChangedComponents(
         git,
         lastCommitSha,
-        mergeCommitSha,
+        baseGoodBuilds.head_commit,
       )
-      log(`Affected components since candidate PR run are ${distance}`)
+      log(`Found affected components ${affectedComponents}`)
       prBuilds.push({
-        distance: diffWeight(distance),
-        hash: prRun.head_commit,
-        run_nr: prRun.run_nr,
-        branch: headBranch,
-        ref: mergeCommitSha,
+        distance: diffWeight(affectedComponents),
+        hash: baseGoodBuilds.head_commit,
+        run_nr: baseGoodBuilds.run_nr,
+        branch: baseBranch,
+        ref: baseGoodBuilds.head_commit,
       })
-    } catch (e) {
-      log(
-        `Error processing PR candidate(${prRun.run_nr}) but continuing: %O`,
-        e,
-      )
-    } finally {
-      await git.checkout(prBranch)
+      log('stops on push?!?!')
     }
-  }
-
-  const baseCommits = await getCommits(git, prBranch, baseBranch, 'HEAD~1')
-
-  const baseGoodBuilds = await githubApi.getLastGoodBranchBuildRun(
-    baseBranch,
-    'push',
-    baseCommits,
-  )
-  if (baseGoodBuilds) {
-    let affectedComponents = await githubApi.getChangedComponents(
-      git,
-      lastCommitSha,
-      baseGoodBuilds.head_commit,
-    )
-    prBuilds.push({
-      distance: diffWeight(affectedComponents),
-      hash: baseGoodBuilds.head_commit,
-      run_nr: baseGoodBuilds.run_nr,
-      branch: baseBranch,
-      ref: baseGoodBuilds.head_commit,
-    })
-  }
-  prBuilds.sort((a, b) => (a.distance > b.distance ? 1 : -1))
-  if (prBuilds.length > 0)
-    return {
-      sha: prBuilds[0].hash,
-      run_number: prBuilds[0].run_nr,
-      branch: prBuilds[0].branch.replace('origin/', ''),
-      ref: prBuilds[0].ref,
+    log(`pr build ${JSON.stringify(prBuilds)}`)
+    prBuilds.sort((a, b) => (a.distance > b.distance ? 1 : -1))
+    log(`sort done`)
+    if (prBuilds.length > 0) {
+      log(`return message`)
+      resolve({
+        sha: prBuilds[0].hash,
+        run_number: prBuilds[0].run_nr,
+        branch: prBuilds[0].branch.replace('origin/', ''),
+        ref: prBuilds[0].ref,
+      })
+      return
     }
-  return 'rebuild'
+    log(`return rebuild`)
+    resolve('rebuild')
+  })
 }

.github/actions/dist/main.js

@@ -26154,73 +26154,85 @@ function findBestGoodRefPR(diffWeight, git, githubApi, headBranch, baseBranch, p
   return __async(this, null, function* () {
     const log = app2.extend("findBestGoodRefPR");
     log(`Starting with head branch ${headBranch} and base branch ${baseBranch}`);
-    const lastCommitSha = yield git.lastCommit();
-    const prCommits = yield getCommits(git, headBranch, baseBranch, "HEAD");
-    const prRun = yield githubApi.getLastGoodPRRun(
-      headBranch,
-      workflowId,
-      prCommits
-    );
-    const prBuilds = [];
-    if (prRun) {
-      log(`Found a PR run candidate: ${JSON.stringify(prRun)}`);
-      try {
-        const tempBranch = `${headBranch}-${Math.round(Math.random() * 1e6)}`;
-        yield git.checkoutBranch(tempBranch, prRun.base_commit);
-        log(`Branch checked out`);
-        const mergeCommitSha = yield git.merge(prRun.head_commit);
-        log(`Simulated previous PR merge commit`);
-        const distance = yield githubApi.getChangedComponents(
+    return new Promise((resolve) => __async(this, null, function* () {
+      const lastCommitSha = yield git.lastCommit();
+      const prCommits = yield getCommits(git, headBranch, baseBranch, "HEAD");
+      const prRun = yield githubApi.getLastGoodPRRun(
+        headBranch,
+        workflowId,
+        prCommits
+      );
+      const prBuilds = [];
+      if (prRun) {
+        log(`Found a PR run candidate: ${JSON.stringify(prRun)}`);
+        try {
+          const tempBranch = `${headBranch}-${Math.round(Math.random() * 1e6)}`;
+          yield git.checkoutBranch(tempBranch, prRun.base_commit);
+          log(`Branch checked out`);
+          const mergeCommitSha = yield git.merge(prRun.head_commit);
+          log(`Simulated previous PR merge commit`);
+          const distance = yield githubApi.getChangedComponents(
+            git,
+            lastCommitSha,
+            mergeCommitSha
+          );
+          log(`Affected components since candidate PR run are ${distance}`);
+          prBuilds.push({
+            distance: diffWeight(distance),
+            hash: prRun.head_commit,
+            run_nr: prRun.run_nr,
+            branch: headBranch,
+            ref: mergeCommitSha
+          });
+        } catch (e) {
+          log(
+            `Error processing PR candidate(${prRun.run_nr}) but continuing: %O`,
+            e
+          );
+        } finally {
+          yield git.checkout(prBranch);
+        }
+      }
+      const baseCommits = yield getCommits(git, prBranch, baseBranch, "HEAD~1");
+      log(`Base commits ${baseCommits.join(" ")}`);
+      const baseGoodBuilds = yield githubApi.getLastGoodBranchBuildRun(
+        baseBranch,
+        "push",
+        baseCommits
+      );
+      if (baseGoodBuilds) {
+        log(`Found Base good builds ${JSON.stringify(baseGoodBuilds)}`);
+        let affectedComponents = yield githubApi.getChangedComponents(
           git,
           lastCommitSha,
-          mergeCommitSha
+          baseGoodBuilds.head_commit
         );
-        log(`Affected components since candidate PR run are ${distance}`);
+        log(`Found affected components ${affectedComponents}`);
         prBuilds.push({
-          distance: diffWeight(distance),
-          hash: prRun.head_commit,
-          run_nr: prRun.run_nr,
-          branch: headBranch,
-          ref: mergeCommitSha
+          distance: diffWeight(affectedComponents),
+          hash: baseGoodBuilds.head_commit,
+          run_nr: baseGoodBuilds.run_nr,
+          branch: baseBranch,
+          ref: baseGoodBuilds.head_commit
         });
-      } catch (e) {
-        log(
-          `Error processing PR candidate(${prRun.run_nr}) but continuing: %O`,
-          e
-        );
-      } finally {
-        yield git.checkout(prBranch);
+        log("stops on push?!?!");
+      }
+      log(`pr build ${JSON.stringify(prBuilds)}`);
+      prBuilds.sort((a, b) => a.distance > b.distance ? 1 : -1);
+      log(`sort done`);
+      if (prBuilds.length > 0) {
+        log(`return message`);
+        resolve({
+          sha: prBuilds[0].hash,
+          run_number: prBuilds[0].run_nr,
+          branch: prBuilds[0].branch.replace("origin/", ""),
+          ref: prBuilds[0].ref
+        });
+        return;
       }
-    }
-    const baseCommits = yield getCommits(git, prBranch, baseBranch, "HEAD~1");
-    const baseGoodBuilds = yield githubApi.getLastGoodBranchBuildRun(
-      baseBranch,
-      "push",
-      baseCommits
-    );
-    if (baseGoodBuilds) {
-      let affectedComponents = yield githubApi.getChangedComponents(
-        git,
-        lastCommitSha,
-        baseGoodBuilds.head_commit
-      );
-      prBuilds.push({
-        distance: diffWeight(affectedComponents),
-        hash: baseGoodBuilds.head_commit,
-        run_nr: baseGoodBuilds.run_nr,
-        branch: baseBranch,
-        ref: baseGoodBuilds.head_commit
-      });
-    }
-    prBuilds.sort((a, b) => a.distance > b.distance ? 1 : -1);
-    if (prBuilds.length > 0)
-      return {
-        sha: prBuilds[0].hash,
-        run_number: prBuilds[0].run_nr,
-        branch: prBuilds[0].branch.replace("origin/", ""),
-        ref: prBuilds[0].ref
-      };
-    return "rebuild";
+      log(`return rebuild`);
+      resolve("rebuild");
+    }));
   });
 }
 
@@ -26345,11 +26357,12 @@ var FULL_REBUILD_NEEDED = "full_rebuild_needed";
   );
   if (rev === "rebuild") {
     console.log(FULL_REBUILD_NEEDED);
-    return;
+    process.exit(0);
   }
   rev.branch = rev.branch.replace(/'/g, "");
   rev.ref = rev.ref.replace(/'/g, "");
   console.log(JSON.stringify(rev));
+  process.exit(0);
 }))();
 /*!
  * is-plain-object <https://github.com/jonschlinkert/is-plain-object>

.github/actions/main.ts

@@ -37,9 +37,10 @@ const FULL_REBUILD_NEEDED = 'full_rebuild_needed'
 
   if (rev === 'rebuild') {
     console.log(FULL_REBUILD_NEEDED)
-    return
+    process.exit(0)
   }
   rev.branch = rev.branch.replace(/'/g, '')
   rev.ref = rev.ref.replace(/'/g, '')
   console.log(JSON.stringify(rev))
+  process.exit(0)
 })()

.github/actions/package.json

@@ -19,7 +19,7 @@
     "@octokit/rest": "19.0.4",
     "@types/debug": "4.1.7",
     "@types/jest": "^27.4.1",
-    "@types/node": "20.11.4",
+    "@types/node": "20.12.12",
     "debug": "4.3.4",
     "esbuild": "0.15.10",
     "esbuild-runner": "2.2.1",

.github/actions/tsconfig.json

@@ -12,7 +12,7 @@
     "target": "es2015",
     "module": "esnext",
     "typeRoots": ["node_modules/@types"],
-    "lib": ["es2019", "esnext.array"],
+    "lib": ["es2019", "esnext.array", "esnext"],
     "skipLibCheck": true,
     "skipDefaultLibCheck": true,
     "allowSyntheticDefaultImports": true,

.github/actions/unit-test/action.yml

@@ -36,9 +36,9 @@ runs:
       run: npm install -g yarn
       shell: bash
 
-    - uses: actions/setup-node@v2
+    - uses: actions/setup-node@v4
       with:
-        node-version: '18'
+        node-version-file: 'package.json'
 
     - name: Setup yarn
       run: npm install -g yarn

.github/actions/yarn.lock

@@ -1610,12 +1610,12 @@ __metadata:
   languageName: node
   linkType: hard
 
-"@types/node@npm:20.11.4":
-  version: 20.11.4
-  resolution: "@types/node@npm:20.11.4"
+"@types/node@npm:20.12.12":
+  version: 20.12.12
+  resolution: "@types/node@npm:20.12.12"
   dependencies:
     undici-types: ~5.26.4
-  checksum: b9cf2c5397ea31f3355656edd204aee777a36db75b79b8b7aba2bed7ea5b29914fa808489da5c632c5eddbb33c3106188bef0bff3b7648bd39aa50dee466a73b
+  checksum: 5373983874b9af7c216e7ca5d26b32a8d9829c703a69f1e66f2113598b5be8582c0e009ca97369f1ec9a6282b3f92812208d06eb1e9fc3bd9b939b022303d042
   languageName: node
   linkType: hard
 
@@ -1715,7 +1715,7 @@ __metadata:
     "@octokit/rest": 19.0.4
     "@types/debug": 4.1.7
     "@types/jest": ^27.4.1
-    "@types/node": 20.11.4
+    "@types/node": 20.12.12
     debug: 4.3.4
     esbuild: 0.15.10
     esbuild-runner: 2.2.1