fix(inheritance-report): Efs fixes for share #15261
Conversation
WalkthroughThe updates to the inheritance-report application predominantly enhance the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (5)
- libs/application/templates/inheritance-report/src/components/DeceasedShare/index.tsx (1 hunks)
- libs/application/templates/inheritance-report/src/components/ShareInput/index.tsx (4 hunks)
- libs/application/templates/inheritance-report/src/fields/index.ts (1 hunks)
- libs/application/templates/inheritance-report/src/forms/sections/deceased.ts (2 hunks)
- libs/application/templates/inheritance-report/src/lib/messages.ts (1 hunks)
Files skipped from review due to trivial changes (2)
- libs/application/templates/inheritance-report/src/fields/index.ts
- libs/application/templates/inheritance-report/src/lib/messages.ts
Additional context used
Path-based instructions (3)
libs/application/templates/inheritance-report/src/components/DeceasedShare/index.tsx (1)
Pattern
libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/application/templates/inheritance-report/src/forms/sections/deceased.ts (1)
Pattern
libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/application/templates/inheritance-report/src/components/ShareInput/index.tsx (1)
Pattern
libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
Biome
libs/application/templates/inheritance-report/src/components/ShareInput/index.tsx
[error] 126-126: Avoid redundant double-negation. (lint/complexity/noExtraBooleanCast)
It is not necessary to use double-negation when a value will already be coerced to a boolean.
Unsafe fix: Remove redundant double-negation
[error] 174-174: Avoid redundant double-negation. (lint/complexity/noExtraBooleanCast)
It is not necessary to use double-negation when a value will already be coerced to a boolean.
Unsafe fix: Remove redundant double-negation
Additional comments not posted (5)
libs/application/templates/inheritance-report/src/components/DeceasedShare/index.tsx (1)
69-69: Conditional padding logic is implemented correctly.This change effectively adjusts the padding based on the checkbox state, enhancing UI responsiveness.
libs/application/templates/inheritance-report/src/forms/sections/deceased.ts (1)
104-123: The integration ofbuildCustomFieldforcustomSpouseSharePercentageis implemented correctly.This change allows for more flexible form input handling, aligning with the new requirements for deceased sections. Ensure that all dependent logic correctly handles these new field configurations.
libs/application/templates/inheritance-report/src/components/ShareInput/index.tsx (3)
1-1: Imports and interface expansion handled correctly.The imports for
BoxandController, and the addition ofgetErrorViaPathare appropriate for the new functionality. The expansion ofShareInputPropsto includefieldenhances the component's flexibility in form contexts.Also applies to: 3-3, 7-7
19-26: Proper use of optional chaining in TypeScript.The optional chaining (
field?.props) ensures that the component handles scenarios wherefieldmight not be provided, thus preventing runtime errors.
69-69: Enhanced error handling within the component.The use of
getErrorViaPathto fetch context-specific errors is a robust approach for dynamic form validation.Also applies to: 76-80
libs/application/templates/inheritance-report/src/components/ShareInput/index.tsx
Outdated
Show resolved
Hide resolved
libs/application/templates/inheritance-report/src/components/ShareInput/index.tsx
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15261 +/- ##
==========================================
- Coverage 37.14% 37.14% -0.01%
==========================================
Files 6472 6470 -2
Lines 131869 131602 -267
Branches 37697 37622 -75
==========================================
- Hits 48989 48883 -106
+ Misses 82880 82719 -161
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 73 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Datadog ReportAll test runs ✅ 4 Total Test Services: 0 Failed, 4 Passed Test Services
|
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- libs/application/templates/inheritance-report/src/components/ShareInput/index.tsx (4 hunks)
Files skipped from review as they are similar to previous changes (1)
- libs/application/templates/inheritance-report/src/components/ShareInput/index.tsx
albinagu
added
automerge
|
Affected services are: api,application-system-api,application-system-form, |
albinagu
added
automerge
Checklist:
Summary by CodeRabbit
New Features
DeceasedSharecomponent based on user input.ShareInputcomponent with improved error handling and added support for custom field properties like label, placeholder, and name.ShareInputin the fields module.Bug Fixes
deceasedSharePart.