feat(new-primary-school): Allergies and intolerances - Data implementation #15319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Base branches to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
helgifr
reviewed
Jun 21, 2024
libs/application/templates/new-primary-school/src/lib/newPrimarySchoolUtils.ts
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## new-primary-school-data-implementation #15319 +/- ##
=========================================================================
Coverage ? 37.13%
=========================================================================
Files ? 6500
Lines ? 132213
Branches ? 37806
=========================================================================
Hits ? 49092
Misses ? 83121
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
|
Datadog ReportAll test runs ✅ 3 Total Test Services: 0 Failed, 3 Passed Test Services
🔻 Code Coverage Decreases vs Default Branch (1)
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
veronikasif
changed the title
birkirkristmunds
merged commit e350021
into
new-primary-school-data-implementation
36 of 37 checks passed
birkirkristmunds
deleted the
feat/new-primary-school-allergies-and-intolerances-data
branch
kodiakhq bot
added a commit
that referenced
this pull request
Oct 4, 2024
…es (#16096) * Added latest version of clientConfig and latest endpoints from Juni * testing * Rollback test * feat(new-primary-school): Allergies and intolerances - Data implementation (#15319) * [TS-806] Implement Allergies and intolerances page - Data implementation * Updated function name * Refactor/new primary school data implementation (#15381) * refactor: updated apitags * fix? clean * chore: nx format:write update dirty files --------- Co-authored-by: Alex Diljar <alex@juni.is> Co-authored-by: andes-it <builders@andes.is> * Comment out UserApi * feat(new-primary-school): Move child page to prerequisites (#15394) * Move child page to prerequisites * Update clientConfig * Updated Api module action name * feat(new-primary-school): Relatives - Data implementation (#15403) * Relatives - Data implementation * Fixed after review * feat(new-primary-school): pronoun (#15408) * feat(new-primary-school): Pronoun Select Field Added a select field for selecting pronoun https://dit-iceland.atlassian.net/browse/TS-811 * Make pronoun full width and change place with preferred name * Use gender data from Júní * Review comment fixes * use defaultValue for pronouns --------- Co-authored-by: hfhelgason <hfhelgason@deloitte.is> * Update Frigg service path * Update clientConfig * feat(new-primary-school): Implement no children found page (#15909) * [TS-816] Implement no children found page * Remove comments * feat(new-primary): Update new primary school application (#15849) * [TS-883] Remove 'Má sækja barn' - Relatives page * [TS-884] Remove gender - Child info page * [TS-885] Remove use of footage page * Update Child in Review * [TS-904] Remove Allergies and intolerances page (#15923) Co-authored-by: bkristmundsson <bikkibo@gmail.com> * Remove duplicated translations * feat(new-primary-school): New school - Data implementation (#15437) * New school - Data implementation * testing build problems * testing build problems * build problem testing * build problem testing * Rollback build test --------- Co-authored-by: bkristmundsson <bikkibo@gmail.com> * Fixed codegen error? * Updated loadOptions in FriggOptionsAsyncSelectField * Updated clientConfig * Updated other parent address * Allow children to pass through for testing * chore: nx format:write update dirty files * feat(new-primary-school): Current school (#16125) * Implement current school * Fixed message namespace error * Updated messages * Remove unnecessary data providers and their associated functions * Removed unused stateMachine action * feat(new-primary-school): Send application (#15489) * Send application - Not ready * Update sendApplication - Not ready * Update sendApplication - Not ready * chore: nx format:write update dirty files * Removed logo * Updated languages in transformApplicationToNewPrimarySchoolDTO * Updated text in Review * [TS-814] Implement send application --------- Co-authored-by: andes-it <builders@andes.is> * Simplified nested ternary operator used to calculate noIcelandic * Removed otherParentName - unused * Fix after coderabbit * Fixed formatGrade() after review from coderabbitai * Update nationalRegistry text in externalData * Fix after coderabbit * Fix after coderabbit * Fix after coderabbit, added default values * Fix after coderabbit, added default values * Fix after coderabbit, added null checks --------- Co-authored-by: veronikasif <54938148+veronikasif@users.noreply.github.com> Co-authored-by: Alex Diljar Birkisbur Hellsing <42963845+alexdiljar@users.noreply.github.com> Co-authored-by: Alex Diljar <alex@juni.is> Co-authored-by: andes-it <builders@andes.is> Co-authored-by: Veronika Sif <veronikasif@hotmail.com> Co-authored-by: helgifr <helgifreyr95@gmail.com> Co-authored-by: hfhelgason <hfhelgason@deloitte.is> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[TS-806] Implement Allergies and intolerances page
What
Specify what you're trying to achieve
Why
Specify why you need to achieve this
Screenshots / Gifs
Attach Screenshots / Gifs to help reviewers understand the scope of the pull request
Checklist: