chore(j-s): ActiveCases table refactoring #15474
Conversation
WalkthroughThe changes across the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Datadog ReportAll test runs ✅ 101 Total Test Services: 0 Failed, 99 Passed Test ServicesThis report shows up to 10 services
🔻 Code Coverage Decreases vs Default Branch (3) |
oddsson
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15474 +/- ##
========================================
Coverage 37.03% 37.04%
========================================
Files 6557 6556 -1
Lines 134057 133848 -209
Branches 38371 38318 -53
========================================
- Hits 49653 49583 -70
+ Misses 84404 84265 -139
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 52 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
Files selected for processing (12)
- apps/judicial-system/web/src/components/AccordionItems/IndictmentsCaseFilesAccordionItem/IndictmentsCaseFilesAccordionItem.tsx (1 hunks)
- apps/judicial-system/web/src/components/Table/PastCasesTable/PastCasesTable.tsx (1 hunks)
- apps/judicial-system/web/src/components/Table/Table.css.ts (3 hunks)
- apps/judicial-system/web/src/components/Table/Table.tsx (3 hunks)
- apps/judicial-system/web/src/components/Table/TableSkeleton/TableSkeleton.tsx (1 hunks)
- apps/judicial-system/web/src/routes/Shared/Cases/ActiveCases.tsx (1 hunks)
- apps/judicial-system/web/src/routes/Shared/Cases/Cases.css.ts (2 hunks)
- apps/judicial-system/web/src/routes/Shared/Cases/Cases.spec.tsx (6 hunks)
- apps/judicial-system/web/src/routes/Shared/Cases/Cases.strings.ts (1 hunks)
- apps/judicial-system/web/src/routes/Shared/Cases/Cases.tsx (1 hunks)
- apps/judicial-system/web/src/routes/Shared/SignedVerdictOverview/SignedVerdictOverview.tsx (1 hunks)
- package.json (1 hunks)
Files skipped from review due to trivial changes (7)
- apps/judicial-system/web/src/components/Table/PastCasesTable/PastCasesTable.tsx
- apps/judicial-system/web/src/components/Table/Table.css.ts
- apps/judicial-system/web/src/routes/Shared/Cases/ActiveCases.tsx
- apps/judicial-system/web/src/routes/Shared/Cases/Cases.css.ts
- apps/judicial-system/web/src/routes/Shared/Cases/Cases.spec.tsx
- apps/judicial-system/web/src/routes/Shared/Cases/Cases.strings.ts
- package.json
Additional context used
Path-based instructions (5)
apps/judicial-system/web/src/components/Table/TableSkeleton/TableSkeleton.tsx (1)
Pattern
apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/judicial-system/web/src/components/Table/Table.tsx (1)
Pattern
apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/judicial-system/web/src/routes/Shared/Cases/Cases.tsx (1)
Pattern
apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/judicial-system/web/src/components/AccordionItems/IndictmentsCaseFilesAccordionItem/IndictmentsCaseFilesAccordionItem.tsx (1)
Pattern
apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/judicial-system/web/src/routes/Shared/SignedVerdictOverview/SignedVerdictOverview.tsx (1)
Pattern
apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
Additional comments not posted (5)
apps/judicial-system/web/src/components/Table/TableSkeleton/TableSkeleton.tsx (1)
55-170: Verify styling after class name removal.The changes involve removing class names from
<td>elements and directly using theSkeletonLoadercomponent. Ensure that the styling is still correct after these changes.apps/judicial-system/web/src/components/Table/Table.tsx (2)
Line range hint
11-129:
Verify screen width condition update.The screen width condition for rendering has been updated from
theme.breakpoints.mdtotheme.breakpoints.lg. Ensure that this change aligns with the design requirements.
208-247: Verify context menu animations.The changes involve adding
AnimatePresenceandmotioncomponents for context menu animations. Ensure that the animations work as intended and do not introduce any performance issues.apps/judicial-system/web/src/routes/Shared/Cases/Cases.tsx (1)
303-303: Verify prop change inActiveCasescomponent.The
ActiveCasescomponent's prop has been updated fromonDeleteCasetoonContextMenuDeleteClick. Ensure that this change does not break the functionality and that thevisibleModalstate is set correctly.apps/judicial-system/web/src/routes/Shared/SignedVerdictOverview/SignedVerdictOverview.tsx (1)
722-722: Verify the animation behavior withmode="wait".The
modeprop update to"wait"inAnimatePresenceensures smoother transitions by waiting for the exit animation to complete before starting the enter animation. Verify that this change achieves the desired animation behavior.
* Fix sideStepper for cases in WAITING_FOR_CANCELLATION state * Remove unused code * Remove unused css * Use Table component for ActiveCases * Refactoring * Remove unused code * Styling * Add nicer animations * Add better animations * Refactoring * Remove debug code * Add ability to remove cases * Fix tests --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
ActiveCases table refactoring
Asana
What
Tablecomponent.mode='popLayout'onAnimatePresence. See upgrade instructions hereScreenshots / Gifs
Screen.Recording.2024-07-09.at.11.56.11.mov
Checklist:
Summary by CodeRabbit
New Features
Bug Fixes
Refactor
ActiveCasescomponent, improving maintainability and performance.Chores
framer-motionto version 9.0.0 for improved animation capabilities.