fix(native-app): large title on all tab screens now fixed #15504
Conversation
WalkthroughThe changes introduce the use of Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (4)
- apps/native/app/src/screens/applications/applications.tsx (4 hunks)
- apps/native/app/src/screens/inbox/inbox.tsx (4 hunks)
- apps/native/app/src/screens/more/more.tsx (4 hunks)
- apps/native/app/src/screens/wallet/wallet.tsx (4 hunks)
Additional context used
Path-based instructions (4)
apps/native/app/src/screens/more/more.tsx (1)
Pattern
apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/native/app/src/screens/applications/applications.tsx (1)
Pattern
apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/native/app/src/screens/wallet/wallet.tsx (1)
Pattern
apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/native/app/src/screens/inbox/inbox.tsx (1)
Pattern
apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
Additional comments not posted (15)
apps/native/app/src/screens/more/more.tsx (4)
80-80: Initialize hiddenContent state for iOS.The state
hiddenContentis initialized to handle content visibility on iOS devices.
89-91: Set hiddenContent state to false when component appears.The
useNavigationComponentDidAppearhook is used to sethiddenContentto false when the component appears, ensuring the content is visible on iOS devices.
93-96: Add condition to render content based on hiddenContent state.The content is rendered only if
hiddenContentis false, which addresses the iOS large title visibility issue.
26-27: Add missing import forisIos.Ensure the
isIosutility is correctly imported from../../utils/devices.+ import { isIos } from '../../utils/devices'Likely invalid or redundant comment.
apps/native/app/src/screens/applications/applications.tsx (4)
83-83: Initialize hiddenContent state for iOS.The state
hiddenContentis initialized to handle content visibility on iOS devices.
105-107: Set hiddenContent state to false when component appears.The
useNavigationComponentDidAppearhook is used to sethiddenContentto false when the component appears, ensuring the content is visible on iOS devices.
159-162: Add condition to render content based on hiddenContent state.The content is rendered only if
hiddenContentis false, which addresses the iOS large title visibility issue.
28-29: Add missing imports foruseNavigationComponentDidAppearandisIos.Ensure the
useNavigationComponentDidAppearhook andisIosutility are correctly imported.+ import { useNavigationComponentDidAppear } from 'react-native-navigation-hooks' + import { isIos } from '../../utils/devices'Likely invalid or redundant comment.
apps/native/app/src/screens/wallet/wallet.tsx (4)
100-100: Initialize hiddenContent state for iOS.The state
hiddenContentis initialized to handle content visibility on iOS devices.
199-201: Set hiddenContent state to false when component appears.The
useNavigationComponentDidAppearhook is used to sethiddenContentto false when the component appears, ensuring the content is visible on iOS devices.
267-270: Add condition to render content based on hiddenContent state.The content is rendered only if
hiddenContentis false, which addresses the iOS large title visibility issue.
37-37: Add missing import foruseNavigationComponentDidAppear.Ensure the
useNavigationComponentDidAppearhook is correctly imported fromreact-native-navigation-hooks.+ import { useNavigationComponentDidAppear } from 'react-native-navigation-hooks'Likely invalid or redundant comment.
apps/native/app/src/screens/inbox/inbox.tsx (3)
277-277: Initialize hiddenContent state for iOS.The state
hiddenContentis initialized to handle content visibility on iOS devices.
394-394: Set hiddenContent state to false when component appears.The
useNavigationComponentDidAppearhook is used to sethiddenContentto false when the component appears, ensuring the content is visible on iOS devices.
425-426: Add condition to render content based on hiddenContent state.The content is rendered only if
hiddenContentis false, which addresses the iOS large title visibility issue.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15504 +/- ##
==========================================
- Coverage 37.04% 37.03% -0.02%
==========================================
Files 6557 6557
Lines 134059 134042 -17
Branches 38380 38374 -6
==========================================
- Hits 49668 49645 -23
- Misses 84391 84397 +6
Flags with carried forward coverage won't be shown. Click here to find out more. see 19 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 2 Passed Test Services
|
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (3)
- apps/native/app/src/screens/applications/applications.tsx (5 hunks)
- apps/native/app/src/screens/more/more.tsx (5 hunks)
- apps/native/app/src/screens/wallet/wallet.tsx (5 hunks)
Files skipped from review as they are similar to previous changes (3)
- apps/native/app/src/screens/applications/applications.tsx
- apps/native/app/src/screens/more/more.tsx
- apps/native/app/src/screens/wallet/wallet.tsx
thoreyjona
force-pushed
the
fix/app-large-title-navigation
branch
from
15399f4 to
c85f9c6
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (5)
- apps/native/app/src/screens/applications/applications.tsx (5 hunks)
- apps/native/app/src/screens/inbox/inbox.tsx (5 hunks)
- apps/native/app/src/screens/more/more.tsx (5 hunks)
- apps/native/app/src/screens/wallet/wallet.tsx (5 hunks)
- apps/native/app/src/ui/index.ts (1 hunks)
Files skipped from review due to trivial changes (1)
- apps/native/app/src/ui/index.ts
Files skipped from review as they are similar to previous changes (4)
- apps/native/app/src/screens/applications/applications.tsx
- apps/native/app/src/screens/inbox/inbox.tsx
- apps/native/app/src/screens/more/more.tsx
- apps/native/app/src/screens/wallet/wallet.tsx
* fix: large title on all tab screens now fixed * fix: order of imports
What
Make sure we always show large titles in the top bar of the tab screens.
There is a bug in react-native-navigation/react-native so we need to do a workaround to make sure the large title is shown, see here: wix/react-native-navigation#6717
Checklist:
Summary by CodeRabbit
Bug Fixes
New Features
Chores
inbox-card.