-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fixed application system api staging path #15875
Conversation
WalkthroughThe changes involve updating the configuration for the Changes
Tip We have updated our review workflow to use the Anthropic's Claude family of models. Please share any feedback in the discussion post on our Discord. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (2)
- apps/application-system/api/infra/application-system-api.ts (1 hunks)
- charts/islandis/values.staging.yaml (1 hunks)
Additional context used
Path-based instructions (1)
apps/application-system/api/infra/application-system-api.ts (1)
Pattern
apps/**/*
: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
Additional comments not posted (2)
apps/application-system/api/infra/application-system-api.ts (1)
60-60
: LGTM!The change to the staging path for
XROAD_CHARGE_FJS_V2_PATH
looks good. It correctly updates the environment fromIS-DEV
toIS-TEST
, indicating a shift from a development context to a testing context for the staging configuration.charts/islandis/values.staging.yaml (1)
832-832
: LGTM!The change to
XROAD_CHARGE_FJS_V2_PATH
looks good. Updating the path fromIS-DEV
toIS-TEST
for the staging configuration makes sense.
* fix: fixed application system api staging path * chore: charts update dirty files --------- Co-authored-by: andes-it <builders@andes.is>
* fix: fixed application system api staging path * chore: charts update dirty files --------- Co-authored-by: andes-it <builders@andes.is>
...
Attach a link to issue if relevant
What
Specify what you're trying to achieve
Why
Specify why you need to achieve this
Screenshots / Gifs
Attach Screenshots / Gifs to help reviewers understand the scope of the pull request
Checklist:
Summary by CodeRabbit
New Features
Bug Fixes