fix(chore): missing env for application system #15926
Conversation
WalkthroughThis pull request introduces two new entities, Changes
Possibly related PRs
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- apps/application-system/api/infra/application-system-api.ts (2 hunks)
Additional context used
Path-based instructions (1)
apps/application-system/api/infra/application-system-api.ts (1)
Pattern
apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
Additional comments not posted (2)
apps/application-system/api/infra/application-system-api.ts (2)
37-38: Ensure proper integration of new entities.The addition of
HealthDirectorateVaccinationandHealthDirectorateOrganDonationto the import list is noted. It's crucial to ensure that these entities are properly integrated into the system and that their usage aligns with the intended functionality. Additionally, verify that all necessary configurations and dependencies for these entities are correctly set up in the system.Verification successful
Integration of new entities is verified.
The entities
HealthDirectorateVaccinationandHealthDirectorateOrganDonationare properly integrated into the system. They are used across multiple files, including configuration and service setup files, indicating that their integration aligns with the intended functionality.
infra/src/dsl/xroad.ts: Definition of the entities.apps/application-system/api/src/app/app.module.ts: Client configurations.libs/clients/health-directorate/src/lib/clients: Service and provider implementations.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the integration and usage of the new entities in the system. # Test: Search for the usage of the new entities. Expect: Proper integration and configuration. rg --type typescript -A 5 $'HealthDirectorateVaccination|HealthDirectorateOrganDonation'Length of output: 124
Script:
#!/bin/bash # Description: Verify the integration and usage of the new entities in the system. # Test: Search for the usage of the new entities. Expect: Proper integration and configuration. rg -g '*.ts' -A 5 $'HealthDirectorateVaccination|HealthDirectorateOrganDonation'Length of output: 24419
295-296: Review integration of new entities in service setup.The integration of
HealthDirectorateVaccinationandHealthDirectorateOrganDonationinto theserviceSetupfunction via the.xroadmethod is noted. Ensure that this integration is correctly implemented and that it aligns with the system's architecture and requirements. It's also important to verify that all necessary configurations for these entities are correctly set up and that they function as expected within the system.
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (3)
- charts/islandis/values.dev.yaml (1 hunks)
- charts/islandis/values.prod.yaml (1 hunks)
- charts/islandis/values.staging.yaml (1 hunks)
Additional comments not posted (6)
charts/islandis/values.staging.yaml (2)
636-636: Correct addition of organ donation path.The environment variable
XROAD_HEALTH_DIRECTORATE_ORGAN_DONATION_PATHhas been correctly added according to the PR description. This addition should enable the application to handle organ donation services effectively.
638-638: Correct addition of vaccination path.The environment variable
XROAD_HEALTH_DIRECTORATE_VACCINATION_PATHhas been correctly added as per the PR description. This should facilitate the handling of vaccination services within the application.charts/islandis/values.prod.yaml (2)
628-628: Added environment variable for organ donation service.The addition of
XROAD_HEALTH_DIRECTORATE_ORGAN_DONATION_PATHis aligned with the PR's objective to address missing environment variables for the Health Directorate. This should resolve the specific issue related to the organ donation service endpoint.
630-630: Added environment variable for vaccination service.The addition of
XROAD_HEALTH_DIRECTORATE_VACCINATION_PATHis consistent with the PR's goal to enhance the application's functionality by providing a direct endpoint for vaccination services. This is a crucial update for the Health Directorate's API configurations.charts/islandis/values.dev.yaml (2)
638-638: Added environment variable for organ donation path.The addition of
XROAD_HEALTH_DIRECTORATE_ORGAN_DONATION_PATHis correctly formatted and placed under theapplication-system-apisection, aligning with the PR's objective to enhance health-related functionalities.
640-640: Added environment variable for vaccination path.The addition of
XROAD_HEALTH_DIRECTORATE_VACCINATION_PATHis correctly formatted and placed under theapplication-system-apisection. This change supports the expansion of health services related to vaccination, which is crucial for the application's functionality.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15926 +/- ##
=======================================
Coverage 36.80% 36.80%
=======================================
Files 6693 6693
Lines 137124 137124
Branches 38975 38975
=======================================
Hits 50469 50469
Misses 86655 86655
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
|
Datadog ReportAll test runs ✅ 3 Total Test Services: 0 Failed, 3 Passed Test Services
|
* fix: missing env * chore: charts update dirty files --------- Co-authored-by: andes-it <builders@andes.is> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Application system - Health Directorate
What
Missing env variables
Why
Causing errors 😭
Checklist:
Summary by CodeRabbit