fix(native-app): decrease size of vehicle card on home page

[thoreyjona]

What

Vehicle card in widget on home screen was set to have minHeight 176px to accommodate vehicles with long names that would wrap into two lines. (We want all vehicle cards in the widget to be of the same size, that is the reason we set minHeight to the size of the biggest possible card). This was causing really big cards so we decided to truncate the name on the home screen. They are not truncated on the vehicles screen, then they are dynamically sized based on content.

Screenshots / Gifs

Before:

After:

Attach Screenshots / Gifs to help reviewers understand the scope of the pull request

Checklist:

• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• Formatting passes locally with my changes
• I have rebased against main before asking for a review

Summary by CodeRabbit

• New Features

  • Enhanced vehicle item display by optimizing height, allowing more items to fit within the viewport.
  • Improved title presentation in vehicle cards with new properties for better text control, ensuring titles do not exceed one line and applying ellipsis for overflow.

• Bug Fixes

  • Adjusted text overflow handling in vehicle titles to prevent layout issues.

[coderabbitai]

Walkthrough

The changes involve modifications to the VehiclesModule and VehicleCard components. The VehiclesModule has had its minHeight property for vehicle items reduced from 176 to 152. In the VehicleCard, the Title component has been enhanced with two new props: numberOfLines and ellipsizeMode, which control the text display based on the specified minimum height. These adjustments focus on optimizing layout and text presentation without altering the overall functionality of the components.

Changes

File Path	Change Summary
apps/native/app/src/screens/home/vehicles-module.tsx	Adjusted minHeight from 176 to 152 for vehicle items.
apps/native/app/src/ui/lib/card/vehicle-card.tsx	Added numberOfLines and ellipsizeMode props to Title component for better text control.

Possibly related PRs

• fix(native-app): fix android crash due to borderRadius set to string value #16009: The changes in vehicle-item.tsx involve styling adjustments that may relate to the layout optimizations seen in the VehiclesModule component, as both PRs focus on improving the visual presentation and organization of vehicle-related components.

---

Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 1027b26 and 098f24b.

Files selected for processing (1)

• apps/native/app/src/screens/home/vehicles-module.tsx (1 hunks)

Files skipped from review as they are similar to previous changes (1)

• apps/native/app/src/screens/home/vehicles-module.tsx

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  -- I pushed a fix in commit <commit_id>, please review it.
  -- Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  -- @coderabbitai generate unit testing code for this file.
  -- @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  -- @coderabbitai generate interesting stats about this repository and render them as a table.
  -- @coderabbitai read src/utils.ts and generate unit testing code.
  -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.86%. Comparing base (deb2c31) to head (1027b26).
Report is 30 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #15972      +/-   ##
==========================================
- Coverage   36.86%   36.86%   -0.01%     
==========================================
  Files        6714     6715       +1     
  Lines      137611   137631      +20     
  Branches    39119    39132      +13     
==========================================
  Hits        50732    50732              
- Misses      86879    86899      +20     

Flag	Coverage Δ
web	1.84% <ø> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3c7569...1027b26. Read the comment docs.

[datadog-island-is]

Datadog Report

Branch report: fix/vehicle-card
Commit report: e4dc592
Test service: web

✅ 0 Failed, 84 Passed, 0 Skipped, 32.51s Total Time
➡️ Test Sessions change in coverage: 1 no change

[snaerseljan]

Awesome much better looking