feat(income-plan): Add disabled to TableRepeaterItem #16001

veronikasif · 2024-09-13T13:27:37Z

What

Added disabled to TableRepeaterItem and changed incomePerYear readonly to disabled

Screenshots / Gifs

Input field "Tekjur á ári" is disabled

Checklist:

I have performed a self-review of my own code
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
Formatting passes locally with my changes
I have rebased against main before asking for a review

Summary by CodeRabbit

New Features
- Introduced a disabled property for form fields, enhancing control over user interaction.
- Added flexibility to the TableRepeaterItem type, allowing conditional disabling of items based on application state.
Bug Fixes
- Improved user experience by ensuring non-interactive fields are clearly disabled rather than just read-only.

coderabbitai · 2024-09-13T13:27:48Z

Walkthrough

The changes involve modifications to the IncomePlanForm.ts file, where the readonly property for an income input field has been replaced with a disabled property. This affects how the field behaves based on the activeField condition. Additionally, a new optional disabled property has been added to the TableRepeaterItem type in Fields.ts, and a corresponding disabled prop has been introduced to the Item component in TableRepeaterItem.tsx, allowing for more dynamic control over the enabled/disabled state of UI components.

Changes

Files	Change Summary
`libs/application/templates/.../IncomePlanForm.ts`	Replaced `readonly` property with `disabled` for income input field, changing its interactivity based on `activeField`.
`libs/application/types/src/lib/Fields.ts`	Added new optional `disabled` property to `TableRepeaterItem` type for conditional control over item states.
`libs/application/ui-fields/src/lib/TableRepeaterFormField/.../TableRepeaterItem.tsx`	Introduced `disabled` prop to `Item` component, allowing dynamic disabling based on a boolean or function.

Possibly related PRs

feat(income-plan): Incorrect monthly income when changing between montly and yearly income #15953: This PR modifies the IncomePlanForm.ts file, which is also the file affected in the main PR, focusing on changes to the form's behavior related to income input.
fix(income-plan): Hide IKR when foreign income #15987: This PR also involves changes to the IncomePlanForm.ts file, specifically adding new income types and modifying the logic for currency display, which relates to the overall functionality of the income input form.

Tip

OpenAI O1 model for chat

We have deployed OpenAI's latest O1 model for chat.
OpenAI claims that this model has superior reasoning capabilities than their GPT-4o model.
Please share any feedback with us in the discussions post.

Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between e09340c and 9356d7e.

Files selected for processing (3)

libs/application/templates/social-insurance-administration/income-plan/src/forms/IncomePlanForm.ts (1 hunks)
libs/application/types/src/lib/Fields.ts (1 hunks)
libs/application/ui-fields/src/lib/TableRepeaterFormField/TableRepeaterItem.tsx (3 hunks)

Additional context used

Path-based instructions (3)

libs/application/ui-fields/src/lib/TableRepeaterFormField/TableRepeaterItem.tsx (1)

Pattern libs/**/*: "Confirm that the code adheres to the following:

Reusability of components and hooks across different NextJS apps.

TypeScript usage for defining props and exporting types.

Effective tree-shaking and bundling practices."

libs/application/types/src/lib/Fields.ts (1)

Pattern libs/**/*: "Confirm that the code adheres to the following:

Reusability of components and hooks across different NextJS apps.

TypeScript usage for defining props and exporting types.

Effective tree-shaking and bundling practices."

libs/application/templates/social-insurance-administration/income-plan/src/forms/IncomePlanForm.ts (1)

Pattern libs/**/*: "Confirm that the code adheres to the following:

Reusability of components and hooks across different NextJS apps.

TypeScript usage for defining props and exporting types.

Effective tree-shaking and bundling practices."

Additional comments not posted (5)

libs/application/ui-fields/src/lib/TableRepeaterFormField/TableRepeaterItem.tsx (3)

57-57: LGTM!

The addition of the disabled prop with a default value of false and the ability to accept a boolean or a function enhances the flexibility of the component. The default value ensures that the form field is enabled by default, while the prop type allows for dynamic disabling based on the application and activeValues.

152-157: LGTM!

The code correctly determines the value of the Disabled variable based on the type of the disabled prop. If disabled is a function, it is invoked with application and activeValues as arguments, allowing for dynamic disabling based on the current state. If disabled is not a function, its value is directly assigned to Disabled, handling the case when a boolean value is provided.

Line range hint 1-216: Adheres to the guidelines for the libs directory.

The code in this file follows the best practices and guidelines for the libs directory:

The component is reusable across different NextJS apps.

TypeScript is used to define the props and export types.

The component is modular and can be effectively tree-shaken and bundled.

libs/application/types/src/lib/Fields.ts (1)

97-102: LGTM!

The addition of the disabled property to the TableRepeaterItem type is a valuable enhancement. It allows for more granular control over the enabled/disabled state of table repeater items based on the application's state or specific field values.

The code change adheres to the following best practices:

TypeScript is used effectively to define the prop type.

The change is reusable across different NextJS apps as it is defined in a shared library.

Great work on this flexible and reusable addition to the TableRepeaterItem type!

libs/application/templates/social-insurance-administration/income-plan/src/forms/IncomePlanForm.ts (1)

269-269: Confirm the behavioral change from read-only to disabled.

The change from readonly to disabled alters the behavior of the incomePerYear field:

A read-only field allows focusing but prevents edits.

A disabled field is not interactive at all.

This may impact user experience, as users will no longer be able to focus on or interact with the disabled field. Please ensure this aligns with the intended behavior.

The conditional logic to determine when the field should be disabled based on the activeField value remains valid.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

ylfahfa

lgtm 😄

codecov · 2024-09-13T13:37:28Z

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 36.84%. Comparing base (e09340c) to head (9356d7e).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...c/lib/TableRepeaterFormField/TableRepeaterItem.tsx	0.00%	5 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #16001      +/-   ##
==========================================
- Coverage   36.85%   36.84%   -0.01%     
==========================================
  Files        6718     6718              
  Lines      137728   137733       +5     
  Branches    39156    39159       +3     
==========================================
  Hits        50753    50753              
- Misses      86975    86980       +5

Flag	Coverage Δ
air-discount-scheme-web	`0.00% <ø> (ø)`
api	`3.39% <ø> (ø)`
application-api-files	`57.46% <ø> (ø)`
application-core	`72.00% <ø> (-0.34%)`	⬇️
application-system-api	`41.67% <ø> (ø)`
application-template-api-modules	`23.47% <ø> (+0.01%)`	⬆️
application-templates-accident-notification	`22.26% <ø> (ø)`
application-templates-car-recycling	`3.12% <ø> (ø)`
application-templates-criminal-record	`26.96% <ø> (ø)`
application-templates-driving-license	`18.75% <ø> (ø)`
application-templates-estate	`12.55% <ø> (ø)`
application-templates-example-payment	`25.72% <ø> (ø)`
application-templates-financial-aid	`14.39% <ø> (ø)`
application-templates-general-petition	`23.95% <ø> (ø)`
application-templates-health-insurance	`26.88% <ø> (ø)`
application-templates-inheritance-report	`6.45% <ø> (ø)`
application-templates-marriage-conditions	`15.35% <ø> (ø)`
application-templates-mortgage-certificate	`44.15% <ø> (ø)`
application-templates-parental-leave	`29.31% <ø> (+0.11%)`	⬆️
application-types	`6.74% <ø> (ø)`
application-ui-components	`1.52% <ø> (ø)`
application-ui-shell	`21.74% <0.00%> (-0.02%)`	⬇️
clients-charge-fjs-v2	`24.11% <ø> (ø)`
web	`1.85% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
libs/application/types/src/lib/Fields.ts	`100.00% <ø> (ø)`
...c/lib/TableRepeaterFormField/TableRepeaterItem.tsx	`2.15% <0.00%> (-0.13%)`	⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e09340c...9356d7e. Read the comment docs.

ylfahfa

💯

datadog-island-is · 2024-09-13T13:58:48Z

Datadog Report

All test runs 4770f60 🔗

✅ 21 Total Test Services: 0 Failed, 21 Passed
🔻 Test Sessions change in coverage: 1 decreased (-0.21%), 1 increased (+0.1%), 88 no change

Test Services

This report shows up to 10 services

Service Name	Passed	Skipped	Total Time	Code Coverage Change	Test Service View
`air-discount-scheme-web`	2	0	8.96s	1 no change	Link
`api`	4	0	2.9s	1 no change	Link
`application-api-files`	12	0	6.66s	1 no change	Link
`application-core`	90	0	20.55s	1 decreased (-0.21%)	Link
`application-system-api`	111	2	3m 48.8s	1 no change	Link
`application-template-api-modules`	109	0	1m 53.6s	1 no change	Link
`application-templates-accident-notification`	98	0	20.38s	1 no change	Link
`application-templates-criminal-record`	2	0	11.17s	1 no change	Link
`application-templates-driving-license`	13	0	17.8s	1 no change	Link
`application-templates-example-payment`	2	0	12.7s	1 no change	Link

🔻 Code Coverage Decreases vs Default Branch (1)

application-core - jest 79.46% (-0.21%) - Details

Toti91

LGTM

Add disabled to TableRepeaterItem

c895dbc

veronikasif requested review from a team as code owners September 13, 2024 13:27

Merge branch 'main' into feat/table-repeater-add-disabled

c0039ed

veronikasif added the deprecated:automerge (Disabled) Merge this PR as soon as all checks pass label Sep 13, 2024

ylfahfa approved these changes Sep 13, 2024

View reviewed changes

Toti91 approved these changes Sep 13, 2024

View reviewed changes

Merge branch 'main' into feat/table-repeater-add-disabled

9356d7e

coderabbitai bot approved these changes Sep 13, 2024

View reviewed changes

kodiakhq bot merged commit 8b22584 into main Sep 13, 2024
85 checks passed

kodiakhq bot deleted the feat/table-repeater-add-disabled branch September 13, 2024 14:18

coderabbitai bot mentioned this pull request Nov 15, 2024

feat(native-app): support type: 'Table' in field render - do not merge #16908

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(income-plan): Add disabled to TableRepeaterItem #16001

feat(income-plan): Add disabled to TableRepeaterItem #16001

veronikasif commented Sep 13, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Sep 13, 2024 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

ylfahfa left a comment

codecov bot commented Sep 13, 2024 •

edited

Loading

ylfahfa left a comment

datadog-island-is bot commented Sep 13, 2024 •

edited

Loading

Toti91 left a comment

feat(income-plan): Add disabled to TableRepeaterItem #16001

feat(income-plan): Add disabled to TableRepeaterItem #16001

Conversation

veronikasif commented Sep 13, 2024 • edited by coderabbitai bot Loading

What

Screenshots / Gifs

Checklist:

Summary by CodeRabbit

coderabbitai bot commented Sep 13, 2024 • edited Loading

Walkthrough

Changes

Possibly related PRs

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

ylfahfa left a comment

Choose a reason for hiding this comment

codecov bot commented Sep 13, 2024 • edited Loading

Codecov Report

ylfahfa left a comment

Choose a reason for hiding this comment

datadog-island-is bot commented Sep 13, 2024 • edited Loading

Datadog Report

🔻 Code Coverage Decreases vs Default Branch (1)

Toti91 left a comment

Choose a reason for hiding this comment

veronikasif commented Sep 13, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Sep 13, 2024 •

edited

Loading

codecov bot commented Sep 13, 2024 •

edited

Loading

datadog-island-is bot commented Sep 13, 2024 •

edited

Loading