fix(hid-application): Remove old condition

[Toti91]

Remove old condition

Attach a link to issue if relevant

What

Specify what you're trying to achieve

Why

Specify why you need to achieve this

Screenshots / Gifs

Attach Screenshots / Gifs to help reviewers understand the scope of the pull request

Checklist:

• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• Formatting passes locally with my changes
• I have rebased against main before asking for a review

Summary by CodeRabbit

• New Features
  • Simplified the Health Insurance Declaration Form by removing conditional logic related to spouse and children.

This change enhances user experience by streamlining the form completion process.

[coderabbitai]

Walkthrough

The pull request removes a specific condition from the HealthInsuranceDeclarationForm, which previously checked for the presence of a spouse or children in the answers provided by users. This change simplifies the form's logic by eliminating the conditional requirement based on these factors.

Changes

File	Change Summary
libs/application/templates/health-insurance-declaration/src/forms/HealthInsuranceDeclarationForm.ts	Removed condition: `condition: (answers: FormValue) => !!(answers.hasSpouse

Possibly related PRs

• fix(coi-application): Fix applicant list #16048: This PR modifies the logic in the HealthInsuranceDeclarationService, which is related to the HealthInsuranceDeclarationForm as both deal with health insurance declarations and applicant qualifications.

Suggested labels

automerge

Suggested reviewers

• jonnigs

---

Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between c5b064a and 3bc1388.

Files selected for processing (1)

• libs/application/templates/health-insurance-declaration/src/forms/HealthInsuranceDeclarationForm.ts (0 hunks)

Files not reviewed due to no reviewable changes (1)

• libs/application/templates/health-insurance-declaration/src/forms/HealthInsuranceDeclarationForm.ts

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  -- I pushed a fix in commit <commit_id>, please review it.
  -- Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  -- @coderabbitai generate unit testing code for this file.
  -- @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  -- @coderabbitai read src/utils.ts and generate unit testing code.
  -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.64%. Comparing base (c5b064a) to head (3bc1388).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #16109   +/-   ##
=======================================
  Coverage   36.64%   36.64%           
=======================================
  Files        6748     6748           
  Lines      138813   138813           
  Branches    39450    39450           
=======================================
  Hits        50863    50863           
  Misses      87950    87950           

Flag	Coverage Δ
api	3.39% <ø> (ø)
application-system-api	41.50% <ø> (ø)
application-template-api-modules	23.47% <ø> (+0.01%)	⬆️
application-templates-accident-notification	22.14% <ø> (ø)
application-templates-car-recycling	3.12% <ø> (ø)
application-templates-driving-license	18.63% <ø> (ø)
application-templates-estate	12.35% <ø> (ø)
application-templates-general-petition	23.68% <ø> (ø)
application-templates-health-insurance	26.62% <ø> (ø)
application-templates-inheritance-report	6.45% <ø> (ø)
application-templates-marriage-conditions	15.23% <ø> (ø)
application-templates-parental-leave	30.15% <ø> (ø)
application-ui-components	1.28% <ø> (ø)
application-ui-shell	21.30% <ø> (ø)
web	1.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5b064a...3bc1388. Read the comment docs.

[datadog-island-is]

Datadog Report

All test runs 82bda45 🔗

✅ 12 Total Test Services: 0 Failed, 12 Passed
➡️ Test Sessions change in coverage: 55 no change

Test Services

This report shows up to 10 services

Service Name	Failed	Known Flaky	New Flaky	Passed	Skipped	Total Time	Code Coverage Change	Test Service View
api	0	0	0	4	0	2.71s	1 no change	Link
application-system-api	0	0	0	111	2	3m 21.94s	1 no change	Link
application-template-api-modules	0	0	0	109	0	1m 55.02s	1 no change	Link
application-templates-accident-notification	0	0	0	98	0	19.26s	1 no change	Link
application-templates-driving-license	0	0	0	13	0	15.94s	1 no change	Link
application-templates-general-petition	0	0	0	5	0	12.09s	1 no change	Link
application-templates-health-insurance	0	0	0	16	0	15.95s	1 no change	Link
application-templates-parental-leave	0	0	0	162	0	20.97s	1 no change	Link
application-templates-public-debt-payment-plan	0	0	0	3	0	10.46s	1 no change	Link
application-ui-components	0	0	0	8	0	19.13s	1 no change	Link